This is an archive of the discontinued LLVM Phabricator instance.

Differential D28285

Fix x86 gold tests on no-x86 targets
ClosedPublic

Authored by rmaprath on Jan 4 2017, 3:46 AM.

Details

Reviewers
rengolin
tejohnson
jmolloy
john.brawn
Commits
rG9670051657cc: Fix x86 gold tests on non-x86 targets.
rL290965: Fix x86 gold tests on non-x86 targets.
Summary

These tests are failing on our downstream arm/aarch64 builders. This is because they are missing a target triple and an -m elf_x86_64 option like the rest of the tests.

@rengolin: I noted that none of the public arm/aarch64 bots build+test LLVMgold, any particular reason? I'm thinking we'd able to catch these much sooner if that was the case.

Diff Detail

Event Timeline

rmaprath updated this revision to Diff 83027.Jan 4 2017, 3:46 AM
rmaprath retitled this revision from to Fix x86 gold tests on no-x86 targets.
rmaprath updated this object.
rmaprath added reviewers: rengolin, john.brawn, jmolloy.
rmaprath added subscribers: llvm-commits, rengolin.
Herald added subscribers: mehdi_amini, aemerson. · View Herald TranscriptJan 4 2017, 3:46 AM
tejohnson accepted this revision.Jan 4 2017, 5:56 AM
tejohnson added a reviewer: tejohnson.
tejohnson added a subscriber: tejohnson.

Thanks. A few of these have been fixed before (r286593), and I'd asked but not heard back why there isn't a bot running in that configuration. That would be good for keeping this clean!

This revision is now accepted and ready to land.Jan 4 2017, 5:56 AM
Closed by commit rL290965: Fix x86 gold tests on non-x86 targets. (authored by asiri). · Explain WhyJan 4 2017, 6:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tools/
gold/
X86/
Inputs/
1 line
1 line
1 line
2 lines
4 lines
2 lines
1 line
3 lines
8 lines
2 lines
2 lines
2 lines
2 lines

Diff 83027

test/tools/gold/X86/Inputs/thinlto.ll

target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define void @g() { define void @g() {
entry: entry:

test/tools/gold/X86/Inputs/thinlto_archive1.ll

target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define void @g() { define void @g() {
entry: entry:

test/tools/gold/X86/Inputs/thinlto_archive2.ll

target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define void @h() { define void @h() {
entry: entry:

test/tools/gold/X86/comdat.ll

; RUN: llvm-as %s -o %t1.o ; RUN: llvm-as %s -o %t1.o
; RUN: llvm-as %p/Inputs/comdat.ll -o %t2.o ; RUN: llvm-as %p/Inputs/comdat.ll -o %t2.o
; RUN: %gold -shared -o %t3.o -plugin %llvmshlibdir/LLVMgold.so %t1.o %t2.o \ ; RUN: %gold -shared -o %t3.o -plugin %llvmshlibdir/LLVMgold.so %t1.o %t2.o \
; RUN: -m elf_x86_64 \
; RUN: -plugin-opt=save-temps ; RUN: -plugin-opt=save-temps
; RUN: FileCheck --check-prefix=RES %s < %t3.o.resolution.txt ; RUN: FileCheck --check-prefix=RES %s < %t3.o.resolution.txt
; RUN: llvm-readobj -t %t3.o | FileCheck --check-prefix=OBJ %s ; RUN: llvm-readobj -t %t3.o | FileCheck --check-prefix=OBJ %s
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
$c1 = comdat any $c1 = comdat any

test/tools/gold/X86/opt-level.ll

; RUN: llvm-as -o %t.bc %s ; RUN: llvm-as -o %t.bc %s
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -plugin-opt=save-temps \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -plugin-opt=save-temps \
; RUN: -m elf_x86_64 \
; RUN: -plugin-opt=O0 -r -o %t.o %t.bc ; RUN: -plugin-opt=O0 -r -o %t.o %t.bc
; RUN: llvm-dis < %t.o.0.4.opt.bc -o - | FileCheck --check-prefix=CHECK-O0 %s ; RUN: llvm-dis < %t.o.0.4.opt.bc -o - | FileCheck --check-prefix=CHECK-O0 %s
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -plugin-opt=save-temps \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -plugin-opt=save-temps \
; RUN: -m elf_x86_64 \
; RUN: -plugin-opt=O1 -r -o %t.o %t.bc ; RUN: -plugin-opt=O1 -r -o %t.o %t.bc
; RUN: llvm-dis < %t.o.0.4.opt.bc -o - | FileCheck --check-prefix=CHECK-O1 %s ; RUN: llvm-dis < %t.o.0.4.opt.bc -o - | FileCheck --check-prefix=CHECK-O1 %s
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -plugin-opt=save-temps \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -plugin-opt=save-temps \
; RUN: -m elf_x86_64 \
; RUN: -plugin-opt=O2 -r -o %t.o %t.bc ; RUN: -plugin-opt=O2 -r -o %t.o %t.bc
; RUN: llvm-dis < %t.o.0.4.opt.bc -o - | FileCheck --check-prefix=CHECK-O2 %s ; RUN: llvm-dis < %t.o.0.4.opt.bc -o - | FileCheck --check-prefix=CHECK-O2 %s
Context not available.
; CHECK-O2-NOT: define internal void @foo( ; CHECK-O2-NOT: define internal void @foo(
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define internal void @foo() { define internal void @foo() {
ret void ret void
Context not available.

test/tools/gold/X86/pr25907.ll

; RUN: llvm-as %s -o %t.o ; RUN: llvm-as %s -o %t.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: -shared %t.o -o %t2 ; RUN: -shared %t.o -o %t2
; RUN: llvm-nm %t2 | FileCheck %s ; RUN: llvm-nm %t2 | FileCheck %s
; CHECK: T main ; CHECK: T main
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@main.L = internal unnamed_addr constant [3 x i8*] [i8* blockaddress(@main, %L1), i8* blockaddress(@main, %L2), i8* null], align 16 @main.L = internal unnamed_addr constant [3 x i8*] [i8* blockaddress(@main, %L1), i8* blockaddress(@main, %L2), i8* null], align 16

test/tools/gold/X86/stats.ll

Context not available.
; RUN: llvm-as %s -o %t.o ; RUN: llvm-as %s -o %t.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -shared \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so -shared \
; RUN: -m elf_x86_64 \
; RUN: -plugin-opt=-stats %t.o -o %t2 2>&1 | FileCheck %s ; RUN: -plugin-opt=-stats %t.o -o %t2 2>&1 | FileCheck %s
; CHECK: Statistics Collected ; CHECK: Statistics Collected
Context not available.

test/tools/gold/X86/strip_names.ll

; RUN: llvm-as %s -o %t.o ; RUN: llvm-as %s -o %t.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: -shared %t.o -o %t2.o ; RUN: -shared %t.o -o %t2.o
; RUN: llvm-dis %t2.o.0.2.internalize.bc -o - | FileCheck %s ; RUN: llvm-dis %t2.o.0.2.internalize.bc -o - | FileCheck %s
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=emit-llvm \ ; RUN: --plugin-opt=emit-llvm \
; RUN: -shared %t.o -o %t2.o ; RUN: -shared %t.o -o %t2.o
; RUN: llvm-dis %t2.o -o - | FileCheck ---check-prefix=NONAME %s ; RUN: llvm-dis %t2.o -o - | FileCheck ---check-prefix=NONAME %s
Context not available.
; NONAME: ret i32 %3 ; NONAME: ret i32 %3
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
@GlobalValueName = global i32 0 @GlobalValueName = global i32 0
Context not available.

test/tools/gold/X86/thinlto.ll

Context not available.
; RUN: llvm-as %s -o %t.o ; RUN: llvm-as %s -o %t.o
; RUN: llvm-as %p/Inputs/thinlto.ll -o %t2.o ; RUN: llvm-as %p/Inputs/thinlto.ll -o %t2.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=thinlto-index-only \ ; RUN: --plugin-opt=thinlto-index-only \
; RUN: -shared %t.o %t2.o -o %t3 ; RUN: -shared %t.o %t2.o -o %t3
; RUN: not test -e %t3 ; RUN: not test -e %t3
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: -shared %t.o %t2.o -o %t4 ; RUN: -shared %t.o %t2.o -o %t4
; RUN: llvm-nm %t4 | FileCheck %s --check-prefix=NM ; RUN: llvm-nm %t4 | FileCheck %s --check-prefix=NM
Context not available.
; Ensure gold generates an index and not a binary if requested. ; Ensure gold generates an index and not a binary if requested.
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=thinlto-index-only \ ; RUN: --plugin-opt=thinlto-index-only \
; RUN: -shared %t.o %t2.o -o %t3 ; RUN: -shared %t.o %t2.o -o %t3
Context not available.
; Ensure gold generates an index as well as a binary with save-temps in ThinLTO mode. ; Ensure gold generates an index as well as a binary with save-temps in ThinLTO mode.
; First force single-threaded mode ; First force single-threaded mode
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=jobs=1 \ ; RUN: --plugin-opt=jobs=1 \
Context not available.
; Check with --no-map-whole-files ; Check with --no-map-whole-files
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=jobs=1 \ ; RUN: --plugin-opt=jobs=1 \
Context not available.
; Next force multi-threaded mode ; Next force multi-threaded mode
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=jobs=2 \ ; RUN: --plugin-opt=jobs=2 \
Context not available.
; Test --plugin-opt=obj-path to ensure unique object files generated. ; Test --plugin-opt=obj-path to ensure unique object files generated.
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=jobs=2 \ ; RUN: --plugin-opt=jobs=2 \
; RUN: --plugin-opt=obj-path=%t5.o \ ; RUN: --plugin-opt=obj-path=%t5.o \
Context not available.
; COMBINED-NEXT: </VALUE_SYMTAB ; COMBINED-NEXT: </VALUE_SYMTAB
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
declare void @g(...) declare void @g(...)
Context not available.

test/tools/gold/X86/thinlto_afdo.ll

Context not available.
; RUN: rm -f %t1.o.4.opt.bc ; RUN: rm -f %t1.o.4.opt.bc
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: --plugin-opt=sample-profile=%p/Inputs/afdo.prof \ ; RUN: --plugin-opt=sample-profile=%p/Inputs/afdo.prof \
Context not available.
; RUN: opt -S %t1.o.4.opt.bc | FileCheck %s ; RUN: opt -S %t1.o.4.opt.bc | FileCheck %s
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; CHECK: ProfileSummary ; CHECK: ProfileSummary
declare void @g(...) declare void @g(...)
Context not available.

test/tools/gold/X86/thinlto_archive.ll

Context not available.
; Test importing from archive library via gold, using jobs=1 to ensure ; Test importing from archive library via gold, using jobs=1 to ensure
; output messages are not interleaved. ; output messages are not interleaved.
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=thinlto \ ; RUN: --plugin-opt=thinlto \
; RUN: --plugin-opt=-print-imports \ ; RUN: --plugin-opt=-print-imports \
; RUN: --plugin-opt=jobs=1 \ ; RUN: --plugin-opt=jobs=1 \
Context not available.
; RUN: llvm-nm %t4 | FileCheck %s --check-prefix=NM ; RUN: llvm-nm %t4 | FileCheck %s --check-prefix=NM
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
; CHECK-DAG: Import g ; CHECK-DAG: Import g
declare void @g(...) declare void @g(...)
Context not available.

test/tools/gold/X86/type-merge2.ll

; RUN: llvm-as %s -o %t.o ; RUN: llvm-as %s -o %t.o
; RUN: llvm-as %p/Inputs/type-merge2.ll -o %t2.o ; RUN: llvm-as %p/Inputs/type-merge2.ll -o %t2.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: -shared %t.o %t2.o -o %t3.o ; RUN: -shared %t.o %t2.o -o %t3.o
; RUN: llvm-dis %t3.o.0.2.internalize.bc -o - | FileCheck %s ; RUN: llvm-dis %t3.o.0.2.internalize.bc -o - | FileCheck %s
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
%zed = type { i8 } %zed = type { i8 }
define void @foo() { define void @foo() {

test/tools/gold/X86/visibility.ll

Context not available.
; RUN: llvm-as %p/Inputs/visibility.ll -o %t2.o ; RUN: llvm-as %p/Inputs/visibility.ll -o %t2.o
; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ ; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
; RUN: -m elf_x86_64 \
; RUN: --plugin-opt=save-temps \ ; RUN: --plugin-opt=save-temps \
; RUN: -shared %t.o %t2.o -o %t.so ; RUN: -shared %t.o %t2.o -o %t.so
; RUN: llvm-readobj -t %t.so | FileCheck %s ; RUN: llvm-readobj -t %t.so | FileCheck %s
Context not available.
; IR: define void @foo ; IR: define void @foo
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define weak protected void @foo() { define weak protected void @foo() {
ret void ret void
Context not available.