Decompressor intention is to reduce duplication of code.
Currently LLD has own implementation of decompressor
for compressed debug sections.
This class helps to avoid it and share the code.
LLD patch for reusing it is D28106
Paths
| Differential D28105
[lib/Object] - Introduce Decompressor class. ClosedPublic Authored by grimar on Dec 25 2016, 6:12 AM.
Details Summary Decompressor intention is to reduce duplication of code. This class helps to avoid it and share the code.
Diff Detail Event Timelinegrimar updated this object. grimar updated this object. Comment Actions Overall decent, first round of comments inline.
Comment Actions David, Davide, thanks for review ! Comment Actions I don't think DWARFCompression is a good name because you can compress not only debug sections but any types of sections. Likewise, it shouldn't be in lib/DebugInfo directory. Comment Actions
Probably. lib/Object or lib/Support would be a better fit? (I vote for the former). grimar edited edge metadata. grimar marked 10 inline comments as done. Comment Actions
grimar retitled this revision from [DWARF] - Introduce DWARFCompression class. to [lib/Object] - Introduce Decompressor class..Jan 11 2017, 7:36 AM grimar updated this object. Closed by commit rL291675: [lib/Object] - Introduce Decompressor class. (authored by grimar). · Explain WhyJan 11 2017, 7:37 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 82471 include/llvm/DebugInfo/DWARF/DWARFCompression.h
lib/DebugInfo/DWARF/CMakeLists.txt
lib/DebugInfo/DWARF/DWARFCompression.cpp
lib/DebugInfo/DWARF/DWARFContext.cpp
|
Slightly odd/non-descript name (DWARFDecompressor? it seems specifically for decompressing)