This is an archive of the discontinued LLVM Phabricator instance.

Differential D27767

NFC Changes from modernize-use-auto
AbandonedPublic

Authored by Prazek on Dec 14 2016, 10:55 AM.

Details

Reviewers
alexfh
mehdi_amini
rsmith
Summary

Changes in LLVM code to satisfy Use auto Type Deduction to Make Code More Readable rule in LLVM coding standards.

modernize-use-auto is clang-tidy check.

Diff Detail

Event Timeline

Prazek updated this revision to Diff 81420.Dec 14 2016, 10:55 AM
Prazek retitled this revision from to NFC Changes from modernize-use-auto.
Prazek updated this object.
Prazek added reviewers: mehdi_amini, rsmith, alexfh.
Prazek added a subscriber: cfe-commits.
Herald added subscribers: nemanjai, dschuff, sanjoy, klimek. · View Herald TranscriptDec 14 2016, 10:55 AM
malcolm.parsons added a subscriber: malcolm.parsons.Dec 15 2016, 8:05 AM
malcolm.parsons added inline comments.
lib/StaticAnalyzer/Checkers/TestAfterDivZeroChecker.cpp
106

The check missed this one.

Prazek added inline comments.Dec 15 2016, 9:03 AM
lib/StaticAnalyzer/Checkers/TestAfterDivZeroChecker.cpp
106

I don't think it is miss if getLocationAs<T> returns Optional<T>, because that would suggest that it returns T

Prazek abandoned this revision.May 17 2017, 10:54 AM

Large Diff

This large diff affects 445 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
examples/
AnnotateFunctions/
2 lines
PrintFunctionNames/
2 lines
clang-interpreter/
7 lines
include/
clang/
AST/
9 lines
2 lines
2 lines
8 lines
4 lines
8 lines
40 lines
16 lines
12 lines
2 lines
6 lines
8 lines
4 lines
4 lines
2 lines
4 lines
51 lines
4 lines
2 lines
ASTMatchers/
2 lines
2 lines
4 lines
Analysis/
Analyses/
4 lines
4 lines
4 lines
2 lines
Support/
4 lines
Driver/
2 lines
Lex/
2 lines
Rewrite/
Core/
3 lines
Sema/
3 lines
2 lines
6 lines
2 lines
8 lines
Serialization/
2 lines
StaticAnalyzer/
Core/
BugReporter/
2 lines
15 lines
4 lines
PathSensitive/
6 lines
4 lines
2 lines
9 lines
lib/
ARCMigrate/
23 lines
14 lines
83 lines
3 lines
4 lines
29 lines
5 lines
5 lines
18 lines
4 lines
7 lines
33 lines
28 lines
16 lines
15 lines
48 lines
AST/
14 lines
435 lines
69 lines
20 lines
539 lines
34 lines
26 lines
17 lines
9 lines
2 lines
7 lines
45 lines
87 lines
95 lines
94 lines
6 lines
108 lines
5 lines
55 lines
63 lines
28 lines
347 lines
34 lines
20 lines
217 lines
6 lines
4 lines
3 lines
170 lines
25 lines
4 lines
66 lines
15 lines
9 lines
32 lines
14 lines
2 lines
14 lines
43 lines
4 lines
16 lines
115 lines
42 lines
13 lines
13 lines
19 lines
178 lines
22 lines
20 lines
ASTMatchers/
18 lines
Dynamic/
2 lines
4 lines
3 lines
Analysis/
47 lines
9 lines
106 lines
2 lines
9 lines
4 lines
8 lines
43 lines
13 lines
41 lines
2 lines
32 lines
55 lines
84 lines
38 lines
6 lines
37 lines
Basic/
11 lines
5 lines
7 lines
18 lines
20 lines
11 lines
CodeGen/
24 lines
10 lines
15 lines
50 lines
3 lines
7 lines
102 lines
84 lines
4 lines
64 lines
2 lines
17 lines
44 lines
7 lines
49 lines
41 lines
41 lines
94 lines
4 lines
57 lines
64 lines
7 lines
68 lines
32 lines
42 lines
4 lines
12 lines
15 lines
37 lines
12 lines
30 lines
4 lines
6 lines
50 lines
35 lines
20 lines
10 lines
40 lines
54 lines
50 lines
4 lines
2 lines
134 lines
14 lines
Driver/
20 lines
2 lines
4 lines
16 lines
2 lines
Edit/
18 lines
37 lines
Format/
4 lines
4 lines
4 lines
7 lines
8 lines
Frontend/
46 lines
29 lines
9 lines
4 lines
5 lines
8 lines
4 lines
4 lines
6 lines
4 lines
2 lines
Rewrite/
2 lines
2 lines
4 lines
309 lines
232 lines
6 lines
4 lines
2 lines
2 lines
8 lines
2 lines
Index/
2 lines
12 lines
10 lines
13 lines
14 lines
64 lines
Lex/
7 lines
2 lines
4 lines
16 lines
2 lines
6 lines
2 lines
17 lines
5 lines
2 lines
2 lines
57 lines
2 lines
35 lines
8 lines
Parse/
8 lines
17 lines
5 lines
2 lines
4 lines
35 lines
2 lines
2 lines
3 lines
Rewrite/
10 lines
2 lines
24 lines
11 lines
3 lines
Sema/
45 lines
2 lines
31 lines
4 lines
32 lines
40 lines
34 lines
33 lines
52 lines
15 lines
12 lines
46 lines
68 lines
404 lines
278 lines
4 lines
478 lines
199 lines
438 lines
144 lines
54 lines
497 lines
188 lines
82 lines
119 lines
4 lines
183 lines
48 lines
142 lines
81 lines
56 lines
422 lines
93 lines
169 lines
41 lines
2 lines
309 lines
220 lines
131 lines
193 lines
48 lines
97 lines
211 lines
2 lines
Serialization/
2 lines
261 lines
207 lines
54 lines
4 lines
14 lines
19 lines
5 lines
4 lines
StaticAnalyzer/
Checkers/
7 lines
2 lines
6 lines
10 lines
3 lines
24 lines
16 lines
6 lines
4 lines
4 lines
2 lines
39 lines
2 lines
42 lines
2 lines
22 lines
2 lines
37 lines
19 lines
82 lines
20 lines
20 lines
20 lines
MPI-Checker/
6 lines
6 lines
6 lines
64 lines
10 lines
9 lines
19 lines
2 lines
7 lines
7 lines
14 lines
5 lines
8 lines
4 lines
10 lines
2 lines
70 lines
2 lines
24 lines
9 lines
9 lines
4 lines
7 lines
4 lines
2 lines
10 lines
2 lines
4 lines
2 lines
2 lines
4 lines
4 lines
Core/
7 lines
4 lines
203 lines
108 lines
50 lines
6 lines
8 lines
12 lines
12 lines
4 lines
4 lines
28 lines
99 lines
11 lines
10 lines
28 lines
7 lines
16 lines
81 lines
87 lines
24 lines
30 lines
101 lines
10 lines
10 lines
12 lines
16 lines
20 lines
6 lines
Frontend/
15 lines
10 lines
Tooling/
6 lines
Core/
2 lines
13 lines
8 lines
2 lines
tools/
arcmt-test/
7 lines
clang-offload-bundler/
4 lines
diagtool/
3 lines
3 lines
2 lines
driver/
2 lines
5 lines
11 lines
libclang/
8 lines
402 lines
20 lines
58 lines
37 lines
11 lines
63 lines
20 lines
55 lines
53 lines
8 lines
2 lines
7 lines
71 lines
56 lines
unittests/
AST/
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
ASTMatchers/
8 lines
5 lines
4 lines
Dynamic/
2 lines
3 lines
Basic/
5 lines
Driver/
4 lines
Frontend/
2 lines
10 lines
Lex/
4 lines
3 lines
Tooling/
6 lines
3 lines
11 lines
libclang/
4 lines
utils/
TableGen/
9 lines
2 lines
3 lines
28 lines
46 lines
12 lines

Diff 81420

examples/AnnotateFunctions/AnnotateFunctions.cpp

examples/PrintFunctionNames/PrintFunctionNames.cpp

examples/clang-interpreter/main.cpp

include/clang/AST/ASTLambda.h

include/clang/AST/ASTVector.h

include/clang/AST/Decl.h

include/clang/AST/DeclCXX.h

include/clang/AST/DeclContextInternals.h

include/clang/AST/DeclFriend.h

include/clang/AST/DeclTemplate.h

include/clang/AST/Expr.h

include/clang/AST/ExprCXX.h

include/clang/AST/ExprObjC.h

include/clang/AST/ExternalASTSource.h

include/clang/AST/RecursiveASTVisitor.h

include/clang/AST/Redeclarable.h

include/clang/AST/Stmt.h

include/clang/AST/StmtOpenMP.h

include/clang/AST/StmtVisitor.h

include/clang/AST/Type.h

include/clang/AST/TypeLoc.h

include/clang/AST/VTableBuilder.h

include/clang/ASTMatchers/ASTMatchFinder.h

include/clang/ASTMatchers/ASTMatchers.h

include/clang/ASTMatchers/ASTMatchersInternal.h

include/clang/Analysis/Analyses/Consumed.h

include/clang/Analysis/Analyses/ThreadSafetyCommon.h

include/clang/Analysis/Analyses/ThreadSafetyTraverse.h

include/clang/Analysis/CFG.h

include/clang/Analysis/Support/BumpVector.h

include/clang/Driver/Compilation.h

include/clang/Lex/PTHLexer.h

include/clang/Rewrite/Core/Rewriter.h

include/clang/Sema/Overload.h

include/clang/Sema/Ownership.h

include/clang/Sema/ParsedTemplate.h

include/clang/Sema/Sema.h

include/clang/Sema/Template.h

include/clang/Serialization/ASTBitCodes.h

include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h

include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h

include/clang/StaticAnalyzer/Core/CheckerManager.h

include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h

include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h

include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h

lib/ARCMigrate/ARCMT.cpp

lib/ARCMigrate/FileRemapper.cpp

lib/ARCMigrate/ObjCMT.cpp

lib/ARCMigrate/PlistReporter.cpp

lib/ARCMigrate/TransARCAssign.cpp

lib/ARCMigrate/TransAutoreleasePool.cpp

lib/ARCMigrate/TransBlockObjCVariable.cpp

lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp

lib/ARCMigrate/TransGCAttrs.cpp

lib/ARCMigrate/TransGCCalls.cpp

lib/ARCMigrate/TransProperties.cpp

lib/ARCMigrate/TransRetainReleaseDealloc.cpp

lib/ARCMigrate/TransUnbridgedCasts.cpp

lib/ARCMigrate/TransZeroOutPropsInDealloc.cpp

lib/ARCMigrate/TransformActions.cpp

lib/ARCMigrate/Transforms.cpp

lib/AST/APValue.cpp

lib/AST/ASTContext.cpp

lib/AST/ASTDiagnostic.cpp

lib/AST/ASTDumper.cpp

lib/AST/ASTImporter.cpp

lib/AST/ASTTypeTraits.cpp

lib/AST/CXXInheritance.cpp

lib/AST/Comment.cpp

lib/AST/CommentCommandTraits.cpp

lib/AST/CommentLexer.cpp

lib/AST/CommentParser.cpp

lib/AST/CommentSema.cpp

lib/AST/Decl.cpp

lib/AST/DeclBase.cpp

lib/AST/DeclCXX.cpp

lib/AST/DeclFriend.cpp

lib/AST/DeclObjC.cpp

lib/AST/DeclOpenMP.cpp

lib/AST/DeclPrinter.cpp

lib/AST/DeclTemplate.cpp

lib/AST/DeclarationName.cpp

lib/AST/Expr.cpp

lib/AST/ExprCXX.cpp

lib/AST/ExprClassification.cpp

lib/AST/ExprConstant.cpp

lib/AST/ExprObjC.cpp

lib/AST/InheritViz.cpp

lib/AST/ItaniumCXXABI.cpp

lib/AST/ItaniumMangle.cpp

lib/AST/Mangle.cpp

lib/AST/MicrosoftCXXABI.cpp

lib/AST/MicrosoftMangle.cpp

lib/AST/NSAPI.cpp

lib/AST/NestedNameSpecifier.cpp

lib/AST/OpenMPClause.cpp

lib/AST/ParentMap.cpp

lib/AST/RawCommentList.cpp

lib/AST/RecordLayoutBuilder.cpp

lib/AST/Stmt.cpp

lib/AST/StmtCXX.cpp

lib/AST/StmtIterator.cpp

lib/AST/StmtOpenMP.cpp

lib/AST/StmtPrinter.cpp

lib/AST/StmtProfile.cpp

lib/AST/TemplateBase.cpp

lib/AST/TemplateName.cpp

lib/AST/Type.cpp

lib/AST/TypePrinter.cpp

lib/AST/VTableBuilder.cpp

lib/ASTMatchers/ASTMatchFinder.cpp

lib/ASTMatchers/Dynamic/Marshallers.h

lib/ASTMatchers/Dynamic/Parser.cpp

lib/ASTMatchers/Dynamic/Registry.cpp

lib/Analysis/AnalysisDeclContext.cpp

lib/Analysis/BodyFarm.cpp

lib/Analysis/CFG.cpp

lib/Analysis/CFGStmtMap.cpp

lib/Analysis/CallGraph.cpp

lib/Analysis/CloneDetection.cpp

lib/Analysis/CocoaConventions.cpp

lib/Analysis/Consumed.cpp

lib/Analysis/FormatString.cpp

lib/Analysis/LiveVariables.cpp

lib/Analysis/OSLog.cpp

lib/Analysis/PseudoConstantAnalysis.cpp

lib/Analysis/ReachableCode.cpp

lib/Analysis/ThreadSafety.cpp

lib/Analysis/ThreadSafetyCommon.cpp

lib/Analysis/ThreadSafetyTIL.cpp

lib/Analysis/UninitializedValues.cpp

lib/Basic/Diagnostic.cpp

lib/Basic/DiagnosticIDs.cpp

lib/Basic/IdentifierTable.cpp

lib/Basic/Module.cpp

lib/Basic/SourceManager.cpp

lib/Basic/VirtualFileSystem.cpp

lib/CodeGen/BackendUtil.cpp

lib/CodeGen/CGAtomic.cpp

lib/CodeGen/CGBlocks.cpp

lib/CodeGen/CGBuiltin.cpp

lib/CodeGen/CGCUDANV.cpp

lib/CodeGen/CGCXXABI.cpp

lib/CodeGen/CGCall.cpp

lib/CodeGen/CGClass.cpp

lib/CodeGen/CGCleanup.h

lib/CodeGen/CGCleanup.cpp

lib/CodeGen/CGDebugInfo.h

lib/CodeGen/CGDebugInfo.cpp

lib/CodeGen/CGDecl.cpp

lib/CodeGen/CGDeclCXX.cpp

lib/CodeGen/CGException.cpp

lib/CodeGen/CGExpr.cpp

lib/CodeGen/CGExprAgg.cpp

lib/CodeGen/CGExprCXX.cpp

lib/CodeGen/CGExprComplex.cpp

lib/CodeGen/CGExprConstant.cpp

lib/CodeGen/CGExprScalar.cpp

lib/CodeGen/CGLoopInfo.cpp

lib/CodeGen/CGObjC.cpp

lib/CodeGen/CGObjCGNU.cpp

lib/CodeGen/CGObjCMac.cpp

lib/CodeGen/CGOpenCLRuntime.cpp

lib/CodeGen/CGOpenMPRuntime.cpp

lib/CodeGen/CGRecordLayoutBuilder.cpp

lib/CodeGen/CGStmt.cpp

lib/CodeGen/CGStmtOpenMP.cpp

lib/CodeGen/CGVTables.cpp

lib/CodeGen/CodeGenAction.cpp

lib/CodeGen/CodeGenFunction.h

lib/CodeGen/CodeGenFunction.cpp

lib/CodeGen/CodeGenModule.cpp

lib/CodeGen/CodeGenPGO.cpp

lib/CodeGen/CodeGenTBAA.cpp

lib/CodeGen/CodeGenTypes.cpp

lib/CodeGen/ItaniumCXXABI.cpp

lib/CodeGen/MicrosoftCXXABI.cpp

lib/CodeGen/ModuleBuilder.cpp

lib/CodeGen/ObjectFilePCHContainerOperations.cpp

lib/CodeGen/TargetInfo.cpp

lib/CodeGen/VarBypassDetector.cpp

lib/Driver/Driver.cpp

lib/Driver/MSVCToolChain.cpp

lib/Driver/ToolChains.cpp

lib/Driver/Tools.cpp

lib/Driver/Types.cpp

lib/Edit/EditedSource.cpp

lib/Edit/RewriteObjCFoundationAPI.cpp

lib/Format/Encoding.h

lib/Format/TokenAnalyzer.cpp

lib/Format/TokenAnnotator.h

lib/Format/UnwrappedLineFormatter.cpp

lib/Format/UnwrappedLineParser.cpp

lib/Frontend/ASTConsumers.cpp

lib/Frontend/ASTUnit.cpp

lib/Frontend/CacheTokens.cpp

lib/Frontend/ChainedIncludesSource.cpp

lib/Frontend/CompilerInstance.cpp

lib/Frontend/CompilerInvocation.cpp

lib/Frontend/DependencyFile.cpp

lib/Frontend/FrontendAction.cpp

lib/Frontend/FrontendActions.cpp

lib/Frontend/MultiplexConsumer.cpp

lib/Frontend/PrintPreprocessedOutput.cpp

lib/Frontend/Rewrite/FixItRewriter.cpp

lib/Frontend/Rewrite/HTMLPrint.cpp

lib/Frontend/Rewrite/InclusionRewriter.cpp

lib/Frontend/Rewrite/RewriteModernObjC.cpp

lib/Frontend/Rewrite/RewriteObjC.cpp

lib/Frontend/Rewrite/RewriteTest.cpp

lib/Frontend/SerializedDiagnosticPrinter.cpp

lib/Frontend/SerializedDiagnosticReader.cpp

lib/Frontend/TestModuleFileExtension.cpp

lib/Frontend/TextDiagnosticBuffer.cpp

lib/Frontend/VerifyDiagnosticConsumer.cpp

lib/Index/CodegenNameGenerator.cpp

lib/Index/CommentToXML.cpp

lib/Index/IndexDecl.cpp

lib/Index/IndexSymbol.cpp

lib/Index/IndexingContext.cpp

lib/Index/USRGeneration.cpp

lib/Lex/HeaderMap.cpp

lib/Lex/HeaderSearch.cpp

lib/Lex/Lexer.cpp

lib/Lex/LiteralSupport.cpp

lib/Lex/MacroArgs.cpp

lib/Lex/MacroInfo.cpp

lib/Lex/ModuleMap.cpp

lib/Lex/PPConditionalDirectiveRecord.cpp

lib/Lex/PPDirectives.cpp

lib/Lex/PPExpressions.cpp

lib/Lex/PPLexerChange.cpp

lib/Lex/PTHLexer.cpp

lib/Lex/Pragma.cpp

lib/Lex/PreprocessingRecord.cpp

lib/Lex/Preprocessor.cpp

lib/Parse/ParseCXXInlineMethods.cpp

lib/Parse/ParseDecl.cpp

lib/Parse/ParseDeclCXX.cpp

lib/Parse/ParseObjc.cpp

lib/Parse/ParseOpenMP.cpp

lib/Parse/ParsePragma.cpp

lib/Parse/ParseStmt.cpp

lib/Parse/ParseStmtAsm.cpp

lib/Parse/Parser.cpp

lib/Rewrite/DeltaTree.cpp

lib/Rewrite/HTMLRewrite.cpp

lib/Rewrite/RewriteRope.cpp

lib/Rewrite/Rewriter.cpp

lib/Rewrite/TokenRewriter.cpp

lib/Sema/AnalysisBasedWarnings.cpp

lib/Sema/AttributeList.cpp

lib/Sema/CodeCompleteConsumer.cpp

lib/Sema/DeclSpec.cpp

lib/Sema/IdentifierResolver.cpp

lib/Sema/JumpDiagnostics.cpp

lib/Sema/ScopeInfo.cpp

lib/Sema/Sema.cpp

lib/Sema/SemaAccess.cpp

lib/Sema/SemaAttr.cpp

lib/Sema/SemaCUDA.cpp

lib/Sema/SemaCXXScopeSpec.cpp

lib/Sema/SemaCast.cpp

lib/Sema/SemaChecking.cpp

lib/Sema/SemaCodeComplete.cpp

lib/Sema/SemaCoroutine.cpp

lib/Sema/SemaDecl.cpp

lib/Sema/SemaDeclAttr.cpp

lib/Sema/SemaDeclCXX.cpp

lib/Sema/SemaDeclObjC.cpp

lib/Sema/SemaExceptionSpec.cpp

lib/Sema/SemaExpr.cpp

lib/Sema/SemaExprCXX.cpp

lib/Sema/SemaExprMember.cpp

lib/Sema/SemaExprObjC.cpp

lib/Sema/SemaFixItUtils.cpp

lib/Sema/SemaInit.cpp

lib/Sema/SemaLambda.cpp

lib/Sema/SemaLookup.cpp

lib/Sema/SemaObjCProperty.cpp

lib/Sema/SemaOpenMP.cpp

lib/Sema/SemaOverload.cpp

lib/Sema/SemaPseudoObject.cpp

lib/Sema/SemaStmt.cpp

lib/Sema/SemaStmtAsm.cpp

lib/Sema/SemaStmtAttr.cpp

lib/Sema/SemaTemplate.cpp

lib/Sema/SemaTemplateDeduction.cpp

lib/Sema/SemaTemplateInstantiate.cpp

lib/Sema/SemaTemplateInstantiateDecl.cpp

lib/Sema/SemaTemplateVariadic.cpp

lib/Sema/SemaType.cpp

lib/Sema/TreeTransform.h

lib/Sema/TypeLocBuilder.cpp

lib/Serialization/ASTCommon.h

lib/Serialization/ASTReader.cpp

lib/Serialization/ASTReaderDecl.cpp

lib/Serialization/ASTReaderStmt.cpp

lib/Serialization/ASTWriter.cpp

lib/Serialization/ASTWriterDecl.cpp

lib/Serialization/GlobalModuleIndex.cpp

lib/Serialization/ModuleManager.cpp

lib/Serialization/MultiOnDiskHashTable.h

lib/StaticAnalyzer/Checkers/AnalyzerStatsChecker.cpp

lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp

lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp

lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp

lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp

lib/StaticAnalyzer/Checkers/CStringChecker.cpp

lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp

lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp

lib/StaticAnalyzer/Checkers/CastSizeChecker.cpp

lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp

lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp

lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

lib/StaticAnalyzer/Checkers/ChrootChecker.cpp

lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

lib/StaticAnalyzer/Checkers/DebugCheckers.cpp

lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp

lib/StaticAnalyzer/Checkers/DirectIvarAssignment.cpp

lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp

lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

lib/StaticAnalyzer/Checkers/IdenticalExprChecker.cpp

lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp

lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp

lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp

lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp

lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp

lib/StaticAnalyzer/Checkers/MallocChecker.cpp

lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp

lib/StaticAnalyzer/Checkers/MallocSizeofChecker.cpp

lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp

lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp

lib/StaticAnalyzer/Checkers/NonNullParamChecker.cpp

lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp

lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp

lib/StaticAnalyzer/Checkers/ObjCPropertyChecker.cpp

lib/StaticAnalyzer/Checkers/ObjCSelfInitChecker.cpp

lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp

lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp

lib/StaticAnalyzer/Checkers/PaddingChecker.cpp

lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp

lib/StaticAnalyzer/Checkers/ReturnPointerRangeChecker.cpp

lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp

lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp

lib/StaticAnalyzer/Checkers/TestAfterDivZeroChecker.cpp

Context not available.
const Expr *E = nullptr; const Expr *E = nullptr;
if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>()) if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>())
malcolm.parsonsUnsubmitted
Not Done
ReplyInline Actions

The check missed this one.

malcolm.parsons: The check missed this one.
PrazekAuthorUnsubmitted
Not Done
ReplyInline Actions

I don't think it is miss if getLocationAs<T> returns Optional<T>, because that would suggest that it returns T

Prazek: I don't think it is miss if getLocationAs<T> returns Optional<T>, because that would suggest…
if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>()) { if (const auto *BO = P->getStmtAs<BinaryOperator>()) {
BinaryOperator::Opcode Op = BO->getOpcode(); BinaryOperator::Opcode Op = BO->getOpcode();
if (Op == BO_Div || Op == BO_Rem || Op == BO_DivAssign || if (Op == BO_Div || Op == BO_Rem || Op == BO_DivAssign ||
Op == BO_RemAssign) { Op == BO_RemAssign) {
Context not available.
void TestAfterDivZeroChecker::checkBranchCondition(const Stmt *Condition, void TestAfterDivZeroChecker::checkBranchCondition(const Stmt *Condition,
CheckerContext &C) const { CheckerContext &C) const {
if (const BinaryOperator *B = dyn_cast<BinaryOperator>(Condition)) { if (const auto *B = dyn_cast<BinaryOperator>(Condition)) {
if (B->isComparisonOp()) { if (B->isComparisonOp()) {
const IntegerLiteral *IntLiteral = dyn_cast<IntegerLiteral>(B->getRHS()); const IntegerLiteral *IntLiteral = dyn_cast<IntegerLiteral>(B->getRHS());
bool LRHS = true; bool LRHS = true;
Context not available.
if (hasDivZeroMap(Val, C)) if (hasDivZeroMap(Val, C))
reportBug(Val, C); reportBug(Val, C);
} }
} else if (const UnaryOperator *U = dyn_cast<UnaryOperator>(Condition)) { } else if (const auto *U = dyn_cast<UnaryOperator>(Condition)) {
if (U->getOpcode() == UO_LNot) { if (U->getOpcode() == UO_LNot) {
SVal Val; SVal Val;
if (const ImplicitCastExpr *I = if (const ImplicitCastExpr *I =
Context not available.
reportBug(Val, C); reportBug(Val, C);
} }
} }
} else if (const ImplicitCastExpr *IE = } else if (const auto *IE = dyn_cast<ImplicitCastExpr>(Condition)) {
dyn_cast<ImplicitCastExpr>(Condition)) {
SVal Val = C.getSVal(IE->getSubExpr()); SVal Val = C.getSVal(IE->getSubExpr());
if (hasDivZeroMap(Val, C)) if (hasDivZeroMap(Val, C))
Context not available.

lib/StaticAnalyzer/Checkers/UndefBranchChecker.cpp

lib/StaticAnalyzer/Checkers/UndefCapturedBlockVarChecker.cpp

lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp

lib/StaticAnalyzer/Checkers/UndefinedArraySubscriptChecker.cpp

lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp

lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp

lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp

lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp

lib/StaticAnalyzer/Checkers/ValistChecker.cpp

lib/StaticAnalyzer/Checkers/VforkChecker.cpp

lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp

lib/StaticAnalyzer/Core/AnalysisManager.cpp

lib/StaticAnalyzer/Core/AnalyzerOptions.cpp

lib/StaticAnalyzer/Core/BugReporter.cpp

lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

lib/StaticAnalyzer/Core/CallEvent.cpp

lib/StaticAnalyzer/Core/CheckerHelpers.cpp

lib/StaticAnalyzer/Core/CheckerManager.cpp

lib/StaticAnalyzer/Core/CheckerRegistry.cpp

lib/StaticAnalyzer/Core/CoreEngine.cpp

lib/StaticAnalyzer/Core/DynamicTypeMap.cpp

lib/StaticAnalyzer/Core/Environment.cpp

lib/StaticAnalyzer/Core/ExplodedGraph.cpp

lib/StaticAnalyzer/Core/ExprEngine.cpp

lib/StaticAnalyzer/Core/ExprEngineC.cpp

lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp

lib/StaticAnalyzer/Core/ExprEngineObjC.cpp

lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp

lib/StaticAnalyzer/Core/MemRegion.cpp

lib/StaticAnalyzer/Core/PathDiagnostic.cpp

lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

lib/StaticAnalyzer/Core/ProgramState.cpp

lib/StaticAnalyzer/Core/RegionStore.cpp

lib/StaticAnalyzer/Core/SValBuilder.cpp

lib/StaticAnalyzer/Core/SVals.cpp

lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp

lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp

lib/StaticAnalyzer/Core/Store.cpp

lib/StaticAnalyzer/Core/SymbolManager.cpp

lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp

lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp

lib/Tooling/CompilationDatabase.cpp

lib/Tooling/Core/QualTypeNames.cpp

lib/Tooling/JSONCompilationDatabase.cpp

lib/Tooling/RefactoringCallbacks.cpp

lib/Tooling/Tooling.cpp

tools/arcmt-test/arcmt-test.cpp

tools/clang-offload-bundler/ClangOffloadBundler.cpp

tools/diagtool/DiagTool.cpp

tools/diagtool/ListWarnings.cpp

tools/diagtool/ShowEnabledWarnings.cpp

tools/driver/cc1_main.cpp

tools/driver/cc1as_main.cpp

tools/driver/driver.cpp

tools/libclang/ARCMigrate.cpp

tools/libclang/CIndex.cpp

tools/libclang/CIndexCXX.cpp

tools/libclang/CIndexCodeCompletion.cpp

tools/libclang/CIndexDiagnostic.cpp

tools/libclang/CIndexHigh.cpp

tools/libclang/CXComment.cpp

tools/libclang/CXCompilationDatabase.cpp

tools/libclang/CXCursor.cpp

tools/libclang/CXIndexDataConsumer.cpp

tools/libclang/CXLoadedDiagnostic.cpp

tools/libclang/CXSourceLocation.cpp

tools/libclang/CXString.cpp

tools/libclang/CXType.cpp

tools/libclang/Indexing.cpp

unittests/AST/ASTImporterTest.cpp

unittests/AST/DeclPrinterTest.cpp

unittests/AST/ExternalASTSourceTest.cpp

unittests/AST/MatchVerifier.h

unittests/AST/NamedDeclPrinterTest.cpp

unittests/AST/StmtPrinterTest.cpp

unittests/ASTMatchers/ASTMatchersNodeTest.cpp

unittests/ASTMatchers/ASTMatchersTest.h

unittests/ASTMatchers/ASTMatchersTraversalTest.cpp

unittests/ASTMatchers/Dynamic/ParserTest.cpp

unittests/ASTMatchers/Dynamic/RegistryTest.cpp

unittests/Basic/VirtualFileSystemTest.cpp

unittests/Driver/MultilibTest.cpp

unittests/Frontend/CodeGenActionTest.cpp

unittests/Frontend/FrontendActionTest.cpp

unittests/Lex/PPCallbacksTest.cpp

unittests/Lex/PPConditionalDirectiveRecordTest.cpp

unittests/Tooling/CommentHandlerTest.cpp

unittests/Tooling/TestVisitor.h

unittests/Tooling/ToolingTest.cpp

unittests/libclang/LibclangTest.cpp

utils/TableGen/ClangASTNodesEmitter.cpp

utils/TableGen/ClangAttrEmitter.cpp

utils/TableGen/ClangCommentHTMLNamedCharacterReferenceEmitter.cpp

utils/TableGen/ClangDiagnosticsEmitter.cpp

utils/TableGen/ClangSACheckersEmitter.cpp

utils/TableGen/NeonEmitter.cpp