This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Sema and parsing for 'teams distribute parallel for' pragma
ClosedPublic

Authored by kkwli0 on Dec 2 2016, 8:14 AM.

Diff Detail

Event Timeline

kkwli0 updated this revision to Diff 80071.Dec 2 2016, 8:14 AM
kkwli0 retitled this revision from to [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma.
kkwli0 updated this object.
kkwli0 added a subscriber: cfe-commits.
ABataev added inline comments.Dec 5 2016, 12:31 AM
lib/Basic/OpenMPKinds.cpp
721

You should consider this new directive as a parallel directive. And OMPD_teams_distribute_parallel_for_simd either.

757

Should it be added here along with OMPD_teams_distribute_parallel_for_simd?

kkwli0 marked an inline comment as done.Dec 6 2016, 4:23 PM
kkwli0 added inline comments.
lib/Basic/OpenMPKinds.cpp
757

The isOpenMPNestingDistributeDirective is for the construct that has distribute be the outermost (e.g. distribute *) so that it can be checked against the nesting region whether it is teams or not. I do not think it is necessary to add it here.

kkwli0 updated this revision to Diff 80514.Dec 6 2016, 6:02 PM

Update based on comments in previous review.

ABataev accepted this revision.Dec 8 2016, 1:54 AM
ABataev edited edge metadata.

LG

This revision is now accepted and ready to land.Dec 8 2016, 1:54 AM
This revision was automatically updated to reflect the committed changes.