Page MenuHomePhabricator

sfantao (Samuel Antao)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 15 2014, 11:22 AM (256 w, 5 d)

Recent Activity

Dec 27 2018

sfantao added a comment to D21856: [Driver][OpenMP] Add support to create jobs for bundling actions..

Sorry about the years-later question, but what's the motivation for shelling out to an external command here? In general, LLVM tries to use a library-based approach, and LLVM went e.g. through great lengths do use an integrated assembler so clang doesn't have to shell out to one. Concretely, why isn't there a clang/lib/OffloadBundle library that clang and clang-offload-bundler both use? Does the bundling have to happen out-of-process? And if so, why isn't the process something like clang -cc1bundle instead of a separate executable? It seems weird to make clang depend on another executable next to it.

I apologize for the clueless question.

Dec 27 2018, 4:50 AM

Jul 31 2018

sfantao added inline comments to D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.
Jul 31 2018, 12:39 PM · Restricted Project
sfantao added a comment to D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.

Hi Doru,

Jul 31 2018, 4:19 AM · Restricted Project

May 30 2018

sfantao added a comment to D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.

In a discussion off-list I proposed adding constructor functions to all object files and handle them like shared libraries are already handled today (ie register separately and let the runtime figure out how to relocate symbols in different translation units). I don't have an implementation of that approach so I can't claim that it works and doesn't have a huge performance impact (which we don't want either), but it should be agnostic of the offloading target so it may be worth investigating.

May 30 2018, 3:30 AM · Restricted Project

May 29 2018

sfantao added a comment to D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.

Just to clarify one thing in my last comment:

May 29 2018, 9:00 AM · Restricted Project
sfantao added a comment to D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.

@gtbercea, thanks for the patch.

May 29 2018, 8:36 AM · Restricted Project

Nov 29 2017

sfantao added inline comments to D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs..
Nov 29 2017, 12:10 PM · Restricted Project
sfantao added inline comments to D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs..
Nov 29 2017, 8:00 AM · Restricted Project
sfantao added inline comments to D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs..
Nov 29 2017, 3:23 AM · Restricted Project

Jun 9 2017

sfantao committed rL305090: [OpenMP] Prevent unused-variable warning in libomptarget when compiling in….
[OpenMP] Prevent unused-variable warning in libomptarget when compiling in…
Jun 9 2017, 9:46 AM

Jan 18 2017

sfantao updated subscribers of D28634: [buildbot] Extend libomp builder to test bot standalone and in-tree builds with and without clang bootstrapping..
Jan 18 2017, 11:09 AM

Jan 13 2017

sfantao resigned from D19696: [clang] remove whitespace in `AST/`.
Jan 13 2017, 4:44 AM

Jan 12 2017

sfantao retitled D28634: [buildbot] Extend libomp builder to test bot standalone and in-tree builds with and without clang bootstrapping. from to [buildbot] Extend libomp builder to test bot standalone and in-tree builds with and without clang bootstrapping..
Jan 12 2017, 6:28 PM

Jan 10 2017

sfantao committed rL291567: [buildbot] Add slave to test libomp for ppc64le targets..
[buildbot] Add slave to test libomp for ppc64le targets.
Jan 10 2017, 8:22 AM
sfantao closed D28492: [buildbot] Add slave to test libomp for ppc64le targets..
Jan 10 2017, 8:22 AM
sfantao added a comment to D28492: [buildbot] Add slave to test libomp for ppc64le targets..

Why do we need ii)? i) will use the just-built compiler to test the openmp runtime AFAIK

Jan 10 2017, 7:56 AM
sfantao added a comment to D28492: [buildbot] Add slave to test libomp for ppc64le targets..

Hi Jonas

Jan 10 2017, 7:17 AM

Jan 9 2017

sfantao updated subscribers of D28492: [buildbot] Add slave to test libomp for ppc64le targets..
Jan 9 2017, 3:13 PM
sfantao retitled D28492: [buildbot] Add slave to test libomp for ppc64le targets. from to [buildbot] Add slave to test libomp for ppc64le targets..
Jan 9 2017, 3:12 PM

Jan 5 2017

sfantao committed rL291124: [OpenMP] Add fields for flags in the offload entry descriptor..
[OpenMP] Add fields for flags in the offload entry descriptor.
Jan 5 2017, 8:13 AM
sfantao closed D28298: [OpenMP] Add fields for flags in the offload entry descriptor..
Jan 5 2017, 8:13 AM
sfantao added inline comments to D28298: [OpenMP] Add fields for flags in the offload entry descriptor..
Jan 5 2017, 7:40 AM
sfantao updated the diff for D28298: [OpenMP] Add fields for flags in the offload entry descriptor..
  • Privatize Order, Flags and Kind of the offload entry.
Jan 5 2017, 7:39 AM
sfantao added a comment to D14031: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget..

Thanks for the patch. Here are few comments following Jonas review.

Jan 5 2017, 6:22 AM
sfantao added a comment to D28298: [OpenMP] Add fields for flags in the offload entry descriptor..

Hi Jonas,

Jan 5 2017, 4:49 AM

Jan 4 2017

sfantao retitled D28298: [OpenMP] Add fields for flags in the offload entry descriptor. from to [OpenMP] Add fields for flags in the offload entry descriptor..
Jan 4 2017, 9:32 AM

Dec 12 2016

sfantao committed rL289458: Fix typo and remove unnecessary statement..
Fix typo and remove unnecessary statement.
Dec 12 2016, 11:37 AM
sfantao committed rL289450: Fix format and a few typos in comments..
Fix format and a few typos in comments.
Dec 12 2016, 10:10 AM

Nov 17 2016

sfantao added a comment to D26774: [CUDA] Driver changes to support CUDA compilation on MacOS..

Hi Justin,

Nov 17 2016, 3:17 AM

Nov 3 2016

sfantao committed rL285925: Rename the version of ConstructJob for multiple outputs to….
Rename the version of ConstructJob for multiple outputs to…
Nov 3 2016, 8:51 AM

Oct 28 2016

sfantao committed rL285408: Define extra variable in OpenMP offloading driver tests..
Define extra variable in OpenMP offloading driver tests.
Oct 28 2016, 8:52 AM
sfantao added a comment to D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..

Hi Michael,

Oct 28 2016, 8:34 AM
sfantao committed rL285404: Change OpenMP offload driver tests so that it doesn't use the full file path….
Change OpenMP offload driver tests so that it doesn't use the full file path…
Oct 28 2016, 8:21 AM
sfantao abandoned D9888: [OPENMP] Driver support for OpenMP offloading.

Hi Jonas,

Oct 28 2016, 3:53 AM

Oct 27 2016

sfantao added a comment to D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..

A PR was generated as requested by Hal explaining why we do not generate jobs for NVPTX targets yet.

Oct 27 2016, 12:20 PM
sfantao committed rL285327: Use -fopenmp=libomp in all OpenMP offloading tests..
Use -fopenmp=libomp in all OpenMP offloading tests.
Oct 27 2016, 11:39 AM
sfantao committed rL285326: [Driver][OpenMP] Add support to create jobs for unbundling actions..
[Driver][OpenMP] Add support to create jobs for unbundling actions.
Oct 27 2016, 11:24 AM
sfantao closed D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions..
Oct 27 2016, 11:24 AM
sfantao updated the diff for D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions..
  • Rebase.
Oct 27 2016, 11:23 AM
sfantao committed rL285325: [Driver][OpenMP] Add support to create jobs for bundling actions..
[Driver][OpenMP] Add support to create jobs for bundling actions.
Oct 27 2016, 11:14 AM
sfantao closed D21856: [Driver][OpenMP] Add support to create jobs for bundling actions..
Oct 27 2016, 11:14 AM
sfantao committed rL285324: [Driver][OpenMP] Update actions builder to create unbundling action when….
[Driver][OpenMP] Update actions builder to create unbundling action when…
Oct 27 2016, 11:10 AM
sfantao closed D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary..
Oct 27 2016, 11:10 AM
sfantao updated the diff for D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary..
  • Add comment explaing that the bundler tool can detect if the input file is a bundle or not.
Oct 27 2016, 11:08 AM
sfantao committed rL285323: [Driver][OpenMP] Update actions builder to create bundling action when….
[Driver][OpenMP] Update actions builder to create bundling action when…
Oct 27 2016, 11:00 AM
sfantao closed D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary..
Oct 27 2016, 11:00 AM
sfantao committed rL285320: [Driver][OpenMP] Add logic for offloading-specific argument translation..
[Driver][OpenMP] Add logic for offloading-specific argument translation.
Oct 27 2016, 10:49 AM
sfantao closed D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation..
Oct 27 2016, 10:49 AM
sfantao committed rL285319: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc….
[Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc…
Oct 27 2016, 10:40 AM
sfantao closed D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains..
Oct 27 2016, 10:40 AM
sfantao updated the diff for D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains..
  • Capitalize Clang in the regression test too.
Oct 27 2016, 10:38 AM
sfantao updated the diff for D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains..
  • Capitalize Clang in linker script comment and explain that the linker script dump option is required to test the driver with -###.
Oct 27 2016, 10:33 AM
sfantao committed rL285314: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..
[Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.
Oct 27 2016, 10:17 AM
sfantao closed D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..
Oct 27 2016, 10:17 AM
sfantao committed rL285311: [Driver][OpenMP] Create tool chains for OpenMP offloading kind..
[Driver][OpenMP] Create tool chains for OpenMP offloading kind.
Oct 27 2016, 9:47 AM
sfantao closed D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind..
Oct 27 2016, 9:47 AM
sfantao committed rL285307: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver..
[Driver][CUDA][OpenMP] Reimplement tool selection in the driver.
Oct 27 2016, 9:38 AM
sfantao closed D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver..
Oct 27 2016, 9:38 AM

Oct 26 2016

sfantao added a comment to D18172: [CUDA][OpenMP] Add a generic offload action builder.

Hi, Samuel.

This change introduced a new crash / assertion failure in the driver.

$ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null
 

Before this patch, we get an error (perhaps not as helpful as we might want, but still):

clang-3.8: error: cannot specify -o when generating multiple output files

After this patch, we get an assertion failure:

clang: ../clang/lib/Driver/Driver.cpp:1610: virtual (anonymous namespace)::OffloadingActionBuilder::DeviceActionBuilder::ActionBuilderReturnCode (anonymous namespace)::OffloadingActionBuilder::CudaActionBuilder::getDeviceDepences(OffloadAction::DeviceDependences &, phases::ID, phases::ID, PhasesTy &): Assertion `CurPhase < phases::Backend && "Generating single CUDA " "instructions should only occur " "before the backend phase!"' failed.
#0 0x0000000001b07e28 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x1b07e28)
#1 0x0000000001b08566 SignalHandler(int) (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x1b08566)
#2 0x00007f4bb7f89330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330)
#3 0x00007f4bb6b7cc37 gsignal /build/eglibc-oGUzwX/eglibc-2.19/signal/../nptl/sysdeps/unix/sysv/linux/raise.c:56:0
#4 0x00007f4bb6b80028 abort /build/eglibc-oGUzwX/eglibc-2.19/stdlib/abort.c:91:0
#5 0x00007f4bb6b75bf6 __assert_fail_base /build/eglibc-oGUzwX/eglibc-2.19/assert/assert.c:92:0
#6 0x00007f4bb6b75ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2)
#7 0x0000000001fa809b (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x1fa809b)
#8 0x0000000001f99981 clang::driver::Driver::BuildActions(clang::driver::Compilation&, llvm::opt::DerivedArgList&, llvm::SmallVector<std::pair<clang::driver::types::ID, llvm::opt::Arg const*>, 16u> const&, llvm::SmallVector<clang::driver::Action*, 3u>&) const (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x1f99981)
#9 0x0000000001f9431c clang::driver::Driver::BuildCompilation(llvm::ArrayRef<char const*>) (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x1f9431c)
#10 0x00000000007c0254 main (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x7c0254)
#11 0x00007f4bb6b67f45 __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:321:0
#12 0x00000000007bd9a2 _start (/usr/local/google/home/jlebar/llvm/release/bin/clang+0x7bd9a2)
Stack dump:
0.	Program arguments: /usr/local/google/home/jlebar/llvm/release/bin/clang -emit-llvm -c -x cuda - -o /dev/null 
1.	Compilation construction
2.	Building compilation actions
Aborted (core dumped)

This was reported two weeks ago by Gurunath Kadam on cfe-dev, but I just got around to bisecting it.

Would you mind spinning a fix for this?

Oct 26 2016, 6:21 PM
sfantao committed rL285264: Remove check for -o option in offloading actions builder..
Remove check for -o option in offloading actions builder.
Oct 26 2016, 6:18 PM
sfantao committed rL285263: Fix bug when compiling CUDA code with -emit-llvm and -o. .
Fix bug when compiling CUDA code with -emit-llvm and -o.
Oct 26 2016, 6:03 PM
sfantao added a comment to D18172: [CUDA][OpenMP] Add a generic offload action builder.

Hi Justin

Oct 26 2016, 2:15 PM

Oct 25 2016

sfantao updated the diff for D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary..
  • Fix typos and use StringRef() instead of const char * to follow what the Driver does today when it comes to specify the bound architectures.
Oct 25 2016, 11:25 AM
sfantao added a comment to D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary..

Hi Hal,

Oct 25 2016, 11:13 AM
sfantao added a comment to D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation..

Hi Hal,

Oct 25 2016, 10:52 AM
sfantao updated the diff for D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation..
  • Fix typos and check -dynamic when it comes to translating arguments for offloading gcc toolchains.
Oct 25 2016, 10:52 AM
sfantao added a comment to D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains..

Hi Hal,

Oct 25 2016, 10:38 AM
sfantao updated the diff for D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains..
  • Address Hal Finkel comments - fix comments/fix linker script comment.
Oct 25 2016, 10:37 AM
sfantao added a comment to D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..

Hi Hal,

Oct 25 2016, 9:50 AM
sfantao updated the diff for D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..
  • Fix typos and add test tht checks phases when OpenMP and CUDA are used simultaneously.
Oct 25 2016, 9:50 AM
sfantao added a comment to D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind..

Hi Hal,

Oct 25 2016, 8:00 AM
sfantao updated the diff for D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind..
  • Address Hal Finkel comments - make diagnostic message more informative.
Oct 25 2016, 7:59 AM
sfantao added a comment to D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver..

Hi Hal,

Oct 25 2016, 7:26 AM
sfantao updated the diff for D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver..
  • Address Hal Finkel suggestions - rename functions/reorder code/fix comments.
Oct 25 2016, 7:25 AM

Oct 20 2016

sfantao committed rL284728: [OpenMP] Fix issue with directives used in a macro..
[OpenMP] Fix issue with directives used in a macro.
Oct 20 2016, 6:29 AM
sfantao closed D25823: [OpenMP] Fix issue with directives used in a macro..
Oct 20 2016, 6:29 AM
sfantao added a comment to D25823: [OpenMP] Fix issue with directives used in a macro..

Hi Jonas,

Oct 20 2016, 6:26 AM
sfantao updated the diff for D25823: [OpenMP] Fix issue with directives used in a macro..
  • Use string format used before.
Oct 20 2016, 6:23 AM
sfantao retitled D25823: [OpenMP] Fix issue with directives used in a macro. from to [OpenMP] Fix issue with directives used in a macro..
Oct 20 2016, 5:29 AM

Sep 30 2016

sfantao committed rL282865: [CUDA][OpenMP] Add a generic offload action builder.
[CUDA][OpenMP] Add a generic offload action builder
Sep 30 2016, 8:43 AM
sfantao closed D18172: [CUDA][OpenMP] Add a generic offload action builder by committing rL282865: [CUDA][OpenMP] Add a generic offload action builder.
Sep 30 2016, 8:43 AM

Sep 21 2016

sfantao updated the diff for D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions..
  • Rebase.
Sep 21 2016, 3:48 PM
sfantao updated the diff for D21856: [Driver][OpenMP] Add support to create jobs for bundling actions..
  • Rebase.
Sep 21 2016, 3:47 PM
sfantao updated the diff for D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary..
  • Rebase.
Sep 21 2016, 3:47 PM
sfantao updated the diff for D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary..
  • Rebase.
Sep 21 2016, 3:47 PM
sfantao updated the diff for D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation..
  • Rebase.
Sep 21 2016, 3:47 PM
sfantao updated the diff for D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains..
  • Rebase.
Sep 21 2016, 3:46 PM
sfantao updated the diff for D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions..
  • Rebase.
Sep 21 2016, 3:46 PM
sfantao updated the diff for D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind..
  • Rebase.
Sep 21 2016, 3:46 PM
sfantao updated the diff for D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver..
  • Rebase.
Sep 21 2016, 3:46 PM
sfantao updated the diff for D18172: [CUDA][OpenMP] Add a generic offload action builder.
  • Rebase.
Sep 21 2016, 3:45 PM

Sep 19 2016

sfantao committed rL281923: Reorder initializers in CallStackFrame so that we don't get a warning..
Reorder initializers in CallStackFrame so that we don't get a warning.
Sep 19 2016, 11:21 AM

Sep 2 2016

sfantao added a comment to D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Hi Eugene,

Sep 2 2016, 5:07 AM
sfantao added a comment to D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Hi Eugene,

Sep 2 2016, 5:07 AM

Aug 25 2016

sfantao added a comment to D23865: Fix memory leaks in clang-offload-bundler.

Oh, I see, thanks for the fix, it looks good.

Aug 25 2016, 8:00 AM
sfantao committed rL279741: Fix offload bundler test to support Windows new lines..
Fix offload bundler test to support Windows new lines.
Aug 25 2016, 7:43 AM

Aug 24 2016

sfantao committed rL279653: Fix offload bundler tests so that diagnostic can start with caps..
Fix offload bundler tests so that diagnostic can start with caps.
Aug 24 2016, 12:00 PM
sfantao committed rL279635: Add target REQUIRES directives to offload bundler test. .
Add target REQUIRES directives to offload bundler test.
Aug 24 2016, 8:55 AM
sfantao committed rL279634: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of….
[Driver][OpenMP][CUDA] Add capability to bundle object files in sections of…
Aug 24 2016, 8:47 AM
sfantao closed D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format..
Aug 24 2016, 8:47 AM