This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Add a bunch of ifdefs for sparc targets to avoid build failures.
ClosedPublic

Authored by m.ostapenko on Dec 1 2016, 7:21 AM.

Details

Summary

Although nobody seems to be interested in sparc at LLVM side, GCC users still want to use sanitizers on sparc targets. We used to apply several local patches to GCC (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958 and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78532) to fix build issues, however we need to adjust/reapply them after each merge...
Can we commit them upstream?

Diff Detail

Repository
rL LLVM

Event Timeline

m.ostapenko updated this revision to Diff 79907.Dec 1 2016, 7:21 AM
m.ostapenko retitled this revision from to [sanitizer] Add a bunch of ifdefs for sparc targets to avoid build failures..
m.ostapenko updated this object.
m.ostapenko added reviewers: kcc, eugenis.
m.ostapenko set the repository for this revision to rL LLVM.
m.ostapenko added a project: Restricted Project.
m.ostapenko added subscribers: llvm-commits, ygribov.

I'm interested in sparc, but not so much sparc/linux. Anyways, seems sane enough to me, especially if it's already seen use in gcc. (Although i'd wait for one of the sanitizer maintainers to chime in)

Are you the original author of these changes in the gcc repo? (If not, can you make sure the original authors are credited and okay with submitting this?)

I'm interested in sparc, but not so much sparc/linux. Anyways, seems sane enough to me, especially if it's already seen use in gcc. (Although i'd wait for one of the sanitizer maintainers to chime in)

Are you the original author of these changes in the gcc repo? (If not, can you make sure the original authors are credited and okay with submitting this?)

No, David S Miller is an author of this patch. I'll ask him about this (I don't expect any problems here). I'm also CC'ing Jakub, GCC maintainer.

kcc accepted this revision.Dec 1 2016, 11:40 AM
kcc edited edge metadata.

LGTM, assuming testing passes.
Please submit once you have ok from the original patch author.

This revision is now accepted and ready to land.Dec 1 2016, 11:40 AM

Ok with David:

"I have no objections to anything which resolves this multi-year painful situation."

This revision was automatically updated to reflect the committed changes.