This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Fix sigaction definition on 32-bit sparc
ClosedPublic

Authored by jrtc27 on Jan 4 2017, 12:28 PM.

Download Raw Diff

Details

Reviewers

kcc
m.ostapenko

Commits

rG0f0407331e6a: [sanitizer] Fix sigaction definition on 32-bit sparc
rCRT291561: [sanitizer] Fix sigaction definition on 32-bit sparc
rL291561: [sanitizer] Fix sigaction definition on 32-bit sparc

Summary

D27301 was almost right, but not quite. This should fix it once and for all.

Diff Detail

Repository: rL LLVM

Event Timeline

jrtc27 updated this revision to Diff 83104.Jan 4 2017, 12:28 PM

jrtc27 retitled this revision from to [sanitizer] Fix sigaction definition on 32-bit sparc.

jrtc27 updated this object.

jrtc27 added a reviewer: kcc.

jrtc27 set the repository for this revision to rL LLVM.

jrtc27 added a project: Restricted Project.

jrtc27 added a subscriber: llvm-commits.

Herald added subscribers: kubamracek, jyknight. · View Herald TranscriptJan 4 2017, 12:28 PM

Full context included (not that it's really relevant...)

Reinstate compiler-rt/trunk/ prefix

LGTM

This revision is now accepted and ready to land.Jan 4 2017, 12:35 PM

Ping; is there anything stopping this from being committed?

LGTM, thank you for fixing this! I'll apply this soon if nobody objects.

Closed by commit rL291561: [sanitizer] Fix sigaction definition on 32-bit sparc (authored by chefmax). · Explain WhyJan 10 2017, 4:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

trunk/

lib/

sanitizer_common/

sanitizer_platform_limits_posix.h

7 lines

Diff 83797

compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.h

	Show First 20 Lines • Show All 629 Lines • ▼ Show 20 Lines
	#if defined(__s390x__)			#if defined(__s390x__)
	int sa_resv;			int sa_resv;
	#else			#else
	__sanitizer_sigset_t sa_mask;			__sanitizer_sigset_t sa_mask;
	#endif			#endif
	#ifndef __mips__			#ifndef __mips__
	#if defined(__sparc__)			#if defined(__sparc__)
	#if __GLIBC_PREREQ (2, 20)			#if __GLIBC_PREREQ (2, 20)
	// On sparc glibc 2.19 and earlier sa_flags was unsigned long, and			// On sparc glibc 2.19 and earlier sa_flags was unsigned long.
	// __glibc_reserved0 didn't exist.			#if defined(__arch64__)
				// To maintain ABI compatibility on sparc64 when switching to an int,
				// __glibc_reserved0 was added.
	int __glibc_reserved0;			int __glibc_reserved0;
				#endif
	int sa_flags;			int sa_flags;
	#else			#else
	unsigned long sa_flags;			unsigned long sa_flags;
	#endif			#endif
	#else			#else
	int sa_flags;			int sa_flags;
	#endif			#endif
	#endif			#endif
	▲ Show 20 Lines • Show All 832 Lines • Show Last 20 Lines