Add MCNoDeprecatedASM into MC ASMParser TargetOption to have an option to disable deprecate warning in asm

[yinma]

Summary

Currently there is no way to disable deprecated warning from asm like this

clang -target arm qc-deprecated-asm.s -c
qc-deprecated-asm.s:30:9: warning: use of SP or PC in the list is deprecated

stmia   r4!, {r12-r14}

We have to have an option what can disable it.

[echristo]

*sigh* I don't like this model, but it's what we've got.

LGTM.

-eric

[weimingz]

can you rename qc-deprecated-asm.s to something like derecated-warning.s

[yinma]

rename unit test case from qc-deprecated-asm.s to deprecated-asm.s

[echristo]

utils/TableGen/AsmMatcherEmitter.cpp

3202 ↗

(On Diff #80338)

Why the check for target parser here?

[echristo]

llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

3202

What's with the TargetParser check here?

[kongyi]

llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

3202

This is not a check (see the trailing ".")

The format is quite confusing, fixing it in https://reviews.llvm.org/D112993.

llvm/trunk/include/llvm/MC/MCTargetOptions.h

public:
 
   /// Enables AddressSanitizer instrumentation at machine level.
   bool SanitizeAddress : 1;
 
   bool MCRelaxAll : 1;
   bool MCNoExecStack : 1;
   bool MCFatalWarnings : 1;
   bool MCNoWarn : 1;
+  bool MCNoDeprecatedWarn : 1;
   bool MCSaveTempLabels : 1;
   bool MCUseDwarfDirectory : 1;
   bool MCIncrementalLinkerCompatible : 1;
   bool MCPIECopyRelocations : 1;
   bool ShowMCEncoding : 1;
   bool ShowMCInst : 1;
   bool AsmVerbose : 1;
 

 
 inline bool operator==(const MCTargetOptions &LHS, const MCTargetOptions &RHS) {
 #define ARE_EQUAL(X) LHS.X == RHS.X
   return (ARE_EQUAL(SanitizeAddress) &&
           ARE_EQUAL(MCRelaxAll) &&
           ARE_EQUAL(MCNoExecStack) &&
           ARE_EQUAL(MCFatalWarnings) &&
           ARE_EQUAL(MCNoWarn) &&
+          ARE_EQUAL(MCNoDeprecatedWarn) &&
           ARE_EQUAL(MCSaveTempLabels) &&
           ARE_EQUAL(MCUseDwarfDirectory) &&
           ARE_EQUAL(MCIncrementalLinkerCompatible) &&
           ARE_EQUAL(MCPIECopyRelocations) &&
           ARE_EQUAL(ShowMCEncoding) &&
           ARE_EQUAL(ShowMCInst) &&
           ARE_EQUAL(AsmVerbose) &&
           ARE_EQUAL(DwarfVersion) &&

llvm/trunk/include/llvm/MC/MCTargetOptionsCommandFlags.h

cl::opt<bool> ShowMCInst("asm-show-inst",
                                   "assembly file"));
 
 cl::opt<bool> FatalWarnings("fatal-warnings",
                             cl::desc("Treat warnings as errors"));
 
 cl::opt<bool> NoWarn("no-warn", cl::desc("Suppress all warnings"));
 cl::alias NoWarnW("W", cl::desc("Alias for --no-warn"), cl::aliasopt(NoWarn));
 
+cl::opt<bool> NoDeprecatedWarn("no-deprecated-warn",
+                               cl::desc("Suppress all deprecated warnings"));
+
 cl::opt<std::string>
 ABIName("target-abi", cl::Hidden,
         cl::desc("The name of the ABI to be targeted from the backend."),
         cl::init(""));
 
 static inline MCTargetOptions InitMCTargetOptionsFromFlags() {
   MCTargetOptions Options;
   Options.SanitizeAddress =
       (AsmInstrumentation == MCTargetOptions::AsmInstrumentationAddress);
   Options.MCRelaxAll = RelaxAll;
   Options.MCIncrementalLinkerCompatible = IncrementalLinkerCompatible;
   Options.MCPIECopyRelocations = PIECopyRelocations;
   Options.DwarfVersion = DwarfVersion;
   Options.ShowMCInst = ShowMCInst;
   Options.ABIName = ABIName;
   Options.MCFatalWarnings = FatalWarnings;
   Options.MCNoWarn = NoWarn;
+  Options.MCNoDeprecatedWarn = NoDeprecatedWarn;
   return Options;
 }
 
 #endif

llvm/trunk/lib/MC/MCTargetOptions.cpp

 //===- lib/MC/MCTargetOptions.cpp - MC Target Options --------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "llvm/ADT/StringRef.h"
 #include "llvm/MC/MCTargetOptions.h"
 
 namespace llvm {
 
 MCTargetOptions::MCTargetOptions()
     : SanitizeAddress(false), MCRelaxAll(false), MCNoExecStack(false),
-      MCFatalWarnings(false), MCNoWarn(false), MCSaveTempLabels(false),
+      MCFatalWarnings(false), MCNoWarn(false), MCNoDeprecatedWarn(false),
+      MCSaveTempLabels(false),
       MCUseDwarfDirectory(false), MCIncrementalLinkerCompatible(false),
       MCPIECopyRelocations(false), ShowMCEncoding(false),
       ShowMCInst(false), AsmVerbose(false),
       PreserveAsmComments(true), DwarfVersion(0), ABIName() {}
 
 StringRef MCTargetOptions::getABIName() const {
   return ABIName;
 }
 
 } // end namespace llvm

llvm/trunk/test/CodeGen/ARM/deprecated-asm.s

+// REQUIRES: asserts
+// RUN: llvm-mc < %s  -triple=armv4t-linux-gnueabi -filetype=obj -o %t.o -no-deprecated-warn -stats 2>&1 | FileCheck %s
+// RUN: llvm-mc < %s  -triple=armv4t-linux-gnueabi -filetype=obj -o %t.o 2>&1 | FileCheck %s -check-prefix=WARN
+
+  .text
+  .syntax unified
+  .eabi_attribute 67, "2.09"  @ Tag_conformance
+  .cpu  arm7tdmi
+  .eabi_attribute 6, 2  @ Tag_CPU_arch
+  .eabi_attribute 8, 1  @ Tag_ARM_ISA_use
+  .eabi_attribute 17, 1 @ Tag_ABI_PCS_GOT_use
+  .eabi_attribute 20, 1 @ Tag_ABI_FP_denormal
+  .eabi_attribute 21, 1 @ Tag_ABI_FP_exceptions
+  .eabi_attribute 23, 3 @ Tag_ABI_FP_number_model
+  .eabi_attribute 34, 0 @ Tag_CPU_unaligned_access
+  .eabi_attribute 24, 1 @ Tag_ABI_align_needed
+  .eabi_attribute 25, 1 @ Tag_ABI_align_preserved
+  .eabi_attribute 38, 1 @ Tag_ABI_FP_16bit_format
+  .eabi_attribute 18, 4 @ Tag_ABI_PCS_wchar_t
+  .eabi_attribute 26, 2 @ Tag_ABI_enum_size
+  .eabi_attribute 14, 0 @ Tag_ABI_PCS_R9_use
+  .file "t.c"
+  .globl  foo
+  .p2align  2
+  .type foo,%function
+foo:                                    @ @foo
+  .fnstart
+@ BB#0:                                 @ %entry
+  mov r0, #0
+  bx  lr
+        stmia   r4!, {r12-r14}
+.Lfunc_end0:
+.Ltmp0:
+  .size foo, .Ltmp0-foo
+  .cantunwind
+  .fnend
+
+
+
+// CHECK: Statistic
+// CHECK-NOT: warning
+
+// WARN: warning

llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

#endif
   // Call the post-processing function, if used.
   std::string InsnCleanupFn =
     AsmParser->getValueAsString("AsmParserInstCleanup");
   if (!InsnCleanupFn.empty())
     OS << "    " << InsnCleanupFn << "(Inst);\n";
 
   if (HasDeprecation) {
     OS << "    std::string Info;\n";
-    OS << "    if (MII.get(Inst.getOpcode()).getDeprecatedInfo(Inst, getSTI(), Info)) {\n";
+    OS << "    if (!getParser().getTargetParser().\n";
+    OS << "        getTargetOptions().MCNoDeprecatedWarn &&\n";
+    OS << "        MII.get(Inst.getOpcode()).getDeprecatedInfo(Inst, getSTI(), Info)) {\n";
     OS << "      SMLoc Loc = ((" << Target.getName()
        << "Operand&)*Operands[0]).getStartLoc();\n";
     OS << "      getParser().Warning(Loc, Info, None);\n";
     OS << "    }\n";
   }
 
   OS << "    return Match_Success;\n";
   OS << "  }\n\n";