Page MenuHomePhabricator

joey (Joey Gouly)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2012, 4:35 AM (359 w, 2 d)

Recent Activity

Feb 21 2019

joey committed rGfdf651ee8d0b: [InferAddressSpaces] Fix fallthrough error (authored by joey).
[InferAddressSpaces] Fix fallthrough error
Feb 21 2019, 5:10 AM
joey committed rL354580: [InferAddressSpaces] Fix fallthrough error.
[InferAddressSpaces] Fix fallthrough error
Feb 21 2019, 5:10 AM
joey committed rG92af1360f331: [InferAddressSpaces] Fix crash on select of non-ptr operands (authored by joey).
[InferAddressSpaces] Fix crash on select of non-ptr operands
Feb 21 2019, 4:33 AM
joey accepted D58226: [InferAddressSpaces] Prevent crash on nested ConstantExpr.

Committed revision r354576.

Feb 21 2019, 4:33 AM · Restricted Project
joey closed D58226: [InferAddressSpaces] Prevent crash on nested ConstantExpr.
Feb 21 2019, 4:33 AM · Restricted Project
joey committed rL354576: [InferAddressSpaces] Fix crash on select of non-ptr operands.
[InferAddressSpaces] Fix crash on select of non-ptr operands
Feb 21 2019, 4:31 AM

Feb 19 2019

joey updated the diff for D58226: [InferAddressSpaces] Prevent crash on nested ConstantExpr.

Add the changes to isAddExpression instead.

Feb 19 2019, 7:53 AM · Restricted Project

Feb 14 2019

joey added a comment to D58226: [InferAddressSpaces] Prevent crash on nested ConstantExpr.

Sorry i should have provided more context, this is the original crash:

opt: ../lib/Transforms/Scalar/InferAddressSpaces.cpp:316: void {anonymous}::InferAddressSpaces::appendsFlatAddressExpressionToPostorderStack(llvm::Value*, std::vector<std::pair<llvm::Value*, bool> >&, llvm::DenseSet<llvm::Value*>&) const: Assertion `V->getType()->isPointerTy()' failed.
Feb 14 2019, 8:00 AM · Restricted Project
joey added a reviewer for D58226: [InferAddressSpaces] Prevent crash on nested ConstantExpr: arsenm.
Feb 14 2019, 7:03 AM · Restricted Project
joey created D58226: [InferAddressSpaces] Prevent crash on nested ConstantExpr.
Feb 14 2019, 2:30 AM · Restricted Project
joey abandoned D34871: [OpenCL] Add function name to extension diagnostic.
Feb 14 2019, 2:16 AM

Nov 22 2018

joey abandoned D50840: [InstCombine] Extend collectShuffleElements to support extract/zext/insert patterns.
Nov 22 2018, 3:52 AM

Nov 1 2018

joey updated the diff for D53023: Prototype OpenCL BIFs using Tablegen.

I re-worked where the builtins are actually inserted, now it's in a similar place to the "normal" clang builtins.

Nov 1 2018, 7:38 AM

Oct 11 2018

joey updated the diff for D53023: Prototype OpenCL BIFs using Tablegen.

Re-uploading the patch. The previous version of the patch was missing the include and lib prefixes.

Oct 11 2018, 3:20 AM

Oct 9 2018

joey created D53023: Prototype OpenCL BIFs using Tablegen.
Oct 9 2018, 7:27 AM

Sep 25 2018

joey accepted D51799: [CMake] Avoid REVERSE on empty list.

LGTM

Sep 25 2018, 3:26 AM

Sep 4 2018

joey accepted D51171: Fix some Wundef warnings in Compiler.h.
Sep 4 2018, 3:54 AM

Sep 3 2018

joey added a comment to D51171: Fix some Wundef warnings in Compiler.h.

LGTM!

Sep 3 2018, 7:55 AM
joey added a comment to D50840: [InstCombine] Extend collectShuffleElements to support extract/zext/insert patterns.

Some guidance on how to fix this in the SLPVectorzier would be helpful. Or if it's small enough that someone else can fix it, that's fine with me too.

Sep 3 2018, 2:15 AM

Aug 16 2018

joey added a comment to D50840: [InstCombine] Extend collectShuffleElements to support extract/zext/insert patterns.

Here is the (reduced) motivating example:

Aug 16 2018, 8:27 AM
joey added a comment to D50840: [InstCombine] Extend collectShuffleElements to support extract/zext/insert patterns.
  1. Why is this limited to extensions? Why can't this also be done for trunc? Or more generally, why don't we want to do this if the same operation is applied for all the elements?
  2. Do the vectorizer passes handle this? (Especially in light of the last question of 1.)
Aug 16 2018, 7:12 AM
joey created D50840: [InstCombine] Extend collectShuffleElements to support extract/zext/insert patterns.
Aug 16 2018, 6:48 AM

Aug 9 2017

joey closed D33945: [OpenCL] Add support for missing sub_group functions..

I committed all the parts separately: r309567 (with r309571 to fix a test), r309678 and r310477.

Aug 9 2017, 8:25 AM
joey committed rL310477: [OpenCL] Minor refactoring to reduce copy/pasted code.
[OpenCL] Minor refactoring to reduce copy/pasted code
Aug 9 2017, 7:55 AM

Aug 1 2017

joey committed rL309678: [OpenCL] Add missing subgroup builtins.
[OpenCL] Add missing subgroup builtins
Aug 1 2017, 6:28 AM

Jul 31 2017

joey committed rL309571: [OpenCL] Enable subgroup extension in tests.
[OpenCL] Enable subgroup extension in tests
Jul 31 2017, 8:51 AM
joey committed rL309567: [OpenCL] Add extension Sema check for subgroup builtins.
[OpenCL] Add extension Sema check for subgroup builtins
Jul 31 2017, 8:16 AM

Jul 27 2017

joey updated the diff for D33945: [OpenCL] Add support for missing sub_group functions..

Updated all the comments you made and rebased.

Jul 27 2017, 6:02 AM

Jul 4 2017

joey closed D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins.
Jul 4 2017, 7:34 AM
joey committed rL307067: [OpenCL] Rename err_opencl_enqueue_kernel_expected_type.
[OpenCL] Rename err_opencl_enqueue_kernel_expected_type
Jul 4 2017, 4:50 AM

Jul 3 2017

joey added a comment to D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins.

LGTM.
Do you have another built-in in mind which can use this diagnostic message?
If so, it would make sense to re-use it in the same patch.

Jul 3 2017, 9:14 AM
joey created D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins.
Jul 3 2017, 7:48 AM

Jun 30 2017

joey committed rL306827: [OpenCL] Add function name to extension diagnostic.
[OpenCL] Add function name to extension diagnostic
Jun 30 2017, 7:23 AM
joey added a comment to D34871: [OpenCL] Add function name to extension diagnostic.

Making that change, going to re-run the tests and then I'll commit.

Jun 30 2017, 4:49 AM
joey created D34871: [OpenCL] Add function name to extension diagnostic.
Jun 30 2017, 1:49 AM

Jun 19 2017

joey added a reviewer for D33945: [OpenCL] Add support for missing sub_group functions.: bader.
Jun 19 2017, 2:38 AM

Jun 6 2017

joey created D33945: [OpenCL] Add support for missing sub_group functions..
Jun 6 2017, 9:12 AM
joey closed D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Committed this as r304784.

Jun 6 2017, 3:26 AM
joey committed rL304784: [InstSimplify] Constant fold the new GEP in SimplifyGEPInst..
[InstSimplify] Constant fold the new GEP in SimplifyGEPInst.
Jun 6 2017, 3:17 AM

Jun 2 2017

joey accepted D33801: [InstSimplify][ConstantFolding] Teach constant folding how to handle icmp null, (inttoptr x) as well as it handles icmp (inttoptr x), null.

LGTM!

Jun 2 2017, 3:18 AM
joey updated the diff for D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Thanks for that Craig, I had planned on looking at that today so thanks for doing it!

Jun 2 2017, 3:10 AM

Jun 1 2017

joey updated the diff for D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Constant fold inside SimplifyGEPInst instead.

Jun 1 2017, 8:47 AM

Apr 21 2017

joey abandoned D31185: [MBP] Only run the BranchFolder after RA.

After talking to Matthias and Matt, this seems like the wrong solution.

Apr 21 2017, 2:59 AM
joey added a comment to D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

I wonder if you should just call ConstantFoldInstOperands where we currently call ConstantExpr::getElementPtr? I think that will try to constant fold it before falling back to ConstantExpr::getElementPtr.

Apr 21 2017, 2:56 AM

Apr 12 2017

joey added a comment to D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Ping!

Apr 12 2017, 3:46 AM

Mar 31 2017

joey added a comment to D31185: [MBP] Only run the BranchFolder after RA.

Ping!

Mar 31 2017, 9:48 AM
joey added a comment to D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Do you have insight into how this differs from what we already do? My understanding is that each of the simplify routines immediately try to constant fold.

Mar 31 2017, 8:13 AM

Mar 21 2017

joey created D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .
Mar 21 2017, 10:16 AM
joey created D31185: [MBP] Only run the BranchFolder after RA.
Mar 21 2017, 5:36 AM

Mar 9 2017

joey committed rL297377: [SelectionDAG] Make SelectCode return void.
[SelectionDAG] Make SelectCode return void
Mar 9 2017, 5:50 AM

Feb 10 2017

joey closed D29718: [libclang] [OpenCL] Expose half type by committing rL294754: [libclang] [OpenCL] Expose half type..
Feb 10 2017, 8:02 AM
joey committed rL294754: [libclang] [OpenCL] Expose half type..
[libclang] [OpenCL] Expose half type.
Feb 10 2017, 8:02 AM

Feb 8 2017

joey closed D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Feb 8 2017, 7:12 AM

Feb 7 2017

joey accepted D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Feb 7 2017, 4:11 AM
joey committed rL294295: [APInt] Fix rotl/rotr when the shift amount is greater than the total bit width..
[APInt] Fix rotl/rotr when the shift amount is greater than the total bit width.
Feb 7 2017, 4:09 AM

Jan 26 2017

joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Moved the getLimitedValue call into the helper function.

Jan 26 2017, 4:34 AM

Jan 9 2017

joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Created a helper function with some comments.

Jan 9 2017, 3:24 AM

Jan 6 2017

joey added inline comments to D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Jan 6 2017, 5:00 AM
joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Added a test case using the 'Big' number in the unit test.
Added a test case for a 7-bit number.
Added cases where the previous code would assert due to RHS being 0.

Jan 6 2017, 4:57 AM

Jan 5 2017

joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Updated the code to use 'urem' to get the remainder, rather than calling getZExtValue.

Jan 5 2017, 4:46 AM

Dec 14 2016

joey retitled D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width. from to [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Dec 14 2016, 3:33 AM

Dec 1 2016

joey closed D27049: [OpenCL] Refactor out ReadPipe/WritePipe.

Committed in r288332. Thanks Yaron!

Dec 1 2016, 3:41 AM
joey committed rL288332: [OpenCL] Refactor read_only/write_only pipes..
[OpenCL] Refactor read_only/write_only pipes.
Dec 1 2016, 3:40 AM

Nov 28 2016

joey updated the diff for D27049: [OpenCL] Refactor out ReadPipe/WritePipe.

Pipe types cannot be merged by ASTContext::mergeTypes.

Nov 28 2016, 7:04 AM

Nov 23 2016

joey retitled D27049: [OpenCL] Refactor out ReadPipe/WritePipe from to [OpenCL] Refactor out ReadPipe/WritePipe.
Nov 23 2016, 7:39 AM

Nov 18 2016

joey closed D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe.

Committed as r287343.

Nov 18 2016, 6:23 AM
joey committed rL287343: [OpenCL] Introduce ReadPipeType and WritePipeType..
[OpenCL] Introduce ReadPipeType and WritePipeType.
Nov 18 2016, 6:20 AM

Nov 17 2016

joey added a reviewer for D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe: bader.
Nov 17 2016, 2:19 AM

Nov 16 2016

joey set the repository for D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe to rL LLVM.
Nov 16 2016, 6:37 AM
joey closed D26668: [OpenCL] Minor cleanup to access attributes on images .

Committed as r287100.

Nov 16 2016, 3:53 AM
joey committed rL287100: [OpenCL] Use the semantic spelling of the Access attribute, rather than a….
[OpenCL] Use the semantic spelling of the Access attribute, rather than a…
Nov 16 2016, 3:43 AM

Nov 15 2016

joey added inline comments to D26668: [OpenCL] Minor cleanup to access attributes on images .
Nov 15 2016, 9:25 AM
joey updated the diff for D26668: [OpenCL] Minor cleanup to access attributes on images .

Fixed a latent infinite loop bug in 'getImageAccess', it was dereferencing Attrs, instead of Next.

Nov 15 2016, 9:24 AM
joey set the repository for D26668: [OpenCL] Minor cleanup to access attributes on images to rL LLVM.
Nov 15 2016, 7:05 AM

Oct 24 2016

joey added a comment to D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.

Two minor comments, but otherwise LGTM!

Oct 24 2016, 3:54 AM

Aug 12 2016

joey added inline comments to D23361: [OpenCL] AMDGCN: Fix size_t type.
Aug 12 2016, 7:55 AM

Aug 10 2016

joey committed rL278235: [OpenCL] Fix typo in test that I accidentally introduced in my previous commit..
[OpenCL] Fix typo in test that I accidentally introduced in my previous commit.
Aug 10 2016, 9:12 AM
joey closed D23346: [OpenCL] Change block descriptor address space to constant.

Committed r278234.

Aug 10 2016, 9:10 AM
joey committed rL278234: [OpenCL] Change block descriptor address space to constant..
[OpenCL] Change block descriptor address space to constant.
Aug 10 2016, 9:04 AM
joey added reviewers for D23346: [OpenCL] Change block descriptor address space to constant: yaxunl, Anastasia.
Aug 10 2016, 3:30 AM
joey retitled D23346: [OpenCL] Change block descriptor address space to constant from to [OpenCL] Change block descriptor address space to constant.
Aug 10 2016, 2:40 AM

May 11 2016

joey accepted D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

LGTM!

May 11 2016, 1:36 AM

Nov 3 2014

joey accepted D6077: Emit OpenCL local global variables without zeorinitializer .

LGTM! (Apart from those tiny changes)

Nov 3 2014, 6:05 AM

Sep 9 2014

joey added a comment to D5258: Select Elimination in InstCombine.

Drive-by comments.

Sep 9 2014, 2:10 AM

Jun 5 2014

joey closed D4036: When producing an InlineAsm warning, don't automatically promote it to an error.
Jun 5 2014, 2:32 PM
joey accepted D4036: When producing an InlineAsm warning, don't automatically promote it to an error.
Jun 5 2014, 2:32 PM
joey added a comment to D4036: When producing an InlineAsm warning, don't automatically promote it to an error.

Thanks Alp!

Jun 5 2014, 2:32 PM
joey retitled D4036: When producing an InlineAsm warning, don't automatically promote it to an error from to When producing an InlineAsm warning, don't automatically promote it to an error.
Jun 5 2014, 11:58 AM

May 16 2014

joey closed D3775: [ASTMatchers] Allow isImplicit on all Decls..
May 16 2014, 12:48 PM
joey added a comment to D3775: [ASTMatchers] Allow isImplicit on all Decls..

Thanks guys, r209006!

May 16 2014, 12:47 PM

May 15 2014

joey updated the diff for D3775: [ASTMatchers] Allow isImplicit on all Decls..

Fixed the comment! Ok now?

May 15 2014, 2:19 PM
joey retitled D3775: [ASTMatchers] Allow isImplicit on all Decls. from to [ASTMatchers] Allow isImplicit on all Decls..
May 15 2014, 1:16 AM

May 13 2014

joey abandoned D3746: [CGP] Fix a crash when "Result" is a nullptr..

Thanks Chandler, r208705!

May 13 2014, 8:50 AM
joey accepted D3746: [CGP] Fix a crash when "Result" is a nullptr..
May 13 2014, 8:50 AM
joey retitled D3746: [CGP] Fix a crash when "Result" is a nullptr. from to [CGP] Fix a crash when "Result" is a nullptr..
May 13 2014, 8:07 AM

May 3 2014

joey closed D3598: [ARM64] Select ANDWri correctly in FastISel.

Thanks Tim! r207917

May 3 2014, 10:37 AM

May 2 2014

joey retitled D3598: [ARM64] Select ANDWri correctly in FastISel from to [ARM64] Select ANDWri correctly in FastISel.
May 2 2014, 4:00 PM

May 1 2014

joey accepted D3557: CodeGen: rename __builtin_arm_sevl to __sevl.

LGTM.

May 1 2014, 10:12 AM

Apr 24 2014

joey added a comment to D3495: CodeGen: remove use of @llvm.arm.sevl.

LGTM.

Apr 24 2014, 4:21 PM