joey (Joey Gouly)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 1 2012, 4:35 AM (234 w, 12 h)

Recent Activity

Apr 21 2017

joey abandoned D31185: [MBP] Only run the BranchFolder after RA.

After talking to Matthias and Matt, this seems like the wrong solution.

Apr 21 2017, 2:59 AM
joey added a comment to D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

I wonder if you should just call ConstantFoldInstOperands where we currently call ConstantExpr::getElementPtr? I think that will try to constant fold it before falling back to ConstantExpr::getElementPtr.

Apr 21 2017, 2:56 AM

Apr 12 2017

joey added a comment to D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Ping!

Apr 12 2017, 3:46 AM

Mar 31 2017

joey added a comment to D31185: [MBP] Only run the BranchFolder after RA.

Ping!

Mar 31 2017, 9:48 AM
joey added a comment to D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .

Do you have insight into how this differs from what we already do? My understanding is that each of the simplify routines immediately try to constant fold.

Mar 31 2017, 8:13 AM

Mar 21 2017

joey created D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification .
Mar 21 2017, 10:16 AM
joey created D31185: [MBP] Only run the BranchFolder after RA.
Mar 21 2017, 5:36 AM

Mar 9 2017

joey committed rL297377: [SelectionDAG] Make SelectCode return void.
[SelectionDAG] Make SelectCode return void
Mar 9 2017, 5:50 AM

Feb 10 2017

joey closed D29718: [libclang] [OpenCL] Expose half type by committing rL294754: [libclang] [OpenCL] Expose half type..
Feb 10 2017, 8:02 AM
joey committed rL294754: [libclang] [OpenCL] Expose half type..
[libclang] [OpenCL] Expose half type.
Feb 10 2017, 8:02 AM

Feb 8 2017

joey closed D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Feb 8 2017, 7:12 AM

Feb 7 2017

joey accepted D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Feb 7 2017, 4:11 AM
joey committed rL294295: [APInt] Fix rotl/rotr when the shift amount is greater than the total bit width..
[APInt] Fix rotl/rotr when the shift amount is greater than the total bit width.
Feb 7 2017, 4:09 AM

Jan 26 2017

joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Moved the getLimitedValue call into the helper function.

Jan 26 2017, 4:34 AM

Jan 9 2017

joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Created a helper function with some comments.

Jan 9 2017, 3:24 AM

Jan 6 2017

joey added inline comments to D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Jan 6 2017, 5:00 AM
joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Added a test case using the 'Big' number in the unit test.
Added a test case for a 7-bit number.
Added cases where the previous code would assert due to RHS being 0.

Jan 6 2017, 4:57 AM

Jan 5 2017

joey updated the diff for D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..

Updated the code to use 'urem' to get the remainder, rather than calling getZExtValue.

Jan 5 2017, 4:46 AM

Dec 14 2016

joey retitled D27749: [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width. from to [APFloat] Fix rotl/rotr when the shift amount is greater than the total bit width..
Dec 14 2016, 3:33 AM

Dec 1 2016

joey closed D27049: [OpenCL] Refactor out ReadPipe/WritePipe.

Committed in r288332. Thanks Yaron!

Dec 1 2016, 3:41 AM
joey committed rL288332: [OpenCL] Refactor read_only/write_only pipes..
[OpenCL] Refactor read_only/write_only pipes.
Dec 1 2016, 3:40 AM

Nov 28 2016

joey updated the diff for D27049: [OpenCL] Refactor out ReadPipe/WritePipe.

Pipe types cannot be merged by ASTContext::mergeTypes.

Nov 28 2016, 7:04 AM

Nov 23 2016

joey retitled D27049: [OpenCL] Refactor out ReadPipe/WritePipe from to [OpenCL] Refactor out ReadPipe/WritePipe.
Nov 23 2016, 7:39 AM

Nov 18 2016

joey closed D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe.

Committed as r287343.

Nov 18 2016, 6:23 AM
joey committed rL287343: [OpenCL] Introduce ReadPipeType and WritePipeType..
[OpenCL] Introduce ReadPipeType and WritePipeType.
Nov 18 2016, 6:20 AM

Nov 17 2016

joey added a reviewer for D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe: bader.
Nov 17 2016, 2:19 AM

Nov 16 2016

joey set the repository for D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe to rL LLVM.
Nov 16 2016, 6:37 AM
joey closed D26668: [OpenCL] Minor cleanup to access attributes on images .

Committed as r287100.

Nov 16 2016, 3:53 AM
joey committed rL287100: [OpenCL] Use the semantic spelling of the Access attribute, rather than a….
[OpenCL] Use the semantic spelling of the Access attribute, rather than a…
Nov 16 2016, 3:43 AM

Nov 15 2016

joey added inline comments to D26668: [OpenCL] Minor cleanup to access attributes on images .
Nov 15 2016, 9:25 AM
joey updated the diff for D26668: [OpenCL] Minor cleanup to access attributes on images .

Fixed a latent infinite loop bug in 'getImageAccess', it was dereferencing Attrs, instead of Next.

Nov 15 2016, 9:24 AM
joey set the repository for D26668: [OpenCL] Minor cleanup to access attributes on images to rL LLVM.
Nov 15 2016, 7:05 AM

Oct 24 2016

joey added a comment to D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.

Two minor comments, but otherwise LGTM!

Oct 24 2016, 3:54 AM

Aug 12 2016

joey updated subscribers of D23361: [OpenCL] AMDGCN: Fix size_t type.
Aug 12 2016, 7:55 AM

Aug 10 2016

joey committed rL278235: [OpenCL] Fix typo in test that I accidentally introduced in my previous commit..
[OpenCL] Fix typo in test that I accidentally introduced in my previous commit.
Aug 10 2016, 9:12 AM
joey closed D23346: [OpenCL] Change block descriptor address space to constant.

Committed r278234.

Aug 10 2016, 9:10 AM
joey committed rL278234: [OpenCL] Change block descriptor address space to constant..
[OpenCL] Change block descriptor address space to constant.
Aug 10 2016, 9:04 AM
joey added reviewers for D23346: [OpenCL] Change block descriptor address space to constant: yaxunl, Anastasia.
Aug 10 2016, 3:30 AM
joey retitled D23346: [OpenCL] Change block descriptor address space to constant from to [OpenCL] Change block descriptor address space to constant.
Aug 10 2016, 2:40 AM

May 11 2016

joey accepted D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

LGTM!

May 11 2016, 1:36 AM

Nov 3 2014

joey accepted D6077: Emit OpenCL local global variables without zeorinitializer .

LGTM! (Apart from those tiny changes)

Nov 3 2014, 6:05 AM

Sep 9 2014

joey added a comment to D5258: Select Elimination in InstCombine.

Drive-by comments.

Sep 9 2014, 2:10 AM

Jun 5 2014

joey closed D4036: When producing an InlineAsm warning, don't automatically promote it to an error.
Jun 5 2014, 2:32 PM
joey accepted D4036: When producing an InlineAsm warning, don't automatically promote it to an error.
Jun 5 2014, 2:32 PM
joey added a comment to D4036: When producing an InlineAsm warning, don't automatically promote it to an error.

Thanks Alp!

Jun 5 2014, 2:32 PM
joey retitled D4036: When producing an InlineAsm warning, don't automatically promote it to an error from to When producing an InlineAsm warning, don't automatically promote it to an error.
Jun 5 2014, 11:58 AM

May 16 2014

joey closed D3775: [ASTMatchers] Allow isImplicit on all Decls..
May 16 2014, 12:48 PM
joey added a comment to D3775: [ASTMatchers] Allow isImplicit on all Decls..

Thanks guys, r209006!

May 16 2014, 12:47 PM

May 15 2014

joey updated the diff for D3775: [ASTMatchers] Allow isImplicit on all Decls..

Fixed the comment! Ok now?

May 15 2014, 2:19 PM
joey retitled D3775: [ASTMatchers] Allow isImplicit on all Decls. from to [ASTMatchers] Allow isImplicit on all Decls..
May 15 2014, 1:16 AM

May 13 2014

joey abandoned D3746: [CGP] Fix a crash when "Result" is a nullptr..

Thanks Chandler, r208705!

May 13 2014, 8:50 AM
joey accepted D3746: [CGP] Fix a crash when "Result" is a nullptr..
May 13 2014, 8:50 AM
joey retitled D3746: [CGP] Fix a crash when "Result" is a nullptr. from to [CGP] Fix a crash when "Result" is a nullptr..
May 13 2014, 8:07 AM

May 3 2014

joey closed D3598: [ARM64] Select ANDWri correctly in FastISel.

Thanks Tim! r207917

May 3 2014, 10:37 AM

May 2 2014

joey retitled D3598: [ARM64] Select ANDWri correctly in FastISel from to [ARM64] Select ANDWri correctly in FastISel.
May 2 2014, 4:00 PM

May 1 2014

joey accepted D3557: CodeGen: rename __builtin_arm_sevl to __sevl.

LGTM.

May 1 2014, 10:12 AM

Apr 24 2014

joey updated subscribers of D3495: CodeGen: remove use of @llvm.arm.sevl.

LGTM.

Apr 24 2014, 4:21 PM