This is an archive of the discontinued LLVM Phabricator instance.

Don't emit "deprecated instruction in IT block" warning if requested
ClosedPublic

Authored by kongyi on Nov 2 2021, 2:27 AM.

Details

Summary

Also fixed formatting in AsmMatcherEmitter because it was confusing.

Diff Detail

Event Timeline

kongyi created this revision.Nov 2 2021, 2:27 AM
kongyi requested review of this revision.Nov 2 2021, 2:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 2:27 AM
kongyi updated this revision to Diff 384021.Nov 2 2021, 2:53 AM
kongyi added a subscriber: srhines.
kristof.beyls accepted this revision.Nov 3 2021, 1:55 AM

GNU binutils has a specific option to silence the warnings about deprecated IT blocks (-m{no-}warn-restrict-it), see https://sourceware.org/legacy-ml/binutils/2019-12/msg00093.html.
I haven't looked up if GNU tools have the equivalent of -no-deprecated-warn.

I also wonder how to specify the "-no-deprecated-warn" option from the clang command line. Is it possible?

Basically, yes, it looks like it's the right thing to also disable warnings related to deprecated IT constructs for -no-deprecated-warn, so this looks like a good change.
But there is probably more to be done to make the option easily accessible from the clang command line and to implement -m{no-}warn-restrict-it for GNU binutils compatibility?

So: this patch LGTM, thanks.

This revision is now accepted and ready to land.Nov 3 2021, 1:55 AM
This revision was landed with ongoing or failed builds.Nov 3 2021, 2:20 AM
This revision was automatically updated to reflect the committed changes.