This is an archive of the discontinued LLVM Phabricator instance.

Implement vector shift builtins - llvm portion.
ClosedPublic

Authored by jtony on Oct 28 2016, 12:20 PM.

Details

Summary

Implemented builtin signatures:

vector unsigned char vec_slv (vector unsigned char, vector unsigned char);
vector unsigned char vec_srv (vector unsigned char, vector unsigned char);

Diff Detail

Event Timeline

jtony updated this revision to Diff 76233.Oct 28 2016, 12:20 PM
jtony retitled this revision from to Implement vector shift builtins - llvm portion..
jtony updated this object.
jtony added a subscriber: llvm-commits.
nemanjai edited edge metadata.Oct 28 2016, 1:18 PM

Other than the minor nit, this LGTM.

lib/Target/PowerPC/PPCInstrAltivec.td
1339

Please fix the spacing. The square bracket needs to line up to just inside the angled bracket (i.e. [ lines up with 1).
Also remove the spaces that make the pattern look out of place with respect to others. It should be:
[(set v16i8:$vD, (int_ppc_altivec_vslv v16i8:$vA, v16i8:$vB))]
Same below.

jtony updated this revision to Diff 76246.Oct 28 2016, 2:36 PM
jtony edited edge metadata.

Fix the spacing and alignment problem in the previous patch.

kbarton accepted this revision.Oct 31 2016, 9:20 AM
kbarton edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 31 2016, 9:20 AM

Committed revision 285681.
Tony, please close this review pending no buildbot failures.

jtony closed this revision.Nov 1 2016, 6:55 AM