This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU : Add a function to enable and disable IEEEBit for SC and shader respectively.
ClosedPublic

Authored by wdng on Oct 19 2016, 12:24 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

wdng updated this revision to Diff 75199.Oct 19 2016, 12:24 PM
wdng retitled this revision from to AMDGPU : Add a function to enable and disable IEEEBit for SC and shader respectively..
wdng updated this object.
wdng added reviewers: tstellarAMD, arsenm, b-sumner.
wdng set the repository for this revision to rL LLVM.
kzhuravl added inline comments.Oct 19 2016, 12:28 PM
lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
551–552

Can we change this to ProgInfo.IEEEMode = STM.enableIEEEBit(MF)?

kzhuravl added inline comments.Oct 19 2016, 1:16 PM
lib/Target/AMDGPU/AMDGPUSubtarget.h
252

I think this is a property of a function, and moving this function to SIMachineFunctionInfo would be better

lib/Target/AMDGPU/AMDGPUSubtarget.h
252

My original thought was that it would be useful to have this function here in case we added a subtarget feature for setting/unsetting the ieee bit.

kzhuravl added inline comments.Oct 19 2016, 1:26 PM
lib/Target/AMDGPU/AMDGPUSubtarget.h
252

Ah, ok. That makes sense then.

wdng updated this revision to Diff 75225.Oct 19 2016, 2:22 PM
wdng edited edge metadata.
wdng marked 4 inline comments as done.

Address issues based on feedback.

wdng updated this revision to Diff 75242.Oct 19 2016, 3:23 PM
wdng edited edge metadata.

Add lit tests using the graphics calling conventions and check that IEEEBit is 0.

kzhuravl accepted this revision.Oct 19 2016, 3:24 PM
kzhuravl added a reviewer: kzhuravl.
kzhuravl edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 19 2016, 3:25 PM
wdng added a comment.Oct 19 2016, 3:26 PM

Thanks a lot, Tom and Konstantin!

This revision was automatically updated to reflect the committed changes.