AMDGPU : Add a function to enable and disable IEEEBit for SC and shader respectively.

[wdng]

Summary

Add a function to enable and disable IEEEBit for SC and shader respectively.

[kzhuravl]

lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp

551–555

Can we change this to ProgInfo.IEEEMode = STM.enableIEEEBit(MF)?

[kzhuravl]

lib/Target/AMDGPU/AMDGPUSubtarget.h

252

I think this is a property of a function, and moving this function to SIMachineFunctionInfo would be better

[• tstellarAMD]

lib/Target/AMDGPU/AMDGPUSubtarget.h

252

My original thought was that it would be useful to have this function here in case we added a subtarget feature for setting/unsetting the ieee bit.

[kzhuravl]

lib/Target/AMDGPU/AMDGPUSubtarget.h

252

Ah, ok. That makes sense then.

[wdng]

Address issues based on feedback.

[wdng]

Add lit tests using the graphics calling conventions and check that IEEEBit is 0.

[kzhuravl]

LGTM

[wdng]

Thanks a lot, Tom and Konstantin!

lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp

   // register.
   ProgInfo.FloatMode = getFPMode(MF);
 
-  ProgInfo.IEEEMode = 0;
+  if (STM.enableIEEEBit(MF))
+    ProgInfo.IEEEMode = 1;
+  else
+    ProgInfo.IEEEMode = 0;
 
   // Make clamp modifier on NaN input returns 0.
   ProgInfo.DX10Clamp = 1;

lib/Target/AMDGPU/AMDGPUSubtarget.h

     return DumpCode;
   }
 
+  bool enableIEEEBit(const MachineFunction &MF) const {
+    return AMDGPU::isCompute(MF.getFunction()->getCallingConv());
+  }
+
   /// Return the amount of LDS that can be used that will not restrict the
   /// occupancy lower than WaveCount.
   unsigned getMaxLocalMemSizeWithWaveCount(unsigned WaveCount) const;