This patch adds Cortex-R52, the new ARM real-time processor, to LLVM. Cortex-R52 implements the ARMv8-R architecture. I have submitted a corresponding patch for review to clang , for clang related changes (and tests).
Details
Diff Detail
Event Timeline
include/llvm/Support/ARMTargetParser.def | ||
---|---|---|
226 | Shouldn't R52 be the default CPU (false -> true), given it's the only entry for ARMv8R? |
include/llvm/Support/ARMTargetParser.def | ||
---|---|---|
98 | OK, it took me a while to get to the bottom of this list and I had to grep through a lot of pre-alpha unreleased documentation so I'll try to explain my reasoning:
| |
226 | I don't think you should mention CRC here because it's no longer an optional extension, it's mandatory. | |
lib/Target/ARM/ARM.td | ||
482 | I agree with all of these except this. Why does ARMv8-R have this but ARMv8-A does not? | |
820 | Because ARMv8-R mandates HWDiv and HWDivARM, I don't think these are required here. |
Revised based on comments from Renato and James. Thanks to both for the review and feedback.
Added back AEK_DSP/FeatureDSP. It was a mistake to remove it seems to be indeed required.
Committed in rL283542. Please specify "Differential revision: <URL>" as last line of commit message.
OK, it took me a while to get to the bottom of this list and I had to grep through a lot of pre-alpha unreleased documentation so I'll try to explain my reasoning: