This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Don't force ASAN_HAS_EXCEPTIONS to be true for all builds
ClosedPublic

Authored by fjricci on Sep 15 2016, 3:02 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci updated this revision to Diff 71563.Sep 15 2016, 3:02 PM
fjricci retitled this revision from to [compiler-rt] Don't force ASAN_HAS_EXCEPTIONS to be true for all builds.
fjricci updated this object.
fjricci added reviewers: kcc, samsonov, compnerd.
fjricci added a subscriber: llvm-commits.
compnerd edited edge metadata.Sep 15 2016, 3:03 PM

I assume that this has no real effect because ASAN_HAS_EXCEPTIONS defaults to 1 if undefined?

As far as I can tell, that's correct. From asan_internal.h:

// If set, asan will intercept C++ exception api call(s).
#ifndef ASAN_HAS_EXCEPTIONS
# define ASAN_HAS_EXCEPTIONS 1
#endif
compnerd accepted this revision.Sep 15 2016, 3:27 PM
compnerd edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2016, 3:27 PM
This revision was automatically updated to reflect the committed changes.