This is an archive of the discontinued LLVM Phabricator instance.

Differential D24497

[WebAssembly] Trying to fix broken tests caused by r281285.
ClosedPublic

Authored by ioeric on Sep 13 2016, 2:18 AM.

Details

Reviewers
dschuff
djasper
sunfish
bkramer
ddcc
Commits
rG882dc72b3827: [WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by…
rL281312: [WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by…
Summary

Fixes are similar to those from r281284 (http://reviews.llvm.org/D20415).

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric updated this revision to Diff 71122.Sep 13 2016, 2:18 AM
ioeric retitled this revision from to [WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by r281285..
ioeric updated this object.
ioeric added reviewers: bkramer, ddcc, dschuff, sunfish.
ioeric added a subscriber: llvm-commits.
Herald added subscribers: dschuff, jfb. · View Herald TranscriptSep 13 2016, 2:18 AM
ioeric retitled this revision from [WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by r281285. to [WebAssembly] Trying to fix broken tests caused by r281285..Sep 13 2016, 2:24 AM
ioeric added a reviewer: djasper.Sep 13 2016, 2:59 AM
djasper accepted this revision.Sep 13 2016, 3:12 AM
djasper edited edge metadata.

This makes sense to me. At any rate, it is only fixing broken tests so it can't make the actual behavior worse. Submit this to get the bots back to green. If necessary, the owners can do further changes later.

This revision is now accepted and ready to land.Sep 13 2016, 3:12 AM
ioeric updated this object.Sep 13 2016, 3:13 AM
ioeric edited edge metadata.
Closed by commit rL281312: [WebAssembly] Trying to fix broken tests in CodeGen/WebAssembly caused by… (authored by ioeric). · Explain WhySep 13 2016, 3:14 AM
This revision was automatically updated to reflect the committed changes.
dschuff edited edge metadata.Sep 13 2016, 7:47 AM

Thanks!

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
WebAssembly/
2 lines
DebugInfo/
WebAssembly/
2 lines

Diff 71132

llvm/trunk/test/CodeGen/WebAssembly/dbgvalue.ll

Show All 39 Lines
!llvm.dbg.cu = !{!0} !llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!11, !12} !llvm.module.flags = !{!11, !12}
!llvm.ident = !{!13} !llvm.ident = !{!13}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.9.0 (trunk 273884) (llvm/trunk 273897)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3) !0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.9.0 (trunk 273884) (llvm/trunk 273897)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3)
!1 = !DIFile(filename: "crash.c", directory: "wasm/tests") !1 = !DIFile(filename: "crash.c", directory: "wasm/tests")
!2 = !{} !2 = !{}
!3 = !{!4} !3 = !{!4}
!4 = distinct !DIGlobalVariable(name: "key", scope: !0, file: !1, line: 7, type: !5, isLocal: false, isDefinition: true, variable: [15 x i8]* @key) !4 = distinct !DIGlobalVariable(name: "key", scope: !0, file: !1, line: 7, type: !5, isLocal: false, isDefinition: true)
!5 = !DICompositeType(tag: DW_TAG_array_type, baseType: !6, size: 120, align: 8, elements: !9) !5 = !DICompositeType(tag: DW_TAG_array_type, baseType: !6, size: 120, align: 8, elements: !9)
!6 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint8_t", file: !7, line: 185, baseType: !8) !6 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint8_t", file: !7, line: 185, baseType: !8)
!7 = !DIFile(filename: "wasm/emscripten/system/include/libc/bits/alltypes.h", directory: "wasm/tests") !7 = !DIFile(filename: "wasm/emscripten/system/include/libc/bits/alltypes.h", directory: "wasm/tests")
!8 = !DIBasicType(name: "unsigned char", size: 8, align: 8, encoding: DW_ATE_unsigned_char) !8 = !DIBasicType(name: "unsigned char", size: 8, align: 8, encoding: DW_ATE_unsigned_char)
!9 = !{!10} !9 = !{!10}
!10 = !DISubrange(count: 15) !10 = !DISubrange(count: 15)
!11 = !{i32 2, !"Dwarf Version", i32 4} !11 = !{i32 2, !"Dwarf Version", i32 4}
!12 = !{i32 2, !"Debug Info Version", i32 3} !12 = !{i32 2, !"Debug Info Version", i32 3}
Show All 14 Lines

llvm/trunk/test/DebugInfo/WebAssembly/dbg-declare.ll

Show All 39 Lines
!llvm.dbg.cu = !{!0} !llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!11, !12} !llvm.module.flags = !{!11, !12}
!llvm.ident = !{!13} !llvm.ident = !{!13}
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.9.0 (trunk 273884) (llvm/trunk 273897)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3) !0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang version 3.9.0 (trunk 273884) (llvm/trunk 273897)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3)
!1 = !DIFile(filename: "crash.c", directory: "wasm/tests") !1 = !DIFile(filename: "crash.c", directory: "wasm/tests")
!2 = !{} !2 = !{}
!3 = !{!4} !3 = !{!4}
!4 = distinct !DIGlobalVariable(name: "key", scope: !0, file: !1, line: 7, type: !5, isLocal: false, isDefinition: true, variable: [15 x i8]* @key) !4 = distinct !DIGlobalVariable(name: "key", scope: !0, file: !1, line: 7, type: !5, isLocal: false, isDefinition: true)
!5 = !DICompositeType(tag: DW_TAG_array_type, baseType: !6, size: 120, align: 8, elements: !9) !5 = !DICompositeType(tag: DW_TAG_array_type, baseType: !6, size: 120, align: 8, elements: !9)
!6 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint8_t", file: !7, line: 185, baseType: !8) !6 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint8_t", file: !7, line: 185, baseType: !8)
!7 = !DIFile(filename: "wasm/emscripten/system/include/libc/bits/alltypes.h", directory: "wasm/tests") !7 = !DIFile(filename: "wasm/emscripten/system/include/libc/bits/alltypes.h", directory: "wasm/tests")
!8 = !DIBasicType(name: "unsigned char", size: 8, align: 8, encoding: DW_ATE_unsigned_char) !8 = !DIBasicType(name: "unsigned char", size: 8, align: 8, encoding: DW_ATE_unsigned_char)
!9 = !{!10} !9 = !{!10}
!10 = !DISubrange(count: 15) !10 = !DISubrange(count: 15)
!11 = !{i32 2, !"Dwarf Version", i32 4} !11 = !{i32 2, !"Dwarf Version", i32 4}
!12 = !{i32 2, !"Debug Info Version", i32 3} !12 = !{i32 2, !"Debug Info Version", i32 3}
Show All 19 Lines