This is an archive of the discontinued LLVM Phabricator instance.

[asan] Fix handle_abort_on_error.cc test on Darwin, add back SIGABRT
ClosedPublic

Authored by kubamracek on Sep 8 2016, 6:42 AM.

Details

Summary
  1. r280885 added a testcase for handle_abort, which is broken on macOS, let’s add this support into sanitizer_mac.cc.
  1. https://reviews.llvm.org/D23873 accidentally removed “SIGABRT” from DescribeSignalOrException, let’s put it back.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 70693.Sep 8 2016, 6:42 AM
kubamracek retitled this revision from to [asan] Fix handle_abort_on_error.cc test on Darwin, add back SIGABRT.
kubamracek updated this object.
kubamracek added a project: Restricted Project.
kubamracek added a subscriber: zaks.anna.
filcab edited edge metadata.Sep 8 2016, 6:46 AM

LGTM.
Thank you.

P.S: Earlier it looked like it was a commit, not a patch.

lib/asan/asan_posix.cc
43 ↗(On Diff #70693)

This has since been added back. Sorry.

This revision was automatically updated to reflect the committed changes.