Keep reifying other errors.
As for the NOLINT on the constructor: We have two Error* constructors doing that.
Do you want me to change them to parenthesized initialization too, so we don't need the NOLINT?
|23 ↗||(On Diff #69809)|
I had taken it out because it's a simple function which would now be needed on two .cc files (for a while), and we don't really want to export the symbol.
|324 ↗||(On Diff #69809)|
I can use parenthesis, but we might want to start thinking about updating the cpplint.py script. I guess there are newer versions that might be able to deal with this.
|23 ↗||(On Diff #70336)|
I see no problem with symbol
|136 ↗||(On Diff #70336)|
Let's keep NOLINT here for consistency,
|324–325 ↗||(On Diff #70336)|
I see, it's about ";" after "}"