This is the work to refactor the TD for MIMG instructions. So far, I just did "refactoring". I am not sure whether any improvement
is needed at this moment. So any suggestion is welcome.
Details
- Reviewers
• tstellarAMD kzhuravl vpykhtin arsenm - Group Reviewers
Restricted Project - Commits
- rGb28fe0307f2c: AMDGPU/SI: MIMG TD Refactoring.
rL280385: AMDGPU/SI: MIMG TD Refactoring.
Diff Detail
Event Timeline
LGTM overall
Can you upload full diff? Can marked new lines be removed to be consistent with the rest of the code (I think I have caught them all :) )?
lib/Target/AMDGPU/MIMGInstructions.td | ||
---|---|---|
245 | extra new line | |
367 | extra new line | |
391 | extra new line | |
556 | extra new line | |
lib/Target/AMDGPU/SIInstrInfo.td | ||
3192 | extra new line | |
3200 | extra new line | |
lib/Target/AMDGPU/SIInstructions.td | ||
25–27 | extra new lines | |
30 | extra new line | |
954–957 | extra new lines | |
2347 | extra new line | |
2348 | extra new line | |
2349 | extra new line |
I am not sure whether any improvement is needed at this moment. So any suggestion is welcome.
FYI there are some low-priority Bugzillas related to MIMG:
https://llvm.org/bugs/show_bug.cgi?id=28239
https://llvm.org/bugs/show_bug.cgi?id=28240
https://llvm.org/bugs/show_bug.cgi?id=28243
https://llvm.org/bugs/show_bug.cgi?id=28244
extra new line