This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: MIMG TD Refactoring.
ClosedPublic

Authored by cfang on Aug 31 2016, 3:46 PM.

Details

Summary

This is the work to refactor the TD for MIMG instructions. So far, I just did "refactoring". I am not sure whether any improvement
is needed at this moment. So any suggestion is welcome.

Diff Detail

Event Timeline

cfang updated this revision to Diff 69914.Aug 31 2016, 3:46 PM
cfang retitled this revision from to AMDGPU/SI: MIMG TD Refactoring..
cfang updated this object.
cfang added reviewers: arsenm, tstellarAMD, Restricted Project.
cfang added subscribers: arsenm, llvm-commits.
vpykhtin accepted this revision.Sep 1 2016, 1:51 AM
vpykhtin added a reviewer: vpykhtin.
vpykhtin added a subscriber: vpykhtin.

LGTM.

This revision is now accepted and ready to land.Sep 1 2016, 1:51 AM

LGTM overall

Can you upload full diff? Can marked new lines be removed to be consistent with the rest of the code (I think I have caught them all :) )?

lib/Target/AMDGPU/MIMGInstructions.td
245

extra new line

367

extra new line

391

extra new line

556

extra new line

lib/Target/AMDGPU/SIInstrInfo.td
3192

extra new line

3200

extra new line

lib/Target/AMDGPU/SIInstructions.td
25–27

extra new lines

30

extra new line

954–957

extra new lines

2347

extra new line

2348

extra new line

2349

extra new line

I am not sure whether any improvement is needed at this moment. So any suggestion is welcome.

FYI there are some low-priority Bugzillas related to MIMG:
https://llvm.org/bugs/show_bug.cgi?id=28239
https://llvm.org/bugs/show_bug.cgi?id=28240
https://llvm.org/bugs/show_bug.cgi?id=28243
https://llvm.org/bugs/show_bug.cgi?id=28244

cfang updated this revision to Diff 70023.Sep 1 2016, 9:54 AM
cfang edited edge metadata.

Update based on Konstantin's comments:

  1. upload a full diff
  2. remove extra lines
kzhuravl accepted this revision.Sep 1 2016, 10:09 AM
kzhuravl added a reviewer: kzhuravl.

LGTM

This revision was automatically updated to reflect the committed changes.