This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Perform configuration checks with -nodefaultlibs
ClosedPublic

Authored by smeenai on Aug 22 2016, 8:20 PM.

Details

Summary

We're compiling libc++ with -nodefaultlibs, so we should also pass this
option during the configuration checks to ensure those checks are
consistent with the actual build.

The primary motivation here is to ease cross-compilation against a
non-standard set of C++ libraries. Previously, the configuration checks
would attempt to link against the standard C++ libraries, which would
cause link failures when cross-compiling, even though the actual library
link would go through correctly (because of the use of -nodefaultlibs
and explicitly specifying any needed libraries). This is more correct
even ignoring the motivation, however.

Diff Detail

Event Timeline

smeenai updated this revision to Diff 68950.Aug 22 2016, 8:20 PM
smeenai retitled this revision from to [libc++] Perform configuration checks with -nodefaultlibs.
smeenai updated this object.
smeenai added a subscriber: cfe-commits.
EricWF accepted this revision.Aug 23 2016, 2:46 PM
EricWF edited edge metadata.

I think this makes sense.

This revision is now accepted and ready to land.Aug 23 2016, 2:46 PM
compnerd closed this revision.Aug 23 2016, 4:09 PM
compnerd edited edge metadata.

SVN r279584.