This patch aims to add very basic Emacs integration. My experience with Emacs is limited to few days, so I'm not sure whether I've done things correctly.
Details
Diff Detail
Event Timeline
clang-rename/tool/clang-rename.el | ||
---|---|---|
8 | Aw, yeah. This block was just copied :D |
Manuel, any other comments? Jens seems to be missing and I don't know about anyone else who is familiar with Emacs :(
clang-rename/tool/clang-rename.el | ||
---|---|---|
17 | I think we should make clang-rename binary path configurable by making it a custom variable (using defcustom). | |
21 | s is an extra character here? | |
28 | Any reason why not use call-process-region? | |
docs/clang-rename.rst | ||
105 | missing two "=". | |
113 | print doesn't make sense here? I think user should type clang-rename and new name. |
clang-rename/tool/clang-rename.el | ||
---|---|---|
29 | call-process-region is used while contents of current buffer are to be replaced, but in case of clang-rename changes might affect all buffers, which doesn't make sense to take care of one buffer only. |
Please add install rule for clang-rename.el. See clang-format CMakeLists.txt as example.
Thanks! Fixed.
Waiting few more hours just in case anyone will jump in and write few comments.
Also include the vim integration clang-rename.py?