Page MenuHomePhabricator

massberg (Jens Massberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 26 2016, 5:50 AM (340 w, 6 d)

Recent Activity

Fri, Jan 20

massberg added inline comments to D139400: [clang] Show error when a local variables is passed as default template parameter.
Fri, Jan 20, 12:06 AM · Restricted Project, Restricted Project

Fri, Jan 13

massberg committed rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg).
Move definitions to prevent incomplete types.
Fri, Jan 13, 7:45 AM · Restricted Project, Restricted Project
massberg committed rG0995b545ecc8: Add default constructurs to `filter_iterator_impl` and `filter_iterator_impl`. (authored by massberg).
Add default constructurs to `filter_iterator_impl` and `filter_iterator_impl`.
Fri, Jan 13, 7:45 AM · Restricted Project, Restricted Project
massberg closed D141671: Move definitions to prevent incomplete types..
Fri, Jan 13, 7:45 AM · Restricted Project, Restricted Project
massberg closed D141587: Add default constructurs to `filter_iterator_impl` and `filter_iterator_impl`..
Fri, Jan 13, 7:45 AM · Restricted Project, Restricted Project
massberg added a comment to D141671: Move definitions to prevent incomplete types..

I have updated the code. It turned out that much less code has to be moved than I initially thought. :)

Fri, Jan 13, 6:01 AM · Restricted Project, Restricted Project
massberg retitled D141671: Move definitions to prevent incomplete types. from Move around structs and definitions to prevent incomplete types. to Move definitions to prevent incomplete types..
Fri, Jan 13, 6:00 AM · Restricted Project, Restricted Project
massberg updated the diff for D141671: Move definitions to prevent incomplete types..

Clean up code and only mode definitions.

Fri, Jan 13, 6:00 AM · Restricted Project, Restricted Project
massberg added a comment to D141671: Move definitions to prevent incomplete types..

Having as few code in headers as possible is the general style guide in LLVM, so I'd rather err towards that and put definitions out-of-line as much as possible. Therefore if we can getaway by just moving definitions out-of-line, while keeping rest of the header ordering the same, let's go with that if it's feasible

Fri, Jan 13, 5:16 AM · Restricted Project, Restricted Project
massberg requested review of D141671: Move definitions to prevent incomplete types..
Fri, Jan 13, 2:50 AM · Restricted Project, Restricted Project

Thu, Jan 12

massberg requested review of D141587: Add default constructurs to `filter_iterator_impl` and `filter_iterator_impl`..
Thu, Jan 12, 2:45 AM · Restricted Project, Restricted Project
massberg committed rGd1e0fd2b1326: Avoid u8"" literals in tests, their type changes in C++20 (authored by massberg).
Avoid u8"" literals in tests, their type changes in C++20
Thu, Jan 12, 1:22 AM · Restricted Project, Restricted Project
massberg closed D141392: Avoid u8"" literals in tests, their type changes in C++20.
Thu, Jan 12, 1:22 AM · Restricted Project, Restricted Project
massberg added a comment to D141392: Avoid u8"" literals in tests, their type changes in C++20.

Thanks for the comments!

Thu, Jan 12, 1:10 AM · Restricted Project, Restricted Project
massberg updated the diff for D141392: Avoid u8"" literals in tests, their type changes in C++20.

Fixed nits. Thanks for the comments!

Thu, Jan 12, 1:09 AM · Restricted Project, Restricted Project

Wed, Jan 11

massberg updated the diff for D141392: Avoid u8"" literals in tests, their type changes in C++20.

Delete insertion operator of raw_ostream for char8_t.

Wed, Jan 11, 7:10 AM · Restricted Project, Restricted Project
massberg added a comment to D141392: Avoid u8"" literals in tests, their type changes in C++20.

An alternative is to cast the char8_t* to char_t* in the << operator of the ostream of to get back the old behavior, e.g. something like

raw_ostream &operator<<(const char8_t *Str) {
    return this->operator<<(reinterpret_cast<const char *>(Str));
}
Wed, Jan 11, 5:33 AM · Restricted Project, Restricted Project
massberg added a comment to D141392: Avoid u8"" literals in tests, their type changes in C++20.

Are there any uses of u8 string literals with formatted_raw_ostream outside tests? What was the effect on the final behavior here?

I just wanted to make sure we are not doing the wrong thing here. If the code used to compile and it now changes behavior, we may run into runtime failures in real code.
If that's the case, we could potentially consider adding overloads for u8 string literals to either support it or with =delete to make sure the code using them will be rewritten.

Wed, Jan 11, 4:56 AM · Restricted Project, Restricted Project

Tue, Jan 10

massberg requested review of D141392: Avoid u8"" literals in tests, their type changes in C++20.
Tue, Jan 10, 8:14 AM · Restricted Project, Restricted Project
massberg committed rGf082e54cefbf: Avoid u8"" literals in tests, their type changes in C++20 (authored by massberg).
Avoid u8"" literals in tests, their type changes in C++20
Tue, Jan 10, 6:15 AM · Restricted Project, Restricted Project
massberg closed D141368: Avoid u8"" literals in tests, their type changes in C++20.
Tue, Jan 10, 6:15 AM · Restricted Project, Restricted Project
massberg requested review of D141368: Avoid u8"" literals in tests, their type changes in C++20.
Tue, Jan 10, 3:40 AM · Restricted Project, Restricted Project
massberg committed rG2a43b5038d9b: Remove unnecessary template specifiers from truct constructors in tests. (authored by massberg).
Remove unnecessary template specifiers from truct constructors in tests.
Tue, Jan 10, 3:35 AM · Restricted Project, Restricted Project
massberg closed D141358: Remove unnecessary template specifiers from truct constructors in tests..
Tue, Jan 10, 3:35 AM · Restricted Project, Restricted Project
massberg accepted D141312: [Support] avoid u8"" literals in tests, their type changes in C++20.

Thanks!

Tue, Jan 10, 12:53 AM · Restricted Project, Restricted Project
massberg requested review of D141358: Remove unnecessary template specifiers from truct constructors in tests..
Tue, Jan 10, 12:27 AM · Restricted Project, Restricted Project

Dec 12 2022

massberg added inline comments to D139400: [clang] Show error when a local variables is passed as default template parameter.
Dec 12 2022, 8:34 AM · Restricted Project, Restricted Project
massberg updated the diff for D139400: [clang] Show error when a local variables is passed as default template parameter.

Additionally check for ODR use and remove inlcude added by accident.

Dec 12 2022, 8:25 AM · Restricted Project, Restricted Project

Dec 8 2022

massberg added a comment to D139400: [clang] Show error when a local variables is passed as default template parameter.

It looks like we have an existing message for the regular function case

Dec 8 2022, 8:46 AM · Restricted Project, Restricted Project
massberg updated the diff for D139400: [clang] Show error when a local variables is passed as default template parameter.

Reuse existing error message.

Dec 8 2022, 8:43 AM · Restricted Project, Restricted Project
massberg updated the diff for D139400: [clang] Show error when a local variables is passed as default template parameter.

Use isLocalVarDecl to check if we have a local variable.

Dec 8 2022, 6:30 AM · Restricted Project, Restricted Project

Dec 7 2022

massberg requested review of D139541: Fix parameter name in Sema::addInitCapture to ByRef..
Dec 7 2022, 7:22 AM · Restricted Project, Restricted Project
massberg committed rGedbea62f72f7: [clang] Correctly handle by-reference capture with an initializer that is a… (authored by massberg).
[clang] Correctly handle by-reference capture with an initializer that is a…
Dec 7 2022, 7:01 AM · Restricted Project, Restricted Project
massberg closed D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..
Dec 7 2022, 7:01 AM · Restricted Project, Restricted Project
massberg added a comment to D139400: [clang] Show error when a local variables is passed as default template parameter.

It looks like the existing diagnostic is issued by CheckDefaultArgumentVisitor. I think you can reuse it here but not 100% on that.

Thanks for the pointer! I will have a look.

Dec 7 2022, 1:27 AM · Restricted Project, Restricted Project
massberg added inline comments to D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..
Dec 7 2022, 12:55 AM · Restricted Project, Restricted Project
massberg updated the summary of D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..
Dec 7 2022, 12:54 AM · Restricted Project, Restricted Project
massberg updated the diff for D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..

Simplify code and update description.

Dec 7 2022, 12:52 AM · Restricted Project, Restricted Project

Dec 6 2022

massberg updated the diff for D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..

Instead of lokking if there is a pack expansion pass the already computed information whether we have a by ref or a by copy type.

Dec 6 2022, 9:16 AM · Restricted Project, Restricted Project
massberg updated the diff for D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..

Moved check if we have a pack expansion with reference type to Sema::BuildLambdaExpr.

Dec 6 2022, 6:59 AM · Restricted Project, Restricted Project
massberg added inline comments to D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..
Dec 6 2022, 3:24 AM · Restricted Project, Restricted Project
massberg updated the diff for D139400: [clang] Show error when a local variables is passed as default template parameter.

Fix test.

Dec 6 2022, 12:59 AM · Restricted Project, Restricted Project
massberg requested review of D139400: [clang] Show error when a local variables is passed as default template parameter.
Dec 6 2022, 12:55 AM · Restricted Project, Restricted Project

Dec 5 2022

massberg added inline comments to D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..
Dec 5 2022, 6:45 AM · Restricted Project, Restricted Project

Dec 2 2022

massberg updated the diff for D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..

Remove unnecessary code from test.

Dec 2 2022, 3:24 AM · Restricted Project, Restricted Project
massberg updated the diff for D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..

Add a diagnostics test for pack expansions to check if args are passed by reference and not by value.

Dec 2 2022, 3:10 AM · Restricted Project, Restricted Project

Dec 1 2022

massberg requested review of D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas..
Dec 1 2022, 9:06 AM · Restricted Project, Restricted Project

Nov 29 2022

massberg committed rG849b650cf3b6: [clang] Skip defaulted functions in zero-as-null-pointer-constant. (authored by massberg).
[clang] Skip defaulted functions in zero-as-null-pointer-constant.
Nov 29 2022, 2:57 AM · Restricted Project, Restricted Project
massberg closed D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..
Nov 29 2022, 2:56 AM · Restricted Project, Restricted Project
massberg added a comment to D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..

Note: The build failures are in parts of the code that isn't effected by this change.

Nov 29 2022, 2:33 AM · Restricted Project, Restricted Project
massberg added a comment to D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..

Thanks for the comments!

Nov 29 2022, 1:12 AM · Restricted Project, Restricted Project
massberg updated the diff for D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..

Fixed comments and removed unnecessary includes.

Nov 29 2022, 12:26 AM · Restricted Project, Restricted Project

Nov 28 2022

massberg updated the diff for D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..

Run clang-format on changed files.

Nov 28 2022, 8:53 AM · Restricted Project, Restricted Project
massberg updated the diff for D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..

Sync to head.

Nov 28 2022, 6:50 AM · Restricted Project, Restricted Project

Nov 25 2022

massberg requested review of D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant..
Nov 25 2022, 9:12 AM · Restricted Project, Restricted Project
massberg added a comment to D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr..

Thanks for the comments!

Nov 25 2022, 6:20 AM · Restricted Project, Restricted Project
massberg updated the diff for D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr..

Add comments.

Nov 25 2022, 6:19 AM · Restricted Project, Restricted Project
massberg requested review of D138701: [clang-tidy] Ignore cxxRewrittenBinaryOperator in defaulted function decls in modernize-use-nullptr..
Nov 25 2022, 2:25 AM · Restricted Project, Restricted Project

Apr 12 2021

massberg added inline comments to D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..
Apr 12 2021, 8:48 AM · Restricted Project, Restricted Project
massberg updated the diff for D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..

Add note that the new IgnoreMarcos options isn't guaranteed to be forward compatible.

Apr 12 2021, 8:45 AM · Restricted Project, Restricted Project
massberg updated the diff for D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..

Add test with global IgnoreMacros=true and readability-function-cognitive-complexity.IgnoreMacros unset.

Apr 12 2021, 7:56 AM · Restricted Project, Restricted Project

Mar 10 2021

massberg updated the diff for D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..

Sync to head.

Mar 10 2021, 12:25 AM · Restricted Project, Restricted Project

Mar 5 2021

massberg updated the summary of D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..
Mar 5 2021, 12:53 PM · Restricted Project, Restricted Project
massberg requested review of D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check..
Mar 5 2021, 12:45 PM · Restricted Project, Restricted Project

Mar 3 2021

massberg added inline comments to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..
Mar 3 2021, 8:10 AM · Restricted Project, Restricted Project
massberg updated the diff for D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Remove unnecessary checks.

Mar 3 2021, 8:08 AM · Restricted Project, Restricted Project
massberg updated the diff for D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Add checks to ensure that notes aren't added for specific options.

Mar 3 2021, 4:52 AM · Restricted Project, Restricted Project
massberg added a comment to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Once again, can we please split this into two patches?
I'm quite happy with the DescribeBasicIncrements stuff, that can be merged right now.

Mar 3 2021, 2:05 AM · Restricted Project, Restricted Project
massberg retitled D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check. from [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check. to [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..
Mar 3 2021, 2:02 AM · Restricted Project, Restricted Project
massberg updated the diff for D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Remove IgnoreMacros option (to be added in a follow up patch) and sync to head.

Mar 3 2021, 1:59 AM · Restricted Project, Restricted Project

Feb 16 2021

massberg added a comment to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Thanks for the comments!

Feb 16 2021, 5:37 AM · Restricted Project, Restricted Project
massberg updated the diff for D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Change option name, improve description and minor fixes.

Feb 16 2021, 5:33 AM · Restricted Project, Restricted Project

Feb 11 2021

massberg added a comment to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

How does this handle a macro where the argument has complex code.

MACRO(if (...) {});
Feb 11 2021, 9:47 AM · Restricted Project, Restricted Project
massberg updated the diff for D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Add test cases showing that when IgnoreMacros is set to 'true', also macro arguments are ignored.

Feb 11 2021, 9:27 AM · Restricted Project, Restricted Project
massberg added a comment to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Thanks for the comments!

Feb 11 2021, 1:46 AM · Restricted Project, Restricted Project
massberg updated the diff for D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..

Clarified option FlagBasicIncrements and removed base default constructor from class initializer list of FunctionASTVisitor.

Feb 11 2021, 1:36 AM · Restricted Project, Restricted Project

Feb 9 2021

massberg added a project to D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.: Restricted Project.
Feb 9 2021, 5:04 AM · Restricted Project, Restricted Project
massberg retitled D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check. from Add options to flag individual core increments and to ignore macros to cognitive complexity check. to [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check..
Feb 9 2021, 5:03 AM · Restricted Project, Restricted Project

Feb 8 2021

massberg requested review of D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check..
Feb 8 2021, 9:59 AM · Restricted Project, Restricted Project

Feb 16 2018

massberg added a comment to D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Thanks for the comments!

Feb 16 2018, 2:28 AM · Restricted Project
massberg updated the diff for D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.
Feb 16 2018, 2:13 AM · Restricted Project

Feb 6 2018

massberg added a comment to D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Thanks for the comments!
I double-checked that the renaming went well and hope that I haven't missed anything this time ...

Feb 6 2018, 9:24 AM · Restricted Project
massberg updated the diff for D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Addressed comments and renamed test to modernize-deprecated-functional

Feb 6 2018, 9:18 AM · Restricted Project

Feb 2 2018

massberg updated the diff for D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.
Feb 2 2018, 7:53 AM · Restricted Project

Feb 1 2018

massberg added inline comments to D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.
Feb 1 2018, 11:12 PM · Restricted Project
massberg updated the diff for D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Addressed comments of reviewers.

Feb 1 2018, 11:09 PM · Restricted Project

Jan 31 2018

massberg added inline comments to D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.
Jan 31 2018, 7:07 AM · Restricted Project
massberg added a comment to D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Alex and Aaron, thanks for the comments!

Jan 31 2018, 6:58 AM · Restricted Project
massberg updated the diff for D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Addressed comments of reviewer.

Jan 31 2018, 6:47 AM · Restricted Project
massberg updated the diff for D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.

Implemented all suggestions from the reviewer.

Jan 31 2018, 4:24 AM · Restricted Project
massberg created D42730: [clang-tidy]] Add check for use of types/classes/functions from <functional> header which are deprecated and removed in C++17.
Jan 31 2018, 3:14 AM · Restricted Project

Jan 17 2017

massberg accepted D28800: Make sure that clang-format input is in the right encoding.

looks good to me

Jan 17 2017, 9:36 AM

Oct 25 2016

massberg accepted D25657: include-fixer: Don't overwrite buffer changes.

looks good to me

Oct 25 2016, 3:11 AM
massberg accepted D25658: Load clang-include-fixer.el from the unit test suite so that the unit tests can run in batch mode.

looks good to me

Oct 25 2016, 2:53 AM

Oct 4 2016

massberg added a comment to D25164: Overhaul clang-include-fixer.el.

Very nice!

Oct 4 2016, 7:32 AM · Restricted Project

Sep 7 2016

massberg added a comment to D24075: [include-fixer] Support finding headers for the symbol under cursor..

The Emacs part looks good for me now.

Sep 7 2016, 9:19 AM
massberg added a comment to D24075: [include-fixer] Support finding headers for the symbol under cursor..

Added two comments. It took some time for me to recall Emacs Lisps ;)

Sep 7 2016, 8:50 AM

Jul 27 2016

massberg added a comment to D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer..

Thanks for the comments!

Jul 27 2016, 1:33 AM
massberg updated the diff for D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer..

Updating D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer.

Jul 27 2016, 1:30 AM

Jul 26 2016

massberg added a comment to D22805: [clang-include-fixer] Added Emacs integration for clang-include-fixer..

Thanks for the comments!

Jul 26 2016, 11:18 AM