This patch aims to add very basic Emacs integration. My experience with Emacs is limited to few days, so I'm not sure whether I've done things correctly.
|16 ↗||(On Diff #66296)|
I think we should make clang-rename binary path configurable by making it a custom variable (using defcustom).
|20 ↗||(On Diff #66296)|
s is an extra character here?
|27 ↗||(On Diff #66296)|
Any reason why not use call-process-region?
|106 ↗||(On Diff #66296)|
missing two "=".
|114 ↗||(On Diff #66296)|
print doesn't make sense here? I think user should type clang-rename and new name.
|28 ↗||(On Diff #66328)|
call-process-region is used while contents of current buffer are to be replaced, but in case of clang-rename changes might affect all buffers, which doesn't make sense to take care of one buffer only.