This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Disable some unittests on windows that rely on shell command
ClosedPublic

Authored by etienneb on Jul 20 2016, 10:35 PM.

Details

Summary

These unittests are not running on windows because they are using incorrect commands.
They were not failing on 32-bits because there is a requirement: asan-64-bits.

$ "nm" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\no_asan_gen_globals.c.tmp.exe"
# command stderr:
'nm': command not found
error: command failed with exit status: 127
$ "rm" "-rf" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "mkdir" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing"
$ "A=x"
# command stderr:
'A=x': command not found
error: command failed with exit status: 127
$ "DIR=C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-order-pcs"
# command stderr:
'DIR=C:\\src\\llvm\\ninja64\\projects\\compiler-rt\\test\\asan\\X86_64WindowsConfig\\TestCases\\Output/coverage-order-pcs': command not found
error: command failed with exit status: 127

Diff Detail

Event Timeline

etienneb updated this revision to Diff 64822.Jul 20 2016, 10:35 PM
etienneb retitled this revision from to [compiler-rt] Disable some unittests on windows that rely on shell command.
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb updated this revision to Diff 64823.Jul 20 2016, 10:36 PM

remove interceptor file

rnk added inline comments.Jul 21 2016, 7:14 AM
test/asan/TestCases/coverage-order-pcs.cc
22

Instead, this should be REQUIRES: shell. The test is failing because it uses environment variable expansion, which the lit internal shell doesn't support.

test/asan/TestCases/coverage-tracing.cc
27

Ditto, this is REQUIRES: shell

test/asan/TestCases/no_asan_gen_globals.c
9

IMO if it uses nm we should just send it to test/asan/TestCases/Posix

etienneb updated this revision to Diff 64892.Jul 21 2016, 7:55 AM
etienneb marked 2 inline comments as done.

rnk comments

etienneb updated this revision to Diff 64893.Jul 21 2016, 7:59 AM

disable an other test

rnk accepted this revision.Jul 21 2016, 8:00 AM
rnk edited edge metadata.

lgtm

test/asan/TestCases/intra-object-overflow.cc
7 ↗(On Diff #64893)

Comment something like "// FIXME: Implement ASan intra-object padding in Clang's MS record layout"

This revision is now accepted and ready to land.Jul 21 2016, 8:00 AM
etienneb updated this revision to Diff 64896.Jul 21 2016, 8:01 AM
etienneb edited edge metadata.

add comment

etienneb closed this revision.Jul 21 2016, 8:02 AM