Page MenuHomePhabricator

chrisha (Chris Hamilton)
UserEmail Not Verified


User does not belong to any projects.

User Details

User Since
May 30 2016, 11:56 AM (264 w, 1 d)

Recent Activity

Aug 10 2016

chrisha added a comment to D23354: [asan] Support dynamic shadow address instrumentation.
In D23354#511712, @kcc wrote:

All I've heard so far are very sad things, but they don't convince me.
I believe we have Microsoft folks in the community now. Please summon some of them to this discussion.

We must find a way to use static shadow.
My estimate is that dynamic shadow will cost us 10% in CPU and 5% in code size at the very least.
These are just guesses, so benchmark results are more than welcome.

Comparing this change to whatever we do in the prologue is not correct since for dynamic shadow we
a) steal a register for the entire function
b) complicate the address arithmetic for every memory access.

BTW, why do we have to support all older windows versions?
For me it would be fine to only support whatever the current version is and the future ones.
At least as the first step.

Aug 10 2016, 1:36 PM

Jul 6 2016

chrisha added inline comments to D21942: [asan] Add exception handler to map memory on demand on Win64..
Jul 6 2016, 2:13 PM

Jun 30 2016

chrisha added a comment to D21900: [compiler-rt] Fix sanitizer memory allocator on win64..
In D21900#471571, @rnk wrote:

chrisha@ prosposed that we implement an other flavor of MMap to remap memory previously created with NoAccess.

I like this better. I think if we try to hard to pretend we have mmap we will eventually go crazy.

Jun 30 2016, 12:19 PM