[LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions
ClosedPublic
Actions

Authored by nitesh.jain on Jun 7 2016, 3:53 AM.

Details

Reviewers

bhushan
clayborg
jaydeep

Summary

This patch contains 2 changes:

Corrected target address calculation of compact branch instructions to reflect changes in disassembler (http://reviews.llvm.org/D17540).
Added emulation for (missing) 'Addiu' instruction.

Diff Detail

Repository: rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 59856.Jun 7 2016, 3:53 AM

nitesh.jain retitled this revision from to [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions.

nitesh.jain updated this object.

nitesh.jain added reviewers: clayborg, bhushan, jaydeep.

nitesh.jain set the repository for this revision to rL LLVM.

nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits.

Herald added subscribers: sdardis, dsanders. · View Herald TranscriptJun 7 2016, 3:53 AM

Looks good to me.

This revision is now accepted and ready to land.Jun 8 2016, 9:15 PM

Looks good.

clayborg accepted this revision.Jun 20 2016, 5:19 PM

clayborg edited edge metadata.

Committed in rL273535

You also need to emulate dsubu and subu as the MIPS LLVM backend will generate them in certain cases.

In D21064#465410, @sdardis wrote:

You also need to emulate dsubu and subu as the MIPS LLVM backend will generate them in certain cases.

Thanks will emulate them too.

Revision Contents
Changeset List

Path

Size

source/

Plugins/

Instruction/

MIPS/

EmulateInstructionMIPS.cpp

32 lines

MIPS64/

EmulateInstructionMIPS64.cpp

33 lines

Diff 59856

View Options

source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp