Page MenuHomePhabricator
Differential D21064

[LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions
ClosedPublic
Actions

Authored by nitesh.jain on Jun 7 2016, 3:53 AM.

Details

Reviewers
bhushan
clayborg
jaydeep
Summary

This patch contains 2 changes:

  1. Corrected target address calculation of compact branch instructions to reflect changes in disassembler (http://reviews.llvm.org/D17540).
  2. Added emulation for (missing) 'Addiu' instruction.

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 59856.Jun 7 2016, 3:53 AM
nitesh.jain retitled this revision from to [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions.
nitesh.jain updated this object.
nitesh.jain added reviewers: clayborg, bhushan, jaydeep.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits.
jaydeep accepted this revision.Jun 8 2016, 9:15 PM
jaydeep edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jun 8 2016, 9:15 PM
bhushan accepted this revision.Jun 9 2016, 3:56 AM
bhushan edited edge metadata.

Looks good.

clayborg accepted this revision.Jun 20 2016, 5:19 PM
clayborg edited edge metadata.
slthakur closed this revision.Jun 22 2016, 11:57 PM

Committed in rL273535

sdardis added a comment.Jun 23 2016, 2:28 AM

You also need to emulate dsubu and subu as the MIPS LLVM backend will generate them in certain cases.

nitesh.jain added a comment.Jun 23 2016, 2:30 AM
In D21064#465410, @sdardis wrote:

You also need to emulate dsubu and subu as the MIPS LLVM backend will generate them in certain cases.

Thanks will emulate them too.

Revision Contents
Changeset List

Diff 59856

View Options

source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp

Loading...
View Options

source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp

Loading...