Page MenuHomePhabricator

mohit.bhakkad (Mohit Bhakkad)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2014, 10:12 PM (257 w, 5 d)

Recent Activity

Jul 18 2016

mohit.bhakkad committed rL275780: [Compiler-rt][MIPS] Fix simple test failure when using gcc.
[Compiler-rt][MIPS] Fix simple test failure when using gcc
Jul 18 2016, 2:30 AM
mohit.bhakkad closed D22453: [Compiler-rt][MIPS] Fix simple test failure when using gcc by committing rL275780: [Compiler-rt][MIPS] Fix simple test failure when using gcc.
Jul 18 2016, 2:30 AM

Jul 17 2016

mohit.bhakkad retitled D22453: [Compiler-rt][MIPS] Fix simple test failure when using gcc from to [Compiler-rt][MIPS] Fix simple test failure when using gcc.
Jul 17 2016, 11:11 PM
mohit.bhakkad abandoned D21924: [Compiler-rt][MIPS] Fix simple test failure when using gcc.
Jul 17 2016, 11:08 PM

Jul 15 2016

mohit.bhakkad added a comment to D21924: [Compiler-rt][MIPS] Fix simple test failure when using gcc.

Hi @dsanders, could you please review this?

Jul 15 2016, 12:06 AM

Jul 1 2016

mohit.bhakkad added a reviewer for D21924: [Compiler-rt][MIPS] Fix simple test failure when using gcc: dsanders.
Jul 1 2016, 3:48 AM
mohit.bhakkad retitled D21924: [Compiler-rt][MIPS] Fix simple test failure when using gcc from to [Compiler-rt][MIPS] Fix simple test failure when using gcc.
Jul 1 2016, 3:47 AM

Jun 1 2016

mohit.bhakkad committed rL271390: Merging r270564:.
Merging r270564:
Jun 1 2016, 6:25 AM
mohit.bhakkad committed rL271383: Merging r270208:.
Merging r270208:
Jun 1 2016, 4:53 AM
mohit.bhakkad committed rL271381: Merging r269407:.
Merging r269407:
Jun 1 2016, 4:48 AM
mohit.bhakkad committed rL271379: Merging r269181:.
Merging r269181:
Jun 1 2016, 3:46 AM
mohit.bhakkad committed rL271378: Merging r261206:.
Merging r261206:
Jun 1 2016, 3:43 AM
mohit.bhakkad committed rL271372: Merging r263621:.
Merging r263621:
Jun 1 2016, 1:23 AM

May 24 2016

mohit.bhakkad committed rL270676: Merging r270542:.
Merging r270542:
May 24 2016, 11:38 PM
mohit.bhakkad committed rL270675: Merging r265134:.
Merging r265134:
May 24 2016, 11:37 PM
mohit.bhakkad committed rL270673: Merging r265134:.
Merging r265134:
May 24 2016, 11:06 PM
mohit.bhakkad committed rL270668: Merging r267674:.
Merging r267674:
May 24 2016, 10:56 PM
mohit.bhakkad committed rL270546: Merging r264030:.
Merging r264030:
May 24 2016, 3:56 AM
mohit.bhakkad committed rL270545: Merging r262819:.
Merging r262819:
May 24 2016, 3:55 AM
mohit.bhakkad committed rL270544: Merging r260362:.
Merging r260362:
May 24 2016, 3:54 AM

May 23 2016

mohit.bhakkad committed rL270407: Merging r263218:.
Merging r263218:
May 23 2016, 1:36 AM
mohit.bhakkad committed rL270406: Merging r263001:.
Merging r263001:
May 23 2016, 1:31 AM
mohit.bhakkad committed rL270405: Merging r262303:.
Merging r262303:
May 23 2016, 1:27 AM
mohit.bhakkad committed rL270404: Merging r262690:.
Merging r262690:
May 23 2016, 1:27 AM
mohit.bhakkad committed rL270403: Merging r262209:.
Merging r262209:
May 23 2016, 1:26 AM
mohit.bhakkad committed rL270402: Merging r262302:.
Merging r262302:
May 23 2016, 1:25 AM
mohit.bhakkad committed rL270400: Merging r261982:.
Merging r261982:
May 23 2016, 12:11 AM
mohit.bhakkad committed rL270399: Merging r261837:.
Merging r261837:
May 23 2016, 12:10 AM
mohit.bhakkad committed rL270398: Merging r261723:.
Merging r261723:
May 23 2016, 12:08 AM
mohit.bhakkad committed rL270397: Merging r261721:.
Merging r261721:
May 23 2016, 12:07 AM
mohit.bhakkad committed rL270396: Merging r261513:.
Merging r261513:
May 23 2016, 12:02 AM

May 19 2016

mohit.bhakkad committed rL270035: Merging rL260946:.
Merging rL260946:
May 19 2016, 3:23 AM

Apr 26 2016

mohit.bhakkad committed rL267674: [Compiler-rt][CFI] Enabling CFI for MIPS64.
[Compiler-rt][CFI] Enabling CFI for MIPS64
Apr 26 2016, 10:55 PM
mohit.bhakkad closed D19531: [Compiler-rt][CFI] Enabling CFI for MIPS64 by committing rL267674: [Compiler-rt][CFI] Enabling CFI for MIPS64.
Apr 26 2016, 10:55 PM
mohit.bhakkad updated subscribers of D19531: [Compiler-rt][CFI] Enabling CFI for MIPS64.
Apr 26 2016, 10:50 PM
mohit.bhakkad added a comment to D19531: [Compiler-rt][CFI] Enabling CFI for MIPS64.

I am debugging the cause of failing test cases. Both these cases fail as we are
not getting string "vtable is of type '{{(struct )?}}B'"

Apr 26 2016, 3:48 AM
mohit.bhakkad retitled D19531: [Compiler-rt][CFI] Enabling CFI for MIPS64 from to [Compiler-rt][CFI] Enabling CFI for MIPS64.
Apr 26 2016, 3:45 AM

Apr 17 2016

mohit.bhakkad committed rL266589: [LLDB][MIPS] Fix TestConcurrentEvents.
[LLDB][MIPS] Fix TestConcurrentEvents
Apr 17 2016, 10:33 PM
mohit.bhakkad closed D18389: [LLDB][MIPS] Fix TestConcurrentEvents by committing rL266589: [LLDB][MIPS] Fix TestConcurrentEvents.
Apr 17 2016, 10:33 PM

Apr 14 2016

mohit.bhakkad abandoned D18312: [Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS.

Looks like there was issue with some library on the machine I was working on previously, as I am unable to replicate error on any other mips(el/eb) machine.
Abandoning this change.
Thanks!

Apr 14 2016, 3:44 AM

Mar 22 2016

mohit.bhakkad added a comment to D18312: [Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS.

@samsonov sure I will investigate libc code and get back to you.
Till now,
I have tried replacing original libc call with a dummy stub of getpwnam_r returning same values, which makes the test pass.
Also with msan, tsan test passes without fail.

Mar 22 2016, 5:59 AM
mohit.bhakkad committed rL264030: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py.
[LLDB]{MIPS] Fix TestPlatformProcessConnect.py
Mar 22 2016, 1:13 AM
mohit.bhakkad closed D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py by committing rL264030: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py.
Mar 22 2016, 1:13 AM

Mar 21 2016

mohit.bhakkad retitled D18312: [Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS from to [Compiler-rt] Mark getpwnam_r_invalid_user as expected failure for MIPS.
Mar 21 2016, 4:47 AM

Mar 16 2016

mohit.bhakkad committed rL263621: [ASAN] Add support for mips/mips64 android.
[ASAN] Add support for mips/mips64 android
Mar 16 2016, 1:28 AM
mohit.bhakkad closed D17883: [ASAN] Add support for mips/mips64 android by committing rL263621: [ASAN] Add support for mips/mips64 android.
Mar 16 2016, 1:28 AM
mohit.bhakkad added a comment to D17883: [ASAN] Add support for mips/mips64 android.

Changed the location of TlsPreTcbSize() in commit.

Mar 16 2016, 1:27 AM

Mar 15 2016

mohit.bhakkad requested review of D17883: [ASAN] Add support for mips/mips64 android.
Mar 15 2016, 3:25 AM
mohit.bhakkad updated the diff for D17883: [ASAN] Add support for mips/mips64 android.

Hi @samsonov, Duane suggested some changes in sanitizer_common/sanitizer_linux_libcdep.cc, could you please review it?

Mar 15 2016, 3:25 AM

Mar 11 2016

mohit.bhakkad committed rL263218: [Sanitizer][MIPS] internal lstat and fstat for mips64.
[Sanitizer][MIPS] internal lstat and fstat for mips64
Mar 11 2016, 2:56 AM
mohit.bhakkad closed D18078: [Sanitizer][MIPS] internal lstat and fstat for mips64 by committing rL263218: [Sanitizer][MIPS] internal lstat and fstat for mips64.
Mar 11 2016, 2:56 AM
mohit.bhakkad added a comment to D18078: [Sanitizer][MIPS] internal lstat and fstat for mips64.

This is similar to D6385, don't know why we missed it then.

Mar 11 2016, 2:02 AM
mohit.bhakkad retitled D18078: [Sanitizer][MIPS] internal lstat and fstat for mips64 from to [Sanitizer][MIPS] internal lstat and fstat for mips64.
Mar 11 2016, 1:55 AM

Mar 10 2016

mohit.bhakkad committed rL263199: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.
[Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test
Mar 10 2016, 10:02 PM
mohit.bhakkad closed D17985: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test by committing rL263199: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.
Mar 10 2016, 10:02 PM

Mar 9 2016

mohit.bhakkad updated the diff for D17883: [ASAN] Add support for mips/mips64 android.

Changes in this revision:

  • separate definition of __sanitizer_sigactionfor mips32 android.
  • using conditional operator at sanitizer_platform_limits_posix.h:80
Mar 9 2016, 11:25 PM
mohit.bhakkad updated the diff for D17985: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.

changed as suggested.

Mar 9 2016, 10:35 PM
mohit.bhakkad retitled D17985: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test from to [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test.
Mar 9 2016, 3:43 AM
mohit.bhakkad committed rL263001: [DFSan] Fix test_inet_pton for big endian archs.
[DFSan] Fix test_inet_pton for big endian archs
Mar 9 2016, 12:05 AM
mohit.bhakkad closed D17751: [DFSan] Fix test_inet_pton for big endian archs by committing rL263001: [DFSan] Fix test_inet_pton for big endian archs.
Mar 9 2016, 12:05 AM
mohit.bhakkad committed rL263000: [Compiler-rt][MIPS] Defining macros for MIPS archs.
[Compiler-rt][MIPS] Defining macros for MIPS archs
Mar 9 2016, 12:02 AM
mohit.bhakkad closed D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs by committing rL263000: [Compiler-rt][MIPS] Defining macros for MIPS archs.
Mar 9 2016, 12:02 AM

Mar 8 2016

mohit.bhakkad updated the diff for D17883: [ASAN] Add support for mips/mips64 android.

Removed parens.

Mar 8 2016, 10:15 PM

Mar 7 2016

mohit.bhakkad added a comment to D17751: [DFSan] Fix test_inet_pton for big endian archs.

Hi @pcc, @samsonov, could you please review this?

Mar 7 2016, 10:10 PM
mohit.bhakkad updated the diff for D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs.

Thanks, added it.

Mar 7 2016, 1:31 AM
mohit.bhakkad committed rL262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint.
[LLDB][MIPS] Fix TestDisassembleBreakpoint
Mar 7 2016, 1:17 AM
mohit.bhakkad closed D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint by committing rL262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint.
Mar 7 2016, 1:17 AM
mohit.bhakkad updated the diff for D17883: [ASAN] Add support for mips/mips64 android.

Changed indentation and some other changes.

Mar 7 2016, 1:11 AM

Mar 6 2016

mohit.bhakkad updated the diff for D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs.

Changing as suggested.

Mar 6 2016, 10:17 PM

Mar 4 2016

mohit.bhakkad abandoned D17880: [Compiler-rt] Use __gnu_linux__ instead of __linux__ to detect Linux OS.

Thanks, I will abandon this patch.

Mar 4 2016, 3:56 AM
mohit.bhakkad added a comment to D17842: [ASAN] Add support for mips/mips64 android.

sagar is not available for a week, request you to please review this at D17883

Mar 4 2016, 3:50 AM
mohit.bhakkad retitled D17883: [ASAN] Add support for mips/mips64 android from to [ASAN] Add support for mips/mips64 android.
Mar 4 2016, 3:48 AM
mohit.bhakkad retitled D17881: [Compiler-rt][MIPS] Defining macros for MIPS archs from to [Compiler-rt][MIPS] Defining macros for MIPS archs.
Mar 4 2016, 2:36 AM
mohit.bhakkad retitled D17880: [Compiler-rt] Use __gnu_linux__ instead of __linux__ to detect Linux OS from to [Compiler-rt] Use __gnu_linux__ instead of __linux__ to detect Linux OS.
Mar 4 2016, 2:26 AM

Mar 3 2016

mohit.bhakkad committed rL262690: [Compiler-rt][safestack] Enable for MIPS.
[Compiler-rt][safestack] Enable for MIPS
Mar 3 2016, 10:20 PM
mohit.bhakkad closed D17846: [Compiler-rt][safestack] Enable for MIPS by committing rL262690: [Compiler-rt][safestack] Enable for MIPS.
Mar 3 2016, 10:20 PM
mohit.bhakkad retitled D17846: [Compiler-rt][safestack] Enable for MIPS from to [Compiler-rt][safestack] Enable for MIPS.
Mar 3 2016, 2:21 AM

Mar 2 2016

mohit.bhakkad committed rL262581: [LSan] Enable use_registers test for MIPS.
[LSan] Enable use_registers test for MIPS
Mar 2 2016, 9:10 PM
mohit.bhakkad closed D17797: [LSan] Enable use_registers test for MIPS by committing rL262581: [LSan] Enable use_registers test for MIPS.
Mar 2 2016, 9:10 PM
mohit.bhakkad retitled D17797: [LSan] Enable use_registers test for MIPS from to [LSan] Enable use_registers test for MIPS.
Mar 2 2016, 12:44 AM

Mar 1 2016

mohit.bhakkad updated the diff for D17751: [DFSan] Fix test_inet_pton for big endian archs.

sorry, updating again with a full context diff.

Mar 1 2016, 12:48 AM
mohit.bhakkad updated the diff for D17751: [DFSan] Fix test_inet_pton for big endian archs.

Changed as suggested.

Mar 1 2016, 12:40 AM

Feb 29 2016

mohit.bhakkad retitled D17751: [DFSan] Fix test_inet_pton for big endian archs from to [DFSan] Fix test_inet_pton for big endian archs.
Feb 29 2016, 10:39 PM
mohit.bhakkad committed rL262303: [Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS.
[Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS
Feb 29 2016, 10:01 PM
mohit.bhakkad closed D17703: [Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS by committing rL262303: [Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS.
Feb 29 2016, 10:01 PM
mohit.bhakkad committed rL262302: [Compiler-rt][MSan] fix param_tls_limit test for platforms where big….
[Compiler-rt][MSan] fix param_tls_limit test for platforms where big…
Feb 29 2016, 9:58 PM
mohit.bhakkad closed D17129: [Compiler-rt][MSan] fix param_tls_limit test by committing rL262302: [Compiler-rt][MSan] fix param_tls_limit test for platforms where big….
Feb 29 2016, 9:58 PM
mohit.bhakkad updated the diff for D17129: [Compiler-rt][MSan] fix param_tls_limit test.

Updating revision with full context patch

Feb 29 2016, 2:08 AM
mohit.bhakkad updated the diff for D17129: [Compiler-rt][MSan] fix param_tls_limit test.

Changed as suggested.

Feb 29 2016, 2:01 AM
mohit.bhakkad committed rL262209: Update the link of issue.
Update the link of issue
Feb 29 2016, 12:27 AM
mohit.bhakkad abandoned D17642: [MSan] Mark dtls_test expected failure for MIPS.

I will update the link with a commit.
Looks like it was due to wrong kDtvOffset value for MIPS, corrected it in D17703.

Feb 29 2016, 12:18 AM
mohit.bhakkad retitled D17703: [Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS from to [Compiler-rt][MIPS] Correct Dynamic Thread Vector offset for MIPS.
Feb 29 2016, 12:15 AM

Feb 26 2016

mohit.bhakkad updated D17642: [MSan] Mark dtls_test expected failure for MIPS.
Feb 26 2016, 5:00 AM
mohit.bhakkad updated D17642: [MSan] Mark dtls_test expected failure for MIPS.
Feb 26 2016, 4:55 AM
mohit.bhakkad retitled D17642: [MSan] Mark dtls_test expected failure for MIPS from to [MSan] Mark dtls_test expected failure for MIPS.
Feb 26 2016, 4:54 AM
mohit.bhakkad updated the diff for D17129: [Compiler-rt][MSan] fix param_tls_limit test.

defining PARTIAL_OVERFLOW to check shadow of arguments greater than tls limit on platforms where big arguments are sliced in smaller ones.

Feb 26 2016, 1:49 AM

Feb 25 2016

mohit.bhakkad closed D17264: [Compiler-rt][MSan] Fix msan_print_shadow3.cc test for Big Endian archs.

Commited in rL261982.

Feb 25 2016, 11:03 PM
mohit.bhakkad closed D17563: [MSan] Endianness should not matter while printing a byte.

Commited in rL261982.

Feb 25 2016, 11:03 PM
mohit.bhakkad committed rL261982: [MSan] Endianness should not matter while printing a byte.
[MSan] Endianness should not matter while printing a byte
Feb 25 2016, 10:48 PM
mohit.bhakkad requested review of D17264: [Compiler-rt][MSan] Fix msan_print_shadow3.cc test for Big Endian archs.
Feb 25 2016, 10:26 PM