Page MenuHomePhabricator

nitesh.jain (Nitesh Jain)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2015, 9:10 PM (221 w, 6 d)

Recent Activity

Oct 22 2017

nitesh.jain committed rL316287: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld..
[mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
Oct 22 2017, 2:49 AM
nitesh.jain closed D38314: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld by committing rL316287: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld..
Oct 22 2017, 2:49 AM
nitesh.jain committed rL316286: [Compiler-rt][MIPS] Fix cross build for XRAY..
[Compiler-rt][MIPS] Fix cross build for XRAY.
Oct 22 2017, 2:38 AM
nitesh.jain closed D38021: [Compiler-rt][MIPS] Fix cross build for XRAY by committing rL316286: [Compiler-rt][MIPS] Fix cross build for XRAY..
Oct 22 2017, 2:38 AM
nitesh.jain updated the diff for D38314: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
Oct 22 2017, 2:35 AM
nitesh.jain updated the diff for D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.
Oct 22 2017, 1:55 AM

Oct 16 2017

nitesh.jain updated the diff for D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.

Update diff as per suggestion.

Oct 16 2017, 10:10 AM

Oct 10 2017

nitesh.jain added inline comments to D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.
Oct 10 2017, 6:18 AM
nitesh.jain updated the diff for D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.

Updated diff as per suggestion

Oct 10 2017, 1:44 AM
nitesh.jain added a comment to D38314: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

ping

Oct 10 2017, 1:22 AM

Oct 9 2017

nitesh.jain added a comment to D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.

SANITIZER_COMMON_CFLAGS is defined somewhere else in compiler-rt. It already should be including the CMAKE_C_FLAGS into its definition, so I'm confused why we even need this change.

Oct 9 2017, 5:15 AM
nitesh.jain updated the diff for D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.

Update diff as per suggestion

Oct 9 2017, 3:45 AM

Oct 6 2017

nitesh.jain added a comment to D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.

Hi Simon,

Oct 6 2017, 7:22 AM
nitesh.jain updated the diff for D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.

Fix unit test build issues.

Oct 6 2017, 7:20 AM

Sep 28 2017

nitesh.jain resigned from D38038: [mips] Enable spilling and reloading of the dsp register set..
Sep 28 2017, 3:27 AM

Sep 27 2017

nitesh.jain created D38314: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
Sep 27 2017, 6:11 AM

Sep 18 2017

nitesh.jain accepted D37476: [mips] Partially fix PR34391.

LGTM.

Sep 18 2017, 10:16 PM
nitesh.jain created D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.
Sep 18 2017, 10:14 PM

Sep 13 2017

nitesh.jain added a comment to D37829: [mips] Fix sem_init_glibc test for MIPS..

Thanks Simon.

Sep 13 2017, 11:13 PM

Aug 14 2017

nitesh.jain committed rL310856: [LLDB][MIPS] Fix process load/unload on android..
[LLDB][MIPS] Fix process load/unload on android.
Aug 14 2017, 9:41 AM
nitesh.jain closed D36445: Fix "process load/unload" on android by committing rL310856: [LLDB][MIPS] Fix process load/unload on android..
Aug 14 2017, 9:41 AM
nitesh.jain committed rL310855: [LLDB][MIPS] Set the Section's file address for.
[LLDB][MIPS] Set the Section's file address for
Aug 14 2017, 9:31 AM
nitesh.jain closed D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set by committing rL310855: [LLDB][MIPS] Set the Section's file address for.
Aug 14 2017, 9:31 AM
nitesh.jain updated the diff for D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.

Update diff as per suggestion. Thanks Greg for your suggestion.

Aug 14 2017, 2:11 AM

Aug 11 2017

nitesh.jain added a comment to D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.

The $debug_rangesN symbols are added by linker. These symbols are not used anywhere We can skip these type of symbols (where symbol type is STT_NOTYPE and its section is Debug)

Aug 11 2017, 5:40 AM
nitesh.jain retitled D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set from [LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address to [LLDB][MIPS] The symbol with NOTYPE and having section type debug doesn't contain any valid address.
Aug 11 2017, 5:40 AM
nitesh.jain updated the diff for D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.
Aug 11 2017, 5:37 AM

Aug 9 2017

nitesh.jain updated the diff for D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.
Aug 9 2017, 5:44 AM
nitesh.jain updated the diff for D36445: Fix "process load/unload" on android.

Fix Format.

Aug 9 2017, 5:01 AM
nitesh.jain updated the diff for D36445: Fix "process load/unload" on android.

Update diff as per suggestion

Aug 9 2017, 4:36 AM

Aug 8 2017

nitesh.jain created D36445: Fix "process load/unload" on android.
Aug 8 2017, 12:00 AM

Aug 4 2017

nitesh.jain added a comment to D11465: Fix "process load/unload" on android.

Thanks for all of the data. Based on this I think you are using a preview version of android O what reports SDK 25 but the linker works the way an SDK 26 system linker would do.

I think the proper fix for the problem is to do something like what Greg suggested to detect the correct function name based on the list of available symbols instead of based on the SDK version. I will try to create a CL to fix it in the next couple of days (unless you are happy to do it), but not sure when I will have time for that and it is a bit tricky to test it.

Until then you can try to do either update to a newer version of the system image what reports SDK 26 (and make sure you are using a sufficiently new LLDB) or locally hack the "PlatformAndroid::LoadImage" function to use the SDK 26 version in case of SDK 25 as well (possibly with a check for ro.build.version.release)

Aug 4 2017, 12:54 AM
nitesh.jain added a comment to D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.

Please could you find some time to look into this ?

Aug 4 2017, 12:46 AM

Jul 31 2017

nitesh.jain added a comment to D11465: Fix "process load/unload" on android.

The android version am using for testing is "O".

Jul 31 2017, 7:50 AM
nitesh.jain added a comment to D11465: Fix "process load/unload" on android.

Hi Tamas,

Jul 31 2017, 7:37 AM
nitesh.jain added inline comments to D36046: Improve the posix core file triple detection.
Jul 31 2017, 7:10 AM
nitesh.jain added a comment to D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.

So the issue is with the ObjectFileELF when it makes its symbol table. It is taking this symbols:

49686: 000000000000bcf0 0 NOTYPE LOCAL DEFAULT 40 $debug_ranges627

And saying it is a code symbol. This symbols has a NOTYPE on it, not FUNC like the main symbol. Fix the ObjectFileELF to give an appropriate lldb::SymbolType value for it. It shouldn't be lldb::SymbolType::eSymbolTypeCode. So set all NOTYPE to lldb::SymbolType::eSymbolTypeInvalid or add a new enum that makes sense.

Jul 31 2017, 6:59 AM

Jul 27 2017

nitesh.jain added inline comments to D11465: Fix "process load/unload" on android.
Jul 27 2017, 4:55 AM

Jul 26 2017

nitesh.jain committed rL309250: [LLDB][MIPS] Fix emulation of Instruction for MIPS64R6 target..
[LLDB][MIPS] Fix emulation of Instruction for MIPS64R6 target.
Jul 26 2017, 10:35 PM
nitesh.jain added a comment to D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.

Looking at an ELF file with DWARF, I see:

(lldb) image dump sections 
Dumping sections for 1 modules.
Sections for '/Volumes/android/aosp/out/target/product/generic/symbols/system/lib/libart.so' (arm):
  SectID     Type             File Address                             Perm File Off.  File Size  Flags      Section Name
  ---------- ---------------- ---------------------------------------  ---- ---------- ---------- ---------- ----------------------------
  0x00000001 regular                                                   ---  0x00000000 0x00000000 0x00000000 libart.so.
  0x00000002 regular          [0x0000000000000154-0x0000000000000167)  r--  0x00000154 0x00000013 0x00000002 libart.so..interp
  0x00000003 elf-dynamic-symbols [0x0000000000000168-0x0000000000010d18)  r--  0x00000168 0x00010bb0 0x00000002 libart.so..dynsym
  0x00000004 regular          [0x0000000000010d18-0x000000000005228f)  r--  0x00010d18 0x00041577 0x00000002 libart.so..dynstr
  0x00000005 regular          [0x0000000000052290-0x000000000005a590)  r--  0x00052290 0x00008300 0x00000002 libart.so..hash
  0x00000006 elf-relocation-entries [0x000000000005a590-0x0000000000067870)  r--  0x0005a590 0x0000d2e0 0x00000002 libart.so..rel.dyn
  0x00000007 elf-relocation-entries [0x0000000000067870-0x0000000000068398)  r--  0x00067870 0x00000b28 0x00000002 libart.so..rel.plt
  0x00000008 regular          [0x0000000000068398-0x0000000000069468)  r-x  0x00068398 0x000010d0 0x00000006 libart.so..plt
  0x00000009 code             [0x0000000000069470-0x00000000002a94f8)  r-x  0x00069470 0x00240088 0x00000006 libart.so..text
  0x0000000a ARM.exidx        [0x00000000002a94f8-0x00000000002b12d0)  r--  0x002a94f8 0x00007dd8 0x00000082 libart.so..ARM.exidx
  0x0000000b ARM.extab        [0x00000000002b12d0-0x00000000002b1e44)  r--  0x002b12d0 0x00000b74 0x00000002 libart.so..ARM.extab
  0x0000000c regular          [0x00000000002b1e48-0x00000000002e39e4)  r--  0x002b1e48 0x00031b9c 0x00000002 libart.so..rodata
  0x0000000d eh-frame         [0x00000000002e39e4-0x00000000002e5fa8)  r--  0x002e39e4 0x000025c4 0x00000002 libart.so..eh_frame
  0x0000000e regular          [0x00000000002e5fa8-0x00000000002e63d4)  r--  0x002e5fa8 0x0000042c 0x00000002 libart.so..eh_frame_hdr
  0x0000000f regular          [0x00000000002e7e38-0x00000000002eaa24)  rw-  0x002e6e38 0x00002bec 0x00000003 libart.so..data.rel.ro.local
  0x00000010 regular          [0x00000000002eaa24-0x00000000002eaa28)  rw-  0x002e9a24 0x00000004 0x00000003 libart.so..fini_array
  0x00000011 regular          [0x00000000002eaa28-0x00000000002ee370)  rw-  0x002e9a28 0x00003948 0x00000003 libart.so..data.rel.ro
  0x00000012 regular          [0x00000000002ee370-0x00000000002ee3c0)  rw-  0x002ed370 0x00000050 0x00000003 libart.so..init_array
  0x00000013 elf-dynamic-link-info [0x00000000002ee3c0-0x00000000002ee4f0)  rw-  0x002ed3c0 0x00000130 0x00000003 libart.so..dynamic
  0x00000014 regular          [0x00000000002ee4f4-0x00000000002ef000)  rw-  0x002ed4f4 0x00000b0c 0x00000003 libart.so..got
  0x00000015 data             [0x00000000002ef000-0x00000000002ef8c4)  rw-  0x002ee000 0x000008c4 0x00000003 libart.so..data
  0x00000016 zero-fill        [0x00000000002ef8c8-0x00000000002f11fc)  rw-  0x002ee8c8 0x00000000 0x00000003 libart.so..bss
  0x00000017 regular                                                   ---  0x002ee8c4 0x00000010 0x00000030 libart.so..comment
  0x00000018 dwarf-line                                                ---  0x002ee8d4 0x002c10eb 0x00000000 libart.so..debug_line
  0x00000019 dwarf-info                                                ---  0x005af9bf 0x054eb22a 0x00000000 libart.so..debug_info
  0x0000001a dwarf-abbrev                                              ---  0x05a9abe9 0x000f5e5b 0x00000000 libart.so..debug_abbrev
  0x0000001b dwarf-aranges                                             ---  0x05b90a48 0x00011960 0x00000000 libart.so..debug_aranges
  0x0000001c dwarf-loc                                                 ---  0x05ba23a8 0x00a0d623 0x00000000 libart.so..debug_loc
  0x0000001d dwarf-ranges                                              ---  0x065af9cb 0x0029c7b0 0x00000000 libart.so..debug_ranges
  0x0000001e dwarf-macro                                               ---  0x0684c17b 0x000ada15 0x00000000 libart.so..debug_macro
  0x0000001f dwarf-str                                                 ---  0x068f9b90 0x004a45e9 0x00000030 libart.so..debug_str
  0x00000020 dwarf-frame                                               ---  0x06d9e17c 0x0003fc6c 0x00000000 libart.so..debug_frame
  0x00000021 regular                                                   ---  0x06dddde8 0x0000001c 0x00000000 libart.so..note.gnu.gold-version
  0x00000022 regular                                                   ---  0x06ddde04 0x00000038 0x00000000 libart.so..ARM.attributes
  0x00000023 elf-symbol-table                                          ---  0x06ddde3c 0x00056c30 0x00000000 libart.so..symtab
  0x00000024 regular                                                   ---  0x06e34a6c 0x0006c9e6 0x00000000 libart.so..strtab
  0x00000025 regular                                                   ---  0x06ea1452 0x0000017b 0x00000000 libart.so..shstrtab

Note how all DWARF sections have no file address. They are known to not be valid addresses. Are you seeing something different with your ELF file? Or do you have two ELF files? One without symbols and one with? The output of "image dump sections" should look like above where no DWARF sections have anything valid in the "File Address" column.

Jul 26 2017, 5:49 AM

Jul 25 2017

nitesh.jain added a comment to D35555: [MIPS][TSAN] Fix test user_malloc.cc.

Nitesh, can you commandeer this?

Thanks,
Simon

Jul 25 2017, 4:26 AM

Jul 24 2017

nitesh.jain added reviewers for D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set: labath, clayborg, jingham.
Jul 24 2017, 10:42 PM
nitesh.jain created D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set.
Jul 24 2017, 12:04 AM

Jun 14 2017

nitesh.jain committed rL305383: [LLDB][MIPS] Skip TestGdbRemoteSingleStep and TestGdbRemote_vCont.py..
[LLDB][MIPS] Skip TestGdbRemoteSingleStep and TestGdbRemote_vCont.py.
Jun 14 2017, 5:22 AM
nitesh.jain committed rL305380: [LLDB][MIPS] Fix TestNoreturnUnwind.py..
[LLDB][MIPS] Fix TestNoreturnUnwind.py.
Jun 14 2017, 3:48 AM
nitesh.jain committed rL305378: [LLDB][MIPS] Fix TestRegisterVariables.py..
[LLDB][MIPS] Fix TestRegisterVariables.py.
Jun 14 2017, 3:03 AM

May 4 2017

nitesh.jain committed rL302139: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure..
[LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.
May 4 2017, 4:48 AM
nitesh.jain closed D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure by committing rL302139: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure..
May 4 2017, 4:48 AM

May 2 2017

nitesh.jain updated the diff for D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.

Update diff as per suggestion.

May 2 2017, 3:28 AM

Apr 27 2017

nitesh.jain added a comment to D32340: [LLDB][MIPS] Fix TestMiExec.py failure.

Hi Ki,

Apr 27 2017, 5:42 AM
nitesh.jain committed rL301537: [LLDB][MIPS] Forgot to add check in commit rl301530.
[LLDB][MIPS] Forgot to add check in commit rl301530
Apr 27 2017, 5:40 AM
nitesh.jain added inline comments to D32340: [LLDB][MIPS] Fix TestMiExec.py failure.
Apr 27 2017, 4:48 AM
nitesh.jain updated the diff for D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.

Update Diff as per suggestion

Apr 27 2017, 3:40 AM
nitesh.jain committed rL301530: [LLDB][MIPS] Fix TestMiExec.py failure..
[LLDB][MIPS] Fix TestMiExec.py failure.
Apr 27 2017, 3:34 AM
nitesh.jain closed D32340: [LLDB][MIPS] Fix TestMiExec.py failure by committing rL301530: [LLDB][MIPS] Fix TestMiExec.py failure..
Apr 27 2017, 3:34 AM

Apr 26 2017

nitesh.jain updated the diff for D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.

Update diff as per suggestion

Apr 26 2017, 6:21 AM

Apr 25 2017

nitesh.jain added a comment to D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Hi Nitesh,

this commit broke clang-cmake-mips. Can you investigate?

http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/3189

Thanks,
Simon

Apr 25 2017, 6:41 AM
nitesh.jain committed rL301307: [Compiler-rt][MIPS] Fix assert introduce with commit rl301171..
[Compiler-rt][MIPS] Fix assert introduce with commit rl301171.
Apr 25 2017, 6:38 AM

Apr 24 2017

nitesh.jain committed rL301295: [LLDB][MIPS] Fix typo in TestStepOverWatchpoint.py..
[LLDB][MIPS] Fix typo in TestStepOverWatchpoint.py.
Apr 24 2017, 11:25 PM
nitesh.jain committed rL301172: [LLDB][MIPS] Move it into HandleLLVMOptions.cmake..
[LLDB][MIPS] Move it into HandleLLVMOptions.cmake.
Apr 24 2017, 4:08 AM
nitesh.jain committed rL301171: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM..
[LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.
Apr 24 2017, 3:49 AM
nitesh.jain closed D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM by committing rL301171: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM..
Apr 24 2017, 3:49 AM
nitesh.jain added a comment to D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago.

It's perhaps no-op, but it might be noted in the commit message what platforms are supposed to be improved.

I'd say it's better to put a comment in the source where it's set.

Apr 24 2017, 3:47 AM
nitesh.jain added a comment to D32340: [LLDB][MIPS] Fix TestMiExec.py failure.

Thanks for catching this! Could you update this CL to let me commit it?

Apr 24 2017, 3:23 AM
nitesh.jain updated the diff for D32340: [LLDB][MIPS] Fix TestMiExec.py failure.

Update diff as per suggestion.

Apr 24 2017, 3:22 AM

Apr 21 2017

nitesh.jain created D32340: [LLDB][MIPS] Fix TestMiExec.py failure.
Apr 21 2017, 12:40 AM

Apr 18 2017

nitesh.jain updated the summary of D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.
Apr 18 2017, 8:56 AM
nitesh.jain created D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.
Apr 18 2017, 8:55 AM
nitesh.jain added a comment to D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago.

It's perhaps no-op, but it might be noted in the commit message what platforms are supposed to be improved.

Apr 18 2017, 8:31 AM
nitesh.jain updated the diff for D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Update diff as per suggestion.

Apr 18 2017, 8:30 AM

Apr 17 2017

nitesh.jain created D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.
Apr 17 2017, 6:25 AM

Apr 5 2017

nitesh.jain committed rL299527: Fix a typo introduce in r299200..
Fix a typo introduce in r299200.
Apr 5 2017, 2:44 AM

Mar 31 2017

nitesh.jain committed rL299200: [LLDB][MIPS] Core Dump Support..
[LLDB][MIPS] Core Dump Support.
Mar 31 2017, 4:26 AM
nitesh.jain closed D30457: [LLDB][MIPS] Core Dump Support by committing rL299200: [LLDB][MIPS] Core Dump Support..
Mar 31 2017, 4:26 AM
nitesh.jain committed rL299199: [LLDB][MIPS] Fix Core file Architecture and OS information..
[LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 31 2017, 4:18 AM
nitesh.jain closed D31280: [LLDB][MIPS] Fix Core file Architecture and OS information by committing rL299199: [LLDB][MIPS] Fix Core file Architecture and OS information..
Mar 31 2017, 4:18 AM
nitesh.jain committed rL299196: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding….
[LLDB][MIPS] Check if memory_info.GetName() is empty before finding…
Mar 31 2017, 4:08 AM
nitesh.jain closed D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module. by committing rL299196: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding….
Mar 31 2017, 4:08 AM

Mar 27 2017

nitesh.jain updated the diff for D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

Update diff as per suggestion.

Mar 27 2017, 6:53 AM

Mar 23 2017

nitesh.jain added a comment to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

The core architecture doesn't have any revision, os and ABI information. Hence we need to relied on target architecture.

Mar 23 2017, 9:05 AM
nitesh.jain added inline comments to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 9:02 AM
nitesh.jain updated the diff for D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

updated diff as per suggestion

Mar 23 2017, 8:49 AM
nitesh.jain added inline comments to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 7:00 AM
nitesh.jain added inline comments to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 4:15 AM
nitesh.jain added a comment to D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.

They are around ~28KB

Mar 23 2017, 4:00 AM
nitesh.jain added a comment to D30457: [LLDB][MIPS] Core Dump Support.

Added test case for MIPS in https://reviews.llvm.org/D31280

Mar 23 2017, 1:02 AM
nitesh.jain created D31280: [LLDB][MIPS] Fix Core file Architecture and OS information.
Mar 23 2017, 12:48 AM
nitesh.jain updated the diff for D30457: [LLDB][MIPS] Core Dump Support.

In case of MIPS, The ELFLinuxPrPsInfo.pr_uid and ELFLinuxPrPsInfo.pr_gid is always 32 bit irrespective of platforms

Mar 23 2017, 12:35 AM

Mar 15 2017

nitesh.jain added a comment to D30457: [LLDB][MIPS] Core Dump Support.
Thank you for updating that. Let me know what the make_core investigation uncovers.
Mar 15 2017, 8:54 AM
nitesh.jain updated the diff for D30457: [LLDB][MIPS] Core Dump Support.

Update Diff as per suggestion

Mar 15 2017, 8:49 AM
nitesh.jain updated the diff for D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module..
Mar 15 2017, 4:47 AM
nitesh.jain updated the diff for D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module..

In case of debugging normal process, the memory_info.GetName() is not empty and hence module is read from memory (m_process->ReadModuleFromMemory) and the corresponding sections are updated. In case of core file , the memory_info.GetName() is empty which causes FindFirstModule to matches with the first module in ModuleSpecList and result in loading wrong module at incorrect sections addresses. This patch regain "vdso" module name if memory_info.GetName() is empty.

Mar 15 2017, 1:31 AM

Mar 7 2017

nitesh.jain added a comment to D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module..

So a ModuleSpec allows you to specify a module by path, UUID and many other things. This is falling down for a magic file that doesn't actually exist right?

Mar 7 2017, 5:05 AM

Mar 2 2017

nitesh.jain added a comment to D30457: [LLDB][MIPS] Core Dump Support.

The .note.ABI-tag is missing in the ELF file, generated by test/testcases/functionalities/postmortem/elf-core/make-core.sh. Need to look into it.

Mar 2 2017, 6:41 AM
nitesh.jain added inline comments to D30457: [LLDB][MIPS] Core Dump Support.
Mar 2 2017, 6:34 AM
nitesh.jain updated the diff for D30457: [LLDB][MIPS] Core Dump Support.

Update diff as per suggestion.

Mar 2 2017, 6:29 AM
nitesh.jain added a comment to D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module..

Attach log file

Mar 2 2017, 2:41 AM
nitesh.jain added a comment to D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module..

The issue was observed while parsing "vdso module" for the core file. When the DynamicLoader::LoadModuleAtAddress is called to load "vdso" module. Since "vdso" doesn't match with any of the module in the target.GetImages(), the check_alternative_file_name becomes true. This cause MatchesModuleSpec to return true and application binary to reload again at vdso base address(AT_SYSINFO_EHDR) thus all load addresses of application elf's sections becomes incorrect. Please find attach log file.
DynamicLoader::LoadModuleAtAddress(...)
{

...
...
...
if (check_alternative_file_name) {
        ...
        ...
        ...
        **FileSpec(memory_info.GetName().AsCString(), false),**  ** // memory_info.GetName().AsCString() is empty here**
        target.GetArchitecture());
Mar 2 2017, 2:40 AM

Feb 28 2017

nitesh.jain created D30457: [LLDB][MIPS] Core Dump Support.
Feb 28 2017, 6:09 AM
nitesh.jain created D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module..
Feb 28 2017, 4:22 AM