Hi Eugene,

Looks good as far as correctness is concerned.

LGTM

Looks good.

Looks good.

Closed by commit http://reviews.llvm.org/rL261206

Can you please "accept" this revision so that I can "close" this one?

In MIPS, we can not put a breakpoint in middle of an atomic sequence.
If we do so (and that breakpoint is hit) then continuing from breakpoint address will cause "SC" to fail due to a breakpoint exception.
SC fails when there’s been any exception serviced since the LL. This will then become a "never ending" sequence.

I'm guessing it's something to do with the 'Features[CPU] = true' line.

This was observed during expression evaluation in LLDB, where LLDB does not explicitly set clang::TargetOptions::CPU hence it remains empty.

Hi Zachary,

Ok to commit?

Removed assert statement so now "ArchSpec::GetClangTargetCPU ()" returns an empty string (instead of crashing) for any CPU that doesn't really need to make a special CPU string.
Removed the "if (is_mips)".

Addressed review comments:

• Rebased this patch off top of tree
• Added ArchSpec::GetClangTargetCPU() as suggested and moved large switch statement into it.

Addresses review comments.
Used local variables instead of calling accessors each time.

Closed by commit http://reviews.llvm.org/rL260072

Closed by commit http://reviews.llvm.org/rL258919

Closed by commit http://reviews.llvm.org/rL258485

As suggested by Greg, added new function matchArchitectures(archs) which handles "archs".
This function can be used by other decorator functions for testing "archs".

In D14111#330305, @spyffe wrote:

That looks fine to me as far as it goes, but it doesn't cover other places where $ is used in function names, e.g. the name of the expression itself, and classes it's placed in. Could you have a look at ExpressionSourceCode.cpp and see if there is anything there that needs a $ as well?

Addressed review comments.
Instead of adding new decorator, this patch modifies existing skipUnlessArch to detect the type of the "archs" variable and do the things according to the type.
This handles regular expressions as well.

Hi Greg,

In D16049#326634, @labath wrote:

In D16049#326631, @bhushan wrote:

Hi Zachary,

If we use @skipIf then the list would require to contain all possible MIPS variations and the list will grow long.
for ex: @skipIf(archs=not_in(['mips32','mips32r2', 'mips32r3', 'mips64','mips64r2', 'mips64r3', 'mips64r6' ......]))

@skipUnlessMips covers all these possible values using regular expression matching.

I agree with Zachary that we have too many decorators and we shouldn't be expanding their number, it's simply not sustainable. I see two options here:

• add a getMipsArchitectures() function and then write archs=not_in(getMipsArchitectures())
• add a not_regex() function and write archs=not_regex('mips.*')

How does that sound?

Hi Zachary,

This diff adds a testcase to test this patch.

Closed by commit http://reviews.llvm.org/rL257441

Closed by commit http://reviews.llvm.org/rL257442

Yes, it does fix the issue.

Get the load address for the address given by 'symbol' and 'function'.
Earlier, this was done for 'function' only, this patch does it for 'symbol' too.

Hi Pavel,

Closed by commit http://reviews.llvm.org/rL256915

This was committed on 6th Oct 15 by http://reviews.llvm.org/rL249381 ,closing it now.

Closed by commit http://reviews.llvm.org/rL255005

Hi Sean/Jim

Closed by commit rL246015

Closed by commit rL247666

Addressed review comments.

Closed by Commit rL243091

Committed in revision 245026

Committed in revision 245020

Addresses review comments. (Initialized variables with default values).

Addressed review comments (fixed indentation issues)

Looks good

This patch implements MIPS64 assembly profiler using EmulateInstruction class.

Thanks jasonmolenda for your review and comments.
I will do the corrections as suggested by you.
My comments are inlined.