User Details
- User Since
- Jan 7 2015, 12:47 AM (385 w, 2 d)
Nov 13 2016
Sep 30 2016
Hi Eugene,
Looks good as far as correctness is concerned.
Jul 27 2016
LGTM
Jun 9 2016
Looks good.
May 19 2016
Looks good.
Mar 15 2016
Closed by commit http://reviews.llvm.org/rL261206
Can you please "accept" this revision so that I can "close" this one?
Feb 24 2016
In MIPS, we can not put a breakpoint in middle of an atomic sequence.
If we do so (and that breakpoint is hit) then continuing from breakpoint address will cause "SC" to fail due to a breakpoint exception.
SC fails when there’s been any exception serviced since the LL. This will then become a "never ending" sequence.
Feb 22 2016
I'm guessing it's something to do with the 'Features[CPU] = true' line.
Feb 18 2016
This was observed during expression evaluation in LLDB, where LLDB does not explicitly set clang::TargetOptions::CPU hence it remains empty.
Feb 17 2016
Hi Zachary,
Feb 16 2016
Ok to commit?
Feb 11 2016
Removed assert statement so now "ArchSpec::GetClangTargetCPU ()" returns an empty string (instead of crashing) for any CPU that doesn't really need to make a special CPU string.
Removed the "if (is_mips)".
Addressed review comments:
- Rebased this patch off top of tree
- Added ArchSpec::GetClangTargetCPU() as suggested and moved large switch statement into it.
Feb 9 2016
Addresses review comments.
Used local variables instead of calling accessors each time.
Feb 7 2016
Closed by commit http://reviews.llvm.org/rL260072
Feb 4 2016
Closed by commit http://reviews.llvm.org/rL258919
Jan 21 2016
Closed by commit http://reviews.llvm.org/rL258485
Jan 20 2016
As suggested by Greg, added new function matchArchitectures(archs) which handles "archs".
This function can be used by other decorator functions for testing "archs".
Jan 19 2016
Addressed review comments.
Instead of adding new decorator, this patch modifies existing skipUnlessArch to detect the type of the "archs" variable and do the things according to the type.
This handles regular expressions as well.
Jan 18 2016
Hi Greg,
Jan 14 2016
Hi Zachary,
Jan 13 2016
This diff adds a testcase to test this patch.
Jan 12 2016
Closed by commit http://reviews.llvm.org/rL257441
Closed by commit http://reviews.llvm.org/rL257442
Jan 11 2016
Yes, it does fix the issue.
Get the load address for the address given by 'symbol' and 'function'.
Earlier, this was done for 'function' only, this patch does it for 'symbol' too.
Jan 6 2016
Hi Pavel,
Closed by commit http://reviews.llvm.org/rL256915
Jan 5 2016
Dec 23 2015
This was committed on 6th Oct 15 by http://reviews.llvm.org/rL249381 ,closing it now.
Dec 8 2015
Closed by commit http://reviews.llvm.org/rL255005
Dec 7 2015
Nov 1 2015
Hi Sean/Jim
Oct 27 2015
Sep 30 2015
Closed by commit rL246015
Sep 24 2015
Sep 14 2015
Closed by commit rL247666
Sep 11 2015
Aug 25 2015
Addressed review comments.
Aug 19 2015
Aug 13 2015
Closed by Commit rL243091
Committed in revision 245026
Committed in revision 245020
Addresses review comments. (Initialized variables with default values).
Aug 10 2015
Aug 4 2015
Aug 2 2015
Jul 30 2015
Addressed review comments (fixed indentation issues)
Jul 22 2015
Jun 18 2015
Jun 4 2015
Jun 2 2015
Looks good
May 14 2015
Mar 10 2015
This patch implements MIPS64 assembly profiler using EmulateInstruction class.
Feb 19 2015
Thanks jasonmolenda for your review and comments.
I will do the corrections as suggested by you.
My comments are inlined.