Page MenuHomePhabricator

bhushan (Bhushan Attarde)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2015, 12:47 AM (241 w, 1 d)

Recent Activity

Nov 13 2016

bhushan accepted D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet.
Nov 13 2016, 8:40 PM

Sep 30 2016

bhushan added a comment to D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address.

Hi Eugene,

Sep 30 2016, 3:08 AM
bhushan accepted D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS.

Looks good as far as correctness is concerned.

Sep 30 2016, 2:47 AM

Aug 30 2016

bhushan updated subscribers of D23802: gdb-remote: Make the sequence mutex non-recursive.
Aug 30 2016, 3:14 AM

Jul 27 2016

bhushan accepted D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions.

LGTM

Jul 27 2016, 8:22 PM

Jun 9 2016

bhushan accepted D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions.

Looks good.

Jun 9 2016, 3:56 AM

May 26 2016

bhushan updated subscribers of D20671: [cmake] Add a big warning about a libstdc++ issue.
May 26 2016, 3:45 AM

May 19 2016

bhushan accepted D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out.

Looks good.

May 19 2016, 11:40 PM

Mar 15 2016

bhushan closed D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Closed by commit http://reviews.llvm.org/rL261206

Mar 15 2016, 9:09 PM
bhushan added a comment to D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Can you please "accept" this revision so that I can "close" this one?

Mar 15 2016, 2:32 AM

Feb 24 2016

bhushan added a comment to D17535: [LLDB][MIPS] Single step atomic sequences.

In MIPS, we can not put a breakpoint in middle of an atomic sequence.
If we do so (and that breakpoint is hit) then continuing from breakpoint address will cause "SC" to fail due to a breakpoint exception.
SC fails when there’s been any exception serviced since the LL. This will then become a "never ending" sequence.

Feb 24 2016, 4:00 AM

Feb 22 2016

bhushan retitled D17535: [LLDB][MIPS] Single step atomic sequences from to [LLDB][MIPS] Single step atomic sequences.
Feb 22 2016, 9:44 PM
bhushan added a comment to D16139: [MIPS] initFeatureMap() to handle empty string argument.

I'm guessing it's something to do with the 'Features[CPU] = true' line.

Feb 22 2016, 1:43 AM · Restricted Project

Feb 18 2016

bhushan added a comment to D16139: [MIPS] initFeatureMap() to handle empty string argument.

This was observed during expression evaluation in LLDB, where LLDB does not explicitly set clang::TargetOptions::CPU hence it remains empty.

Feb 18 2016, 4:45 AM · Restricted Project

Feb 17 2016

bhushan added a comment to D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Hi Zachary,

Feb 17 2016, 8:44 PM

Feb 16 2016

bhushan added a comment to D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Ok to commit?

Feb 16 2016, 2:22 AM

Feb 11 2016

bhushan updated the diff for D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Removed assert statement so now "ArchSpec::GetClangTargetCPU ()" returns an empty string (instead of crashing) for any CPU that doesn't really need to make a special CPU string.
Removed the "if (is_mips)".

Feb 11 2016, 8:13 PM
bhushan updated the diff for D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Addressed review comments:

  • Rebased this patch off top of tree
  • Added ArchSpec::GetClangTargetCPU() as suggested and moved large switch statement into it.
Feb 11 2016, 3:20 AM

Feb 9 2016

bhushan updated the diff for D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

Addresses review comments.
Used local variables instead of calling accessors each time.

Feb 9 2016, 10:26 PM
bhushan retitled D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS from to [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.
Feb 9 2016, 1:54 AM

Feb 7 2016

bhushan closed D16916: [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS.

Closed by commit http://reviews.llvm.org/rL260072

Feb 7 2016, 8:46 PM

Feb 4 2016

bhushan retitled D16916: [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS from to [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS.
Feb 4 2016, 11:32 PM
bhushan closed D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

Closed by commit http://reviews.llvm.org/rL258919

Feb 4 2016, 11:22 PM

Jan 21 2016

bhushan closed D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation.

Closed by commit http://reviews.llvm.org/rL258485

Jan 21 2016, 9:12 PM

Jan 20 2016

bhushan updated the diff for D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

As suggested by Greg, added new function matchArchitectures(archs) which handles "archs".
This function can be used by other decorator functions for testing "archs".

Jan 20 2016, 1:27 AM

Jan 19 2016

bhushan added a comment to D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation.

That looks fine to me as far as it goes, but it doesn't cover other places where $ is used in function names, e.g. the name of the expression itself, and classes it's placed in. Could you have a look at ExpressionSourceCode.cpp and see if there is anything there that needs a $ as well?

Jan 19 2016, 10:18 PM
bhushan updated the diff for D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

Addressed review comments.
Instead of adding new decorator, this patch modifies existing skipUnlessArch to detect the type of the "archs" variable and do the things according to the type.
This handles regular expressions as well.

Jan 19 2016, 3:08 AM

Jan 18 2016

bhushan added a reviewer for D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation: clayborg.

Hi Greg,

Jan 18 2016, 9:27 AM

Jan 14 2016

bhushan added a comment to D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

Hi Zachary,

If we use @skipIf then the list would require to contain all possible MIPS variations and the list will grow long.
for ex: @skipIf(archs=not_in(['mips32','mips32r2', 'mips32r3', 'mips64','mips64r2', 'mips64r3', 'mips64r6' ......]))

@skipUnlessMips covers all these possible values using regular expression matching.

I agree with Zachary that we have too many decorators and we shouldn't be expanding their number, it's simply not sustainable. I see two options here:

  • add a getMipsArchitectures() function and then write archs=not_in(getMipsArchitectures())
  • add a not_regex() function and write archs=not_regex('mips.*') How does that sound?
Jan 14 2016, 7:58 AM
bhushan updated the diff for D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

Hi Zachary,

Jan 14 2016, 1:54 AM

Jan 13 2016

bhushan retitled D16139: [MIPS] initFeatureMap() to handle empty string argument from to [MIPS] initFeatureMap() to handle empty string argument.
Jan 13 2016, 2:41 AM · Restricted Project
bhushan updated the diff for D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

This diff adds a testcase to test this patch.

Jan 13 2016, 2:32 AM

Jan 12 2016

bhushan closed D16046: [LLDB][MIPS] Handle PIC calling convention for MIPS64 .

Closed by commit http://reviews.llvm.org/rL257441

Jan 12 2016, 7:39 PM
bhushan closed D16051: [LLDB][MIPS] Merge emulation of similar instructions for MIPS64.

Closed by commit http://reviews.llvm.org/rL257442

Jan 12 2016, 7:39 PM

Jan 11 2016

bhushan accepted D16054: [mips] Never select JAL for calls to an absolute immediate address..

Yes, it does fix the issue.

Jan 11 2016, 4:52 AM
bhushan retitled D16051: [LLDB][MIPS] Merge emulation of similar instructions for MIPS64 from to [LLDB][MIPS] Merge emulation of similar instructions for MIPS64.
Jan 11 2016, 1:37 AM
bhushan added a comment to D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.

Get the load address for the address given by 'symbol' and 'function'.
Earlier, this was done for 'function' only, this patch does it for 'symbol' too.

Jan 11 2016, 1:22 AM
bhushan retitled D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS from to [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS.
Jan 11 2016, 1:21 AM
bhushan retitled D16046: [LLDB][MIPS] Handle PIC calling convention for MIPS64 from to [LLDB][MIPS] Handle PIC calling convention for MIPS64 .
Jan 11 2016, 1:00 AM

Jan 6 2016

bhushan added a comment to D15886: [LLDB][MIPS32]Merge emulation of similar instructions.

Hi Pavel,

Jan 6 2016, 4:17 AM
bhushan closed D15886: [LLDB][MIPS32]Merge emulation of similar instructions.

Closed by commit http://reviews.llvm.org/rL256915

Jan 6 2016, 12:21 AM

Jan 5 2016

bhushan retitled D15886: [LLDB][MIPS32]Merge emulation of similar instructions from to [LLDB][MIPS32]Merge emulation of similar instructions.
Jan 5 2016, 2:32 AM

Dec 23 2015

bhushan closed D13282: [MIPS] Emulate microMIPS instructions.

This was committed on 6th Oct 15 by http://reviews.llvm.org/rL249381 ,closing it now.

Dec 23 2015, 9:02 PM

Dec 8 2015

bhushan closed D15273: [LLDB][MIPS] Handle PIC calling convention for MIPS32.

Closed by commit http://reviews.llvm.org/rL255005

Dec 8 2015, 9:34 PM

Dec 7 2015

bhushan retitled D15273: [LLDB][MIPS] Handle PIC calling convention for MIPS32 from to [LLDB][MIPS] Handle PIC calling convention for MIPS32.
Dec 7 2015, 1:23 AM

Nov 1 2015

bhushan added a comment to D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation.

Hi Sean/Jim

Nov 1 2015, 9:15 PM

Oct 27 2015

bhushan retitled D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation from to Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation.
Oct 27 2015, 3:04 AM

Sep 30 2015

bhushan closed D12184: [MIPS] Avoid breakpoint in delay slot.

Closed by commit rL246015

Sep 30 2015, 3:39 AM
bhushan retitled D13282: [MIPS] Emulate microMIPS instructions from to [MIPS] Emulate microMIPS instructions.
Sep 30 2015, 3:00 AM

Sep 24 2015

bhushan retitled D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address from to [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address.
Sep 24 2015, 9:40 PM

Sep 14 2015

bhushan closed D12794: [MIPS] Add support for DT_MIPS_RLD_MAP_REL.

Closed by commit rL247666

Sep 14 2015, 11:24 PM

Sep 11 2015

bhushan retitled D12794: [MIPS] Add support for DT_MIPS_RLD_MAP_REL from to [MIPS] Add support for DT_MIPS_RLD_MAP_REL.
Sep 11 2015, 1:25 AM

Aug 25 2015

bhushan updated the diff for D12184: [MIPS] Avoid breakpoint in delay slot.

Addressed review comments.

Aug 25 2015, 5:02 AM

Aug 19 2015

bhushan retitled D12184: [MIPS] Avoid breakpoint in delay slot from to [MIPS] Avoid breakpoint in delay slot.
Aug 19 2015, 10:46 PM

Aug 13 2015

bhushan closed D11449: Handle old style 'S' packet correctly.

Closed by Commit rL243091

Aug 13 2015, 10:18 PM
bhushan closed D11641: Handle floating point and aggregate return types in SysV-mips64 ABI.

Committed in revision 245026

Aug 13 2015, 9:46 PM
bhushan closed D11930: [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI.

Committed in revision 245020

Aug 13 2015, 8:45 PM
bhushan updated the diff for D11930: [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI.

Addresses review comments. (Initialized variables with default values).

Aug 13 2015, 2:15 AM

Aug 10 2015

bhushan retitled D11930: [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI from to [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI.
Aug 10 2015, 11:20 PM

Aug 4 2015

bhushan added inline comments to D11641: Handle floating point and aggregate return types in SysV-mips64 ABI.
Aug 4 2015, 12:40 AM

Aug 2 2015

bhushan added a reviewer for D11641: Handle floating point and aggregate return types in SysV-mips64 ABI: jingham.
Aug 2 2015, 9:27 PM

Jul 30 2015

bhushan updated the diff for D11641: Handle floating point and aggregate return types in SysV-mips64 ABI.

Addressed review comments (fixed indentation issues)

Jul 30 2015, 9:48 PM
bhushan added inline comments to D11641: Handle floating point and aggregate return types in SysV-mips64 ABI.
Jul 30 2015, 9:45 PM
bhushan retitled D11641: Handle floating point and aggregate return types in SysV-mips64 ABI from to Handle floating point and aggregate return types in SysV-mips64 ABI.
Jul 30 2015, 4:37 AM

Jul 22 2015

bhushan retitled D11449: Handle old style 'S' packet correctly from to Handle old style 'S' packet correctly.
Jul 22 2015, 11:16 PM

Jun 18 2015

bhushan retitled D10534: ABI Plugin for MIPS64 from to ABI Plugin for MIPS64.
Jun 18 2015, 5:50 AM

Jun 4 2015

bhushan retitled D10240: ABI Plugin for MIPS32 from to ABI Plugin for MIPS32.
Jun 4 2015, 5:00 AM

Jun 2 2015

bhushan accepted D10185: Remove implicit write of PC in case of a write to RA in UnwindAssemblyInstEmulation.

Looks good

Jun 2 2015, 10:07 PM

May 14 2015

bhushan retitled D9769: [MIPS] Assembly Profiler for MIPS32 using EmulateInstruction from to [MIPS] Assembly Profiler for MIPS32 using EmulateInstruction.
May 14 2015, 2:50 AM

Mar 10 2015

bhushan updated the diff for D7696: Initial Assembly profiler for mips64.

This patch implements MIPS64 assembly profiler using EmulateInstruction class.

Mar 10 2015, 3:50 AM

Feb 19 2015

bhushan added a comment to D7696: Initial Assembly profiler for mips64.

Thanks jasonmolenda for your review and comments.
I will do the corrections as suggested by you.
My comments are inlined.

Feb 19 2015, 2:21 AM

Feb 17 2015

bhushan retitled D7696: Initial Assembly profiler for mips64 from to Initial Assembly profiler for mips64.
Feb 17 2015, 3:45 AM

Jan 7 2015

bhushan retitled D6861: Adding SoftwareBreakpointTrapOpcode and RelocationJumpSlotType for MIPS from to Adding SoftwareBreakpointTrapOpcode and RelocationJumpSlotType for MIPS.
Jan 7 2015, 2:43 AM