Thank you for this. I am curious, what did you test this on?
I have no experience on MIPS, would you be able to provide some help in case of any breakage?

Apr 13 2017, 10:58 PM

slthakur updated the diff for D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Addressed review comments

Apr 13 2017, 4:44 AM

Apr 7 2017

slthakur created D31803: [scudo] Enabling MIPS support for Scudo.

Apr 7 2017, 1:28 AM

Apr 4 2017

slthakur accepted D31287: [mips] Fix atomic operations at O0, v3.

LGTM

Apr 4 2017, 5:56 AM · Restricted Project

slthakur accepted D31293: [mips] Deal with empty blocks in the mips hazard scheduler.

LGTM

Apr 4 2017, 3:14 AM

slthakur created D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Apr 4 2017, 12:14 AM

Mar 7 2017

slthakur accepted D30640: [mips][msa] Accept more values for constant splats.

LGTM

Mar 7 2017, 6:57 AM

slthakur accepted D30090: [mips] Fix return lowering.

LGTM

Mar 7 2017, 2:31 AM

Mar 6 2017

slthakur updated subscribers of D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.

Mar 6 2017, 10:24 PM

slthakur created D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.

Mar 6 2017, 10:23 PM

Feb 23 2017

slthakur accepted D29984: [mips][mc] Fix a crash when disassembling odd sized sections.

LGTM

Feb 23 2017, 6:12 AM

slthakur accepted D30257: [mips] Fix atomic compare and swap at O0..

LGTM with minor nits.

Feb 23 2017, 4:13 AM

Feb 15 2017

slthakur closed D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Committed in revision 295166.
Thank you all for the review.

Feb 15 2017, 3:10 AM

slthakur closed D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Committed in revision 295164.

Feb 15 2017, 3:10 AM

slthakur committed rL295166: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

[Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el

Feb 15 2017, 3:05 AM

slthakur committed rL295164: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

[LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el

Feb 15 2017, 3:00 AM

slthakur closed D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

Committed in revision 295163

Feb 15 2017, 2:54 AM

slthakur committed rL295163: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

[XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el

Feb 15 2017, 2:53 AM

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Using llvm-readobj instead of llvm-objdump in test xray-section-group.ll

Feb 15 2017, 2:46 AM

slthakur updated the diff for D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

Adding support for mips64/mips64el.

Feb 15 2017, 2:41 AM

Feb 13 2017

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Feb 13 2017, 11:10 PM

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Feb 13 2017, 10:59 PM

slthakur accepted D29887: [mips] divide macro instruction cleanup..

LGTM with minor nits.

Feb 13 2017, 7:13 AM

Jan 25 2017

slthakur accepted D29031: [mips] Add support for static model on N64.

LGTM

Jan 25 2017, 1:38 AM

Jan 23 2017

slthakur added inline comments to D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Jan 23 2017, 4:21 AM

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments

Jan 23 2017, 4:21 AM

Jan 8 2017

slthakur accepted D28373: [mips] Honour -mno-odd-spreg for vector splat.

LGTM

Jan 8 2017, 10:02 PM

Dec 21 2016

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Dec 21 2016, 5:59 AM

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Dec 21 2016, 5:50 AM

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Adding mips64 support for xray along with this change since I have the patch ready.

Dec 21 2016, 1:54 AM

Dec 20 2016

slthakur added a comment to D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

I'm being hit with an llvm assertions when trying to use the integrated assembler about the >function size when not being absolute.

Can you repost the patch with comments addressed, and take a quick look to see if basic sample >programs can be instrumented?

Dec 20 2016, 10:30 PM

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Increased patch context.

Dec 20 2016, 10:26 PM

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments. I've also added mips64 support for xray along with this change since the patch was ready.

Dec 20 2016, 10:18 PM

Dec 14 2016

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Removed patching of instruction "addiu t9, t9, 44" as it was unnecessary since it will always be there at the end of the sled when xray instrumentation is enabled.

Dec 14 2016, 9:23 PM

slthakur updated the diff for D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

Added test for xray attribute support on mips.

Dec 14 2016, 9:06 PM

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Dec 14 2016, 6:10 AM

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments

Dec 14 2016, 6:04 AM

Dec 13 2016

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Added handling of the case where function being instrumented is in a comdat group, as suggested.

Dec 13 2016, 5:36 AM

Dec 12 2016

slthakur retitled D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el from to [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel.

Dec 12 2016, 10:43 PM

slthakur retitled D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el from to [XRAY][MIPS] Add -fxray-instrument for mips/mipsel.

Dec 12 2016, 10:02 PM

slthakur retitled D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el from to [XRAY][MIPS] Support xray on mips/mipsel.

Dec 12 2016, 9:43 PM

Dec 7 2016

slthakur closed D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Committed in rL289027.

Dec 7 2016, 10:42 PM · Restricted Project

slthakur committed rL289027: [MSAN][MIPS] Fix fork.cc test on MIPS.

[MSAN][MIPS] Fix fork.cc test on MIPS

Dec 7 2016, 10:41 PM

slthakur updated the diff for D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Addressed review comments

Dec 7 2016, 10:29 PM · Restricted Project

Dec 6 2016

slthakur added inline comments to D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Dec 6 2016, 1:34 AM · Restricted Project

slthakur updated the diff for D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Addressed review comments

Dec 6 2016, 1:34 AM · Restricted Project

Dec 2 2016

slthakur updated the diff for D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

As suggested, reduced store_context_size to 1 when slow unwinder is being used.

Dec 2 2016, 4:29 AM · Restricted Project

Nov 24 2016

slthakur added a comment to D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

This test is for the ChainedOriginDepotLockAll() logic in msan_interceptors.cc. Could you verify that the fork interceptor is being used on MIPS? I wonder if we need to intercept something else, like vfork.

Nov 24 2016, 3:15 AM · Restricted Project

Nov 23 2016

slthakur added a comment to D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

This test fails on MIPS because many threads are waiting indefinitely on a futex wait. The test pases with reduced number of child processes. Is it okay if we reduce the number of child processes of this test for MIPS?

Nov 23 2016, 5:00 AM · Restricted Project