slthakur (Sagar Thakur)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 13 2014, 3:59 AM (153 w, 1 d)

Recent Activity

Today

slthakur updated the diff for D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.

Addressed review comments and re-synced with TOT.

Thu, Jul 20, 4:58 AM

Tue, Jul 18

slthakur updated the summary of D35555: [MIPS][TSAN] Fix test user_malloc.cc.
Tue, Jul 18, 6:02 AM
slthakur created D35555: [MIPS][TSAN] Fix test user_malloc.cc.
Tue, Jul 18, 5:50 AM

Mon, Jul 17

slthakur accepted D34877: [mips] Implement the 'dins' aliases..

LGTM

Mon, Jul 17, 5:45 AM

Mon, Jul 3

slthakur accepted D34809: [mips] Pick the right variant of DINS upfront and enable target instruction verification.

LGTM

Mon, Jul 3, 7:34 AM
slthakur accepted D34611: [mips][FastISel] Correct the relocation operators for calls & data..

LGTM

Mon, Jul 3, 7:33 AM

Thu, Jun 22

slthakur committed rL306000: Revert [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in….
Revert [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in…
Thu, Jun 22, 5:49 AM
slthakur closed D31803: [scudo] Enabling MIPS support for Scudo.

Committed in revision 305682.
Thanks to Simon for the review and for fixing the build breakage.

Thu, Jun 22, 4:54 AM
slthakur closed D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Committed in revision 305997.

Thu, Jun 22, 4:50 AM
slthakur committed rL305997: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
[mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld
Thu, Jun 22, 4:50 AM

Jun 19 2017

slthakur committed rL305682: [scudo] Enabling MIPS support for Scudo.
[scudo] Enabling MIPS support for Scudo
Jun 19 2017, 4:29 AM
slthakur updated the diff for D31803: [scudo] Enabling MIPS support for Scudo.

Addressed review comments.

Jun 19 2017, 4:24 AM
slthakur accepted D31287: [mips] Fix atomic compare and swap at O0, v2.

LGTM

Jun 19 2017, 3:28 AM

Jun 15 2017

slthakur updated the diff for D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Updated diff with latest TOT.

Jun 15 2017, 11:35 PM

Jun 14 2017

slthakur planned changes to D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
Jun 14 2017, 5:04 AM
slthakur updated the diff for D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Removed unnecessary addend calculation.

Jun 14 2017, 3:47 AM

Jun 13 2017

slthakur added inline comments to D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.
Jun 13 2017, 3:40 AM
slthakur updated the diff for D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.

Addressed review comments. Sorry for the delay.

Jun 13 2017, 3:40 AM

Jun 12 2017

slthakur updated the diff for D31803: [scudo] Enabling MIPS support for Scudo.

Using preprocessor macro _MIPS_SIM in sanitizer_atomic_clang.h as well.

Jun 12 2017, 7:08 AM
slthakur accepted D33494: [mips] Fix multiprecision arithmetic..

LGTM

Jun 12 2017, 4:08 AM
slthakur updated the diff for D31803: [scudo] Enabling MIPS support for Scudo.

Addressed review comments

Jun 12 2017, 3:41 AM

Jun 8 2017

slthakur accepted D33378: [mips] Fix machine verifier errors in the long branch pass.

LGTM

Jun 8 2017, 4:16 AM

May 29 2017

slthakur updated the diff for D31803: [scudo] Enabling MIPS support for Scudo.

Added 64-bit atomic functions for mips32 which are required in sanitizer common.

May 29 2017, 3:03 AM

May 17 2017

slthakur accepted D33131: [compiler-rt][cmake] Build unit tests conditionally with _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE .

LGTM

May 17 2017, 1:33 AM

May 9 2017

slthakur added inline comments to D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
May 9 2017, 2:20 AM
slthakur updated the diff for D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Addressed review comments.

May 9 2017, 2:19 AM

May 4 2017

slthakur accepted D32794: [compiler-rt][mips] Add support for quad precision builtins for mips64.

LGTM

May 4 2017, 4:22 AM

May 3 2017

slthakur accepted D32808: [mips][XRay] Use the base version of emitXRayTable.

LGTM

May 3 2017, 10:59 PM

Apr 26 2017

slthakur added a comment to D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Ping

Apr 26 2017, 5:20 AM
slthakur closed D32286: [mips] Fix test mips64fpldst.ll with machine verifier enabled.

Committed in revision 301394

Apr 26 2017, 4:53 AM
slthakur committed rL301394: [mips] Fix test mips64fpldst.ll with machine verifier enabled.
[mips] Fix test mips64fpldst.ll with machine verifier enabled
Apr 26 2017, 4:53 AM
slthakur abandoned D32074: [mips] Change the machine verifier to allow nested call sequences..
Apr 26 2017, 2:13 AM

Apr 25 2017

slthakur accepted D32004: [mips] Rework a portion of MipsCC interface. (NFC).

LGTM

Apr 25 2017, 5:31 AM
slthakur updated the diff for D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.

Addressed review comments

Apr 25 2017, 5:26 AM

Apr 24 2017

slthakur committed rL301173: Revert [scudo] Enabling MIPS support for Scudo.
Revert [scudo] Enabling MIPS support for Scudo
Apr 24 2017, 4:15 AM
slthakur reopened D31803: [scudo] Enabling MIPS support for Scudo.

Hi Simon,

Apr 24 2017, 3:53 AM

Apr 23 2017

slthakur closed D31803: [scudo] Enabling MIPS support for Scudo.

Committed in revision 301158.

Apr 23 2017, 9:43 PM
slthakur committed rL301158: [scudo] Enabling MIPS support for Scudo.
[scudo] Enabling MIPS support for Scudo
Apr 23 2017, 9:42 PM

Apr 20 2017

slthakur created D32286: [mips] Fix test mips64fpldst.ll with machine verifier enabled.
Apr 20 2017, 4:54 AM

Apr 13 2017

slthakur created D32074: [mips] Change the machine verifier to allow nested call sequences..
Apr 13 2017, 11:22 PM
slthakur added a comment to D31803: [scudo] Enabling MIPS support for Scudo.

Thank you for this. I am curious, what did you test this on?
I have no experience on MIPS, would you be able to provide some help in case of any breakage?

Apr 13 2017, 10:58 PM
slthakur updated the diff for D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.

Addressed review comments

Apr 13 2017, 4:44 AM

Apr 7 2017

slthakur created D31803: [scudo] Enabling MIPS support for Scudo.
Apr 7 2017, 1:28 AM

Apr 4 2017

slthakur accepted D31287: [mips] Fix atomic compare and swap at O0, v2.

LGTM

Apr 4 2017, 5:56 AM
slthakur accepted D31293: [mips] Deal with empty blocks in the mips hazard scheduler.

LGTM

Apr 4 2017, 3:14 AM
slthakur created D31649: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld.
Apr 4 2017, 12:14 AM

Mar 7 2017

slthakur accepted D30640: [mips][msa] Accept more values for constant splats.

LGTM

Mar 7 2017, 6:57 AM
slthakur accepted D30090: [mips] Fix return lowering.

LGTM

Mar 7 2017, 2:31 AM

Mar 6 2017

slthakur updated subscribers of D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.
Mar 6 2017, 10:24 PM
slthakur created D30678: [MIPS] Fix uitofp and fptoui for vector and scalar types.
Mar 6 2017, 10:23 PM

Feb 23 2017

slthakur accepted D29984: [mips][mc] Fix a crash when disassembling odd sized sections.

LGTM

Feb 23 2017, 6:12 AM
slthakur accepted D30257: [mips] Fix atomic compare and swap at O0..

LGTM with minor nits.

Feb 23 2017, 4:13 AM

Feb 15 2017

slthakur closed D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Committed in revision 295166.
Thank you all for the review.

Feb 15 2017, 3:10 AM
slthakur closed D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Committed in revision 295164.

Feb 15 2017, 3:10 AM
slthakur committed rL295166: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.
[Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el
Feb 15 2017, 3:05 AM
slthakur committed rL295164: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.
[LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el
Feb 15 2017, 3:00 AM
slthakur closed D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

Committed in revision 295163

Feb 15 2017, 2:54 AM
slthakur committed rL295163: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.
[XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el
Feb 15 2017, 2:53 AM
slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Using llvm-readobj instead of llvm-objdump in test xray-section-group.ll

Feb 15 2017, 2:46 AM
slthakur updated the diff for D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

Adding support for mips64/mips64el.

Feb 15 2017, 2:41 AM

Feb 13 2017

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Feb 13 2017, 11:10 PM
slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Feb 13 2017, 10:59 PM
slthakur accepted D29887: [mips] divide macro instruction cleanup..

LGTM with minor nits.

Feb 13 2017, 7:13 AM

Jan 25 2017

slthakur accepted D29031: [mips] Add support for static model on N64.

LGTM

Jan 25 2017, 1:38 AM

Jan 23 2017

slthakur added inline comments to D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.
Jan 23 2017, 4:21 AM
slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments

Jan 23 2017, 4:21 AM

Jan 8 2017

slthakur accepted D28373: [mips] Honour -mno-odd-spreg for vector splat.

LGTM

Jan 8 2017, 10:02 PM

Dec 21 2016

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Dec 21 2016, 5:59 AM
slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Dec 21 2016, 5:50 AM
slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Adding mips64 support for xray along with this change since I have the patch ready.

Dec 21 2016, 1:54 AM

Dec 20 2016

slthakur added a comment to D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

I'm being hit with an llvm assertions when trying to use the integrated assembler about the >function size when not being absolute.

Can you repost the patch with comments addressed, and take a quick look to see if basic sample >programs can be instrumented?

Dec 20 2016, 10:30 PM
slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Increased patch context.

Dec 20 2016, 10:26 PM
slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments. I've also added mips64 support for xray along with this change since the patch was ready.

Dec 20 2016, 10:18 PM

Dec 14 2016

slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Removed patching of instruction "addiu t9, t9, 44" as it was unnecessary since it will always be there at the end of the sled when xray instrumentation is enabled.

Dec 14 2016, 9:23 PM
slthakur updated the diff for D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el.

Added test for xray attribute support on mips.

Dec 14 2016, 9:06 PM
slthakur updated the diff for D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments.

Dec 14 2016, 6:10 AM
slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Addressed review comments

Dec 14 2016, 6:04 AM

Dec 13 2016

slthakur updated the diff for D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el.

Added handling of the case where function being instrumented is in a comdat group, as suggested.

Dec 13 2016, 5:36 AM

Dec 12 2016

slthakur retitled D27699: [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el from to [Compiler-rt][XRAY][MIPS] Support xray on mips/mipsel.
Dec 12 2016, 10:43 PM
slthakur retitled D27698: [XRAY][MIPS] Add -fxray-instrument for mips/mipsel/mips64/mips64el from to [XRAY][MIPS] Add -fxray-instrument for mips/mipsel.
Dec 12 2016, 10:02 PM
slthakur retitled D27697: [LLVM][XRAY][MIPS] Support xray on mips/mipsel/mips64/mips64el from to [XRAY][MIPS] Support xray on mips/mipsel.
Dec 12 2016, 9:43 PM

Dec 7 2016

slthakur closed D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Committed in rL289027.

Dec 7 2016, 10:42 PM · Restricted Project
slthakur committed rL289027: [MSAN][MIPS] Fix fork.cc test on MIPS.
[MSAN][MIPS] Fix fork.cc test on MIPS
Dec 7 2016, 10:41 PM
slthakur updated the diff for D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Addressed review comments

Dec 7 2016, 10:29 PM · Restricted Project

Dec 6 2016

slthakur added inline comments to D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.
Dec 6 2016, 1:34 AM · Restricted Project
slthakur updated the diff for D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

Addressed review comments

Dec 6 2016, 1:34 AM · Restricted Project

Dec 2 2016

slthakur updated the diff for D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

As suggested, reduced store_context_size to 1 when slow unwinder is being used.

Dec 2 2016, 4:29 AM · Restricted Project

Nov 24 2016

slthakur added a comment to D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

This test is for the ChainedOriginDepotLockAll() logic in msan_interceptors.cc. Could you verify that the fork interceptor is being used on MIPS? I wonder if we need to intercept something else, like vfork.

Nov 24 2016, 3:15 AM · Restricted Project

Nov 23 2016

slthakur added a comment to D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.

This test fails on MIPS because many threads are waiting indefinitely on a futex wait. The test pases with reduced number of child processes. Is it okay if we reduce the number of child processes of this test for MIPS?

Nov 23 2016, 5:00 AM · Restricted Project

Nov 11 2016

slthakur closed D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64.

Committed revision 286583

Nov 11 2016, 4:15 AM
slthakur committed rL286583: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64.
[MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64
Nov 11 2016, 4:15 AM

Nov 6 2016

slthakur set the repository for D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64 to rL LLVM.
Nov 6 2016, 10:40 PM
slthakur added inline comments to D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64.
Nov 6 2016, 10:40 PM
slthakur updated the diff for D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64.

Removed the restorer field from the kernel sigaction structure for MIPS.

Nov 6 2016, 10:39 PM

Oct 19 2016

slthakur retitled D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64 from to [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64.
Oct 19 2016, 10:48 PM

Oct 6 2016

slthakur committed rL283438: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.
[ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS
Oct 6 2016, 6:30 AM
slthakur committed rL283435: [ESan][MIPS] Adds support for MIPS64.
[ESan][MIPS] Adds support for MIPS64
Oct 6 2016, 6:30 AM
slthakur committed rL283433: [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory….
[EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory…
Oct 6 2016, 6:29 AM
slthakur closed D24332: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.

Committed revision 283438

Oct 6 2016, 3:30 AM · Restricted Project
slthakur closed D23799: [ESan][MIPS] Adds support for MIPS64.

Committed revision 283435

Oct 6 2016, 3:08 AM · Restricted Project