This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] On OS X, exit the forked process gracefully when login_tty fails
ClosedPublic

Authored by kubamracek on May 7 2016, 7:41 AM.

Details

Summary

We're using forkpty to spawn the atos symbolizer. In some cases, login_tty (part of forkpty) can fail due to security measures (sandboxing). In this case, we should exit with a status code instead of completely crashing the spawned process. Even processing a failed CHECK() is problematic here, because we're post-fork and pre-exec where a lot of things don't work (for multithreaded processes, for OS X GUI apps, etc.).

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 56496.May 7 2016, 7:41 AM
kubamracek retitled this revision from to [sanitizer] On OS X, exit the forked process gracefully when login_tty fails.
kubamracek updated this object.
kubamracek added a project: Restricted Project.
dvyukov accepted this revision.May 8 2016, 12:08 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.May 8 2016, 12:08 AM
This revision was automatically updated to reflect the committed changes.