Page MenuHomePhabricator
Differential D18467

Add disk_space() to llvm::fs
ClosedPublic
Actions

Authored by mehdi_amini on Mar 24 2016, 5:17 PM.

Details

Reviewers
bruno
silvas
• rafael
Commits
rG4c82356ad323: Add disk_space() to llvm::fs
rG9defda528e54: Add disk_space() to llvm::fs
rGe2d8f1b8fc42: Add disk_space() to llvm::fs
Summary

Adapted from Boost::filesystem.

Diff Detail

Event Timeline

mehdi_amini updated this revision to Diff 51621.Mar 24 2016, 5:17 PM
mehdi_amini retitled this revision from to Add disk_space() to llvm::fs.
mehdi_amini updated this object.
mehdi_amini added reviewers: bruno, silvas.
mehdi_amini added a subscriber: llvm-commits.
• rafael added a subscriber: • rafael.Mar 25 2016, 9:41 AM

Can you return an ErrorOr or Expected?

mehdi_amini updated this revision to Diff 51720.Mar 26 2016, 12:20 PM

Use ErrorOr in the API

• rafael accepted this revision.Mar 27 2016, 9:41 AM
• rafael added a reviewer: • rafael.

LGTM with nits.

lib/Support/Unix/Path.inc
217

Put STATVFS_F_FRSIZE(Vfs) in a variable. It is used 3 times.

git-clang-format the patch.

lib/Support/Windows/Path.inc
155

Avail, Total, Free.

This revision is now accepted and ready to land.Mar 27 2016, 9:41 AM
aaron.ballman added a subscriber: aaron.ballman.Mar 27 2016, 10:13 AM

Is there a reason we need this API?

mehdi_amini updated this revision to Diff 51745.Mar 27 2016, 11:01 AM
mehdi_amini marked 2 inline comments as done.
mehdi_amini edited edge metadata.

clang-format (note: git clang-format does not run on .inc, I had to trick it)

mehdi_amini updated this revision to Diff 51746.Mar 27 2016, 11:12 AM

Add two notes in the doxygen for Aaron comment (TOUTOC and windows quotas).

ruiu added a subscriber: ruiu.Mar 31 2016, 1:57 PM
ruiu added inline comments.
include/llvm/Support/FileSystem.h
655

"reports reports"

662

const Twine Path -> const Twine &Path?

ruiu added inline comments.Mar 31 2016, 1:58 PM
include/llvm/Support/FileSystem.h
655

Ignore this comment -- I misread it.

mehdi_amini closed this revision.Mar 31 2016, 4:29 PM

r265068 (and r265074 for the Twine reference)

Revision Contents
Changeset List

Diff 51720

View Options

include/llvm/Support/FileSystem.h

Loading...
View Options

lib/Support/Unix/Path.inc

Loading...
View Options

lib/Support/Windows/Path.inc

Loading...