Page MenuHomePhabricator

[OpenMP] Rename the offload entry points.
ClosedPublic

Authored by sfantao on Feb 11 2016, 5:37 PM.

Details

Summary

Unlike other outlined regions in OpenMP, offloading entry points have to have be visible (external linkage) for the device side. Using dots in the names of the entries can be therefore problematic for some toolchains, e.g. NVPTX.

Also the patch drops the column information in the unique name of the entry points. The parsing of directives ignore unknown tokens, preventing several target regions to be implemented in the same line. Therefore, the line information is sufficient for the name to be unique. Also, the preprocessor printer does not preserve the column information, causing offloading-entry detection issues if the host uses an integrated preprocessor and the target doesn't (or vice versa).

Diff Detail

Event Timeline

sfantao updated this revision to Diff 47755.Feb 11 2016, 5:37 PM
sfantao retitled this revision from to [OpenMP] Rename the offload entry points..
sfantao updated this object.
ABataev accepted this revision.Feb 11 2016, 11:38 PM
ABataev edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 11:38 PM
sfantao closed this revision.Feb 13 2016, 3:39 PM