Page MenuHomePhabricator

fraggamuffin (Michael Wong)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2014, 4:27 PM (283 w, 6 d)

Recent Activity

Feb 22 2016

fraggamuffin committed rL261526: [OpenMP] Update 3.8 release notes support for OpenMP .
[OpenMP] Update 3.8 release notes support for OpenMP
Feb 22 2016, 7:03 AM

Feb 21 2016

fraggamuffin updated the diff for D17323: [OpenMP]Update to clang 3.8 ReleaseNotes.rst.

Ok, just adding that the runtime can be built in-tree. I will upstream tonight at 7 pm ET.

Feb 21 2016, 8:28 AM

Feb 17 2016

fraggamuffin updated the diff for D17323: [OpenMP]Update to clang 3.8 ReleaseNotes.rst.
Feb 17 2016, 6:31 AM

Feb 16 2016

fraggamuffin updated the diff for D17323: [OpenMP]Update to clang 3.8 ReleaseNotes.rst.

Fix spelling in dependencies

Feb 16 2016, 7:12 PM
fraggamuffin retitled D17323: [OpenMP]Update to clang 3.8 ReleaseNotes.rst from to [OpenMP]Update to clang 3.8 ReleaseNotes.rst.
Feb 16 2016, 7:06 PM

Dec 29 2015

fraggamuffin updated the diff for D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).

Fixed Comments from Dec 17.

Dec 29 2015, 10:20 AM
fraggamuffin added a comment to D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).

Thanks for the pre-xmas review.

Dec 29 2015, 10:15 AM

Dec 9 2015

fraggamuffin updated the diff for D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).

This is just an interim full diff file of changes accepted so far. I still need to address the attribute and Helper class comment. Thanks.

Dec 9 2015, 8:40 AM
fraggamuffin added a comment to D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).

Michael, please provide full diff log, as described in http://llvm.org/docs/Phabricator.html (with full context)

Dec 9 2015, 8:26 AM

Dec 7 2015

fraggamuffin added a reviewer for D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support): carlo.bertolli.
Dec 7 2015, 6:27 PM
fraggamuffin updated D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).
Dec 7 2015, 6:18 PM
fraggamuffin edited reviewers for D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support), added: ABataev, hfinkel, rsmith, kkwli0, sfantao; removed: cfe-commits.
Dec 7 2015, 6:17 PM
fraggamuffin retitled D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support) from to [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).
Dec 7 2015, 6:15 PM

Aug 28 2015

fraggamuffin committed rL246299: Updating with 2 more contributors.
Updating with 2 more contributors
Aug 28 2015, 6:57 AM

Aug 24 2015

fraggamuffin added a comment to D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct..

Got it. Test results look good with this patch.

Expected Passes    : 7011
Expected Failures  : 21
Unsupported Tests  : 89
Unexpected Failures: 47
Aug 24 2015, 9:46 AM
fraggamuffin committed rL245845: Update CREDITS.TXT with Clang OpenMP implementation + test suite contributors….
Update CREDITS.TXT with Clang OpenMP implementation + test suite contributors…
Aug 24 2015, 7:51 AM

Aug 20 2015

fraggamuffin added a comment to D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct..
Aug 20 2015, 8:40 AM

Aug 10 2015

fraggamuffin added a comment to D11475: [OPENMP] fix the assert in emitting captured code inside the target data construct.

This patch has landed.
Commit
C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp
C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp
At revision: 244569

Aug 10 2015, 9:53 PM
fraggamuffin committed rL244569: This patch fixes the assert in emitting captured code in the target data….
This patch fixes the assert in emitting captured code in the target data…
Aug 10 2015, 9:52 PM

Aug 7 2015

fraggamuffin added a comment to D11469: [OPENMP] Parsing and sema support for device clause.

This has landed.
Commit
C:\llvmtrunk\tools\clang\include\clang\AST\DataRecursiveASTVisitor.h
C:\llvmtrunk\tools\clang\include\clang\AST\OpenMPClause.h
C:\llvmtrunk\tools\clang\include\clang\AST\RecursiveASTVisitor.h
C:\llvmtrunk\tools\clang\include\clang\Basic\OpenMPKinds.def
C:\llvmtrunk\tools\clang\include\clang\Sema\Sema.h
C:\llvmtrunk\tools\clang\lib\AST\StmtPrinter.cpp
C:\llvmtrunk\tools\clang\lib\AST\StmtProfile.cpp
C:\llvmtrunk\tools\clang\lib\Basic\OpenMPKinds.cpp
C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp
C:\llvmtrunk\tools\clang\lib\Parse\ParseOpenMP.cpp
C:\llvmtrunk\tools\clang\lib\Sema\SemaOpenMP.cpp
C:\llvmtrunk\tools\clang\lib\Sema\TreeTransform.h
C:\llvmtrunk\tools\clang\lib\Serialization\ASTReaderStmt.cpp
C:\llvmtrunk\tools\clang\lib\Serialization\ASTWriterStmt.cpp
C:\llvmtrunk\tools\clang\test\OpenMP\target_data_device_messages.cpp
C:\llvmtrunk\tools\clang\test\OpenMP\target_device_messages.cpp
C:\llvmtrunk\tools\clang\tools\libclang\CIndex.cpp
C:\llvmtrunk\tools\clang\lib\Serialization\ASTReaderStmt.cpp
C:\llvmtrunk\tools\clang\lib\AST\StmtProfile.cpp
C:\llvmtrunk\tools\clang\test\OpenMP\target_device_messages.cpp
C:\llvmtrunk\tools\clang\lib\Parse\ParseOpenMP.cpp
C:\llvmtrunk\tools\clang\lib\Basic\OpenMPKinds.cpp
C:\llvmtrunk\tools\clang\lib\Serialization\ASTWriterStmt.cpp
C:\llvmtrunk\tools\clang\tools\libclang\CIndex.cpp
C:\llvmtrunk\tools\clang\include\clang\Sema\Sema.h
C:\llvmtrunk\tools\clang\lib\AST\StmtPrinter.cpp
C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp
C:\llvmtrunk\tools\clang\lib\Sema\TreeTransform.h
C:\llvmtrunk\tools\clang\include\clang\Basic\OpenMPKinds.def
C:\llvmtrunk\tools\clang\include\clang\AST\DataRecursiveASTVisitor.h
C:\llvmtrunk\tools\clang\include\clang\AST\OpenMPClause.h
C:\llvmtrunk\tools\clang\lib\Sema\SemaOpenMP.cpp
C:\llvmtrunk\tools\clang\test\OpenMP\target_data_device_messages.cpp
C:\llvmtrunk\tools\clang\include\clang\AST\RecursiveASTVisitor.h
At revision: 244325

Aug 7 2015, 9:19 AM
fraggamuffin committed rL244325: This patch commits OpenMP 4 target device clauses.
This patch commits OpenMP 4 target device clauses
Aug 7 2015, 9:17 AM

Aug 3 2015

fraggamuffin added a comment to D11469: [OPENMP] Parsing and sema support for device clause.

Got it.

Aug 3 2015, 6:50 AM

Jul 31 2015

fraggamuffin added a comment to D11469: [OPENMP] Parsing and sema support for device clause.

In ParseOpenMP.cpp, it failed the patch because OMPC_ordered was already added before OMPC_device. But it does not affect the patch if we add it after this.

Jul 31 2015, 6:33 PM

Jul 22 2015

fraggamuffin added a comment to D11059: [OPENMP] Info in release notes about OpenMP support in clang..

+Jopnathan Peyton

Jul 22 2015, 6:21 PM
fraggamuffin added a comment to D11059: [OPENMP] Info in release notes about OpenMP support in clang..

OK sounds good.

Jul 22 2015, 6:02 AM

Jul 21 2015

fraggamuffin added a comment to D11059: [OPENMP] Info in release notes about OpenMP support in clang..

Suggest we modify to:

OpenMP Support

Clang 3.7 fully supports OpenMP 3.1 and reported to work on several platforms,
including x86, x86-64 and Power.

Jul 21 2015, 9:52 AM
fraggamuffin added a comment to D10765: [OPENMP] Parsing and sema support for #pragma omp target data" directive..

This has been committed for Kelvin Li.

Jul 21 2015, 6:46 AM
fraggamuffin committed rL242785: Commit for http://reviews.llvm.org/D10765.
Commit for http://reviews.llvm.org/D10765
Jul 21 2015, 6:45 AM

Jun 4 2015

fraggamuffin added a comment to D10233: [Concepts] lex keywords: concept and requires.

This looks fine to me. Just one question: since we are setting -std=c++14,
is there no define for -DCXX14 instead of having to set -DCXX11? If this is
clang policy, then LGTM, otherwise, why are we not adding a define for
C++14?

Jun 4 2015, 6:23 AM

Feb 24 2015

fraggamuffin added a comment to D7559: Fix sign of wide character literals in preprocessor conditions.

Commit
D:\llvmtrunk\tools\clang\lib\Lex\PPExpressions.cpp
D:\llvmtrunk\tools\clang\test\Preprocessor\pr19649-signed-wchar_t.c
D:\llvmtrunk\tools\clang\test\Preprocessor\pr19649-unsigned-wchar_t.c
At revision: 230333

Feb 24 2015, 5:37 AM
fraggamuffin committed rL230333: Commit patch for PR19649. Set the correct sign of wide character for literals….
Commit patch for PR19649. Set the correct sign of wide character for literals…
Feb 24 2015, 5:36 AM

Feb 22 2015

fraggamuffin added a comment to D7559: Fix sign of wide character literals in preprocessor conditions.

Thanks, I will commit this on behalf of Rachel.

Feb 22 2015, 6:56 PM

Feb 17 2015

fraggamuffin added a comment to D7559: Fix sign of wide character literals in preprocessor conditions.

We have reviewed this internally in IBM and it looks fine. We like to have someone externally review it as well. Thanks.

Feb 17 2015, 10:23 AM

Feb 9 2015

fraggamuffin committed rL228569: update with Clang OpenMP release notes for 3.6 by Michael Wong.
update with Clang OpenMP release notes for 3.6 by Michael Wong
Feb 9 2015, 12:39 AM

Jun 25 2014

fraggamuffin added a comment to D4002: [OPENMP] Codegen for threadprivate variables.

Builds fine. Change looks OK, but as this is codegen, will need more
established eyes like Hal.

Jun 25 2014, 2:47 AM

Jun 18 2014

fraggamuffin added a comment to D4002: [OPENMP] Codegen for threadprivate variables.

I kept getting an error in the build, which is directly traced back to this
change:
llvm[4]: Compiling CGDeclCXX.cpp for Debug+Asserts build
/nfs/terran/home/michaelw/clang-dev-new/llvm/tools/clang/lib/CodeGen/CGDeclCXX.cpp:
In member function 'void
clang::CodeGen::CodeGenModule::EmitCXXOMPThreadPrivateInitFunction(const
clang::VarDecl&, llvm::Constant*, bool, bool)':
/nfs/terran/home/michaelw/clang-dev-new/llvm/tools/clang/lib/CodeGen/CGDeclCXX.cpp:600:60:
error: no matching function for call to
'llvm::FunctionType::get(llvm::PointerType*&, <brace-enclosed initializer
list>, bool)'

/*isVarArg*/

false)->getPointerTo();

^

/nfs/terran/home/michaelw/clang-dev-new/llvm/tools/clang/lib/CodeGen/CGDeclCXX.cpp:600:60:
note: candidates are:
In file included from
/nfs/terran/home/michaelw/clang-dev-new/llvm/include/llvm/IR/Constants.h:28:0,

from

/nfs/terran/home/michaelw/clang-dev-new/llvm/include/llvm/IR/ConstantFolder.h:20,

from

/nfs/terran/home/michaelw/clang-dev-new/llvm/include/llvm/IR/IRBuilder.h:22,

from

/nfs/terran/home/michaelw/clang-dev-new/llvm/tools/clang/lib/CodeGen/CGBuilder.h:13,

from

/nfs/terran/home/michaelw/clang-dev-new/llvm/tools/clang/lib/CodeGen/CodeGenFunction.h:17,

from

/nfs/terran/home/michaelw/clang-dev-new/llvm/tools/clang/lib/CodeGen/CGDeclCXX.cpp:14:
/nfs/terran/home/michaelw/clang-dev-new/llvm/include/llvm/IR/DerivedTypes.h:105:24:
note: static llvm::FunctionType* llvm::FunctionType::get(llvm::Type*,
llvm::ArrayRef<llvm::Type*>, bool)

static FunctionType *get(Type *Result,
                     ^

/nfs/terran/home/michaelw/clang-dev-new/llvm/include/llvm/IR/DerivedTypes.h:105:24:
note: no known conversion for argument 2 from '<brace-enclosed
initializer list>' to 'llvm::ArrayRef<llvm::Type*>'

Jun 18 2014, 2:31 AM