Page MenuHomePhabricator

Add icmp and conditional branches in the C API echo test.
ClosedPublic

Authored by deadalnix on Feb 5 2016, 2:50 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

deadalnix updated this revision to Diff 47055.Feb 5 2016, 2:50 PM
deadalnix retitled this revision from to Add icmp and conditional branches in the C API echo test..
deadalnix updated this object.
deadalnix added a subscriber: llvm-commits.
deadalnix updated this revision to Diff 47070.Feb 5 2016, 6:07 PM

Test all predicates

mehdi_amini added inline comments.Feb 9 2016, 2:24 PM
tools/llvm-c-test/echo.cpp
230 ↗(On Diff #47070)

It seems to me that "Then" and "Else" are reversed?

deadalnix added inline comments.Feb 9 2016, 2:44 PM
tools/llvm-c-test/echo.cpp
230 ↗(On Diff #47070)

I was surprized by this to when making that diff, but it looks like it is this way.

mehdi_amini accepted this revision.Feb 9 2016, 3:10 PM
mehdi_amini edited edge metadata.

LGTM, it seems I'll have to be bitten by the reversed branch target more and more...

This revision is now accepted and ready to land.Feb 9 2016, 3:10 PM
This revision was automatically updated to reflect the committed changes.