This is an archive of the discontinued LLVM Phabricator instance.

Update cmake build on recent Haiku
AbandonedPublic

Authored by korli on Feb 1 2016, 11:22 PM.

Details

Summary

[Copied from [ https://llvm.org/bugs/show_bug.cgi?id=26405 | https://llvm.org/bugs/show_bug.cgi?id=26405 ]

cmake build support on Haiku is lagging a bit.

This patch updates cmake build scripts to build on Haiku. It updates config.guess to a newer version which recognizes Haiku x86_64.
It should apply directly to trunk, please consider reviewing.

Diff Detail

Repository
rL LLVM

Event Timeline

korli updated this revision to Diff 46616.Feb 1 2016, 11:22 PM
korli retitled this revision from to Update cmake build on recent Haiku.
korli updated this object.
korli added a reviewer: chandlerc.
korli set the repository for this revision to rL LLVM.
korli added a subscriber: llvm-commits.
ehsan resigned from this revision.Feb 24 2016, 6:57 AM
ehsan removed a reviewer: ehsan.

I'm afraid I'm not a good reviewer for this. Sorry!

beanz requested changes to this revision.Feb 24 2016, 8:24 AM
beanz edited edge metadata.

I'm sorry we cannot accept this patch. The updates to config.guess involve taking a new version of the script that is licensed under GPLv3. We cannot accept GPLv3 code into LLVM without at least a larger discussion on LLVM-dev about it.

It is my belief that GPLv3 is incompatible with some of the goals of the LLVM project. Specifically the creation of a permissive-licensed open-source compiler.

This revision now requires changes to proceed.Feb 24 2016, 8:24 AM
rengolin added inline comments.
cmake/config.guess
1209

This seems to be the *only* change that is needed in this file. We can't take the GPLv3 version of config.guess, but we can take this change into our old version.

rengolin requested changes to this revision.Feb 24 2016, 9:27 AM
rengolin added a reviewer: rengolin.

Please, abandon this patch, ignore every change to config.guess, only add the three lines you need for your case, and re-submit as a new revision. Also, add Chris Lattner to the review, because this is a sensitive issue.

We have precedent for that kind of change (r202125), so without the GPLv3 stuff, it should be fine. But you still need explicit approval for this change.

cheers,
--renato

Please, abandon this patch, ignore every change to config.guess, only add the three lines you need for your case, and re-submit as a new revision. Also, add Chris Lattner to the review, because this is a sensitive issue.

We have precedent for that kind of change (r202125), so without the GPLv3 stuff, it should be fine. But you still need explicit approval for this change.

Thanks. I re-submitted as revision D17595 with new patch. Though I have no idea what Chris Lattner phab account is :/

Bye,
Jerome

korli abandoned this revision.Feb 25 2016, 7:51 AM