This is an archive of the discontinued LLVM Phabricator instance.

DWARF RenderScript vendor extension
ClosedPublic

Authored by EwanCrawford on Jan 21 2016, 8:19 AM.

Download Raw Diff

Details

Reviewers

echristo
dexonsmith

Commits

rG588980d69e40: DWARF RenderScript vendor extension
rL259348: DWARF RenderScript vendor extension

Summary

Patch adds a DWARF language vendor extension for RenderScript.
We are already using this identifier in LLDB with a hard coded value, so it would be good to get it in LLVM and use the generated enum.

Diff Detail

Repository: rL LLVM

Event Timeline

EwanCrawford updated this revision to Diff 45534.Jan 21 2016, 8:19 AM

EwanCrawford retitled this revision from to DWARF RenderScript vendor extension .

EwanCrawford updated this object.

EwanCrawford added reviewers: echristo, dexonsmith.

EwanCrawford set the repository for this revision to rL LLVM.

EwanCrawford added subscribers: llvm-commits, srhines, domipheus.

OK. If you're serious about wanting this though we should get it into the
dwarf standard though.

In D16409#332524, @echristo wrote:

OK. If you're serious about wanting this though we should get it into the
dwarf standard though.

I think that Ewan already applied for this to be included in the next revision. He can confirm that when he is back online.

probinson added a subscriber: probinson.Jan 21 2016, 4:26 PM

probinson added inline comments.

include/llvm/Support/Dwarf.def
323	Symbols for vendor extensions ought to have a prefix identifying the vendor. Among other things, you don't want to conflict with whatever symbol the DWARF committee comes up with for the "standard" value, if we define one.

Thanks for taking a look.

We applied for the RenderScript DW_LANG constant to be added to the DWARF standard back in March.

The feedback was that since we'd missed the version 5 submission deadline to use a vendor extension
until it could be added to a following version of the standard.

Since that was a while ago however we'll chase that up.

In D16409#333388, @EwanCrawford wrote:

Thanks for taking a look.

We applied for the RenderScript DW_LANG constant to be added to the DWARF standard back in March.

The feedback was that since we'd missed the version 5 submission deadline to use a vendor extension
until it could be added to a following version of the standard.

Since that was a while ago however we'll chase that up.

Yes please, I'm not seeing it in the DWARF issues list.

Search fail then as I must have missed the mail. Did you put a proposal in
on dwarfstd.org? Either way, following up would be great.

-eric

The request was indeed put through dwarfstd.org, but apparently there was a problem with the notifications.
Up now though, please see http://www.dwarfstd.org/ShowIssue.php?issue=150331.1

LGTM.

And yes, I saw the mail finally come across the dwarf list with the website problems mentioned.

Thanks!

-eric

This revision is now accepted and ready to land.Jan 29 2016, 3:25 PM

Closed by commit rL259348: DWARF RenderScript vendor extension (authored by EwanCrawford). · Explain WhyFeb 1 2016, 2:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

include/

llvm/

Support/

Dwarf.def

1 line

Diff 45534

include/llvm/Support/Dwarf.def

	Show First 20 Lines • Show All 314 Lines • ▼ Show 20 Lines
	HANDLE_DW_LANG(0x001d, C11)			HANDLE_DW_LANG(0x001d, C11)
	HANDLE_DW_LANG(0x001e, Swift)			HANDLE_DW_LANG(0x001e, Swift)
	HANDLE_DW_LANG(0x001f, Julia)			HANDLE_DW_LANG(0x001f, Julia)
	HANDLE_DW_LANG(0x0020, Dylan)			HANDLE_DW_LANG(0x0020, Dylan)
	HANDLE_DW_LANG(0x0021, C_plus_plus_14)			HANDLE_DW_LANG(0x0021, C_plus_plus_14)
	HANDLE_DW_LANG(0x0022, Fortran03)			HANDLE_DW_LANG(0x0022, Fortran03)
	HANDLE_DW_LANG(0x0023, Fortran08)			HANDLE_DW_LANG(0x0023, Fortran08)
	HANDLE_DW_LANG(0x8001, Mips_Assembler)			HANDLE_DW_LANG(0x8001, Mips_Assembler)
				HANDLE_DW_LANG(0x8e57, RenderScript)
				probinsonUnsubmitted Not Done Reply Inline Actions Symbols for vendor extensions ought to have a prefix identifying the vendor. Among other things, you don't want to conflict with whatever symbol the DWARF committee comes up with for the "standard" value, if we define one. probinson: Symbols for vendor extensions ought to have a prefix identifying the vendor. Among other…
	HANDLE_DW_LANG(0xb000, BORLAND_Delphi)			HANDLE_DW_LANG(0xb000, BORLAND_Delphi)

	// DWARF attribute type encodings.			// DWARF attribute type encodings.
	HANDLE_DW_ATE(0x01, address)			HANDLE_DW_ATE(0x01, address)
	HANDLE_DW_ATE(0x02, boolean)			HANDLE_DW_ATE(0x02, boolean)
	HANDLE_DW_ATE(0x03, complex_float)			HANDLE_DW_ATE(0x03, complex_float)
	HANDLE_DW_ATE(0x04, float)			HANDLE_DW_ATE(0x04, float)
	HANDLE_DW_ATE(0x05, signed)			HANDLE_DW_ATE(0x05, signed)
	Show All 22 Lines