Page MenuHomePhabricator

DWARF RenderScript vendor extension
ClosedPublic

Authored by EwanCrawford on Jan 21 2016, 8:19 AM.

Details

Summary

Patch adds a DWARF language vendor extension for RenderScript.
We are already using this identifier in LLDB with a hard coded value, so it would be good to get it in LLVM and use the generated enum.

Diff Detail

Repository
rL LLVM

Event Timeline

EwanCrawford retitled this revision from to DWARF RenderScript vendor extension .
EwanCrawford updated this object.
EwanCrawford added reviewers: echristo, dexonsmith.
EwanCrawford set the repository for this revision to rL LLVM.
echristo edited edge metadata.Jan 21 2016, 10:19 AM
echristo added a subscriber: echristo.

OK. If you're serious about wanting this though we should get it into the
dwarf standard though.

OK. If you're serious about wanting this though we should get it into the
dwarf standard though.

I think that Ewan already applied for this to be included in the next revision. He can confirm that when he is back online.

probinson added inline comments.
include/llvm/Support/Dwarf.def
323 ↗(On Diff #45534)

Symbols for vendor extensions ought to have a prefix identifying the vendor. Among other things, you don't want to conflict with whatever symbol the DWARF committee comes up with for the "standard" value, if we define one.

EwanCrawford edited edge metadata.

Thanks for taking a look.

We applied for the RenderScript DW_LANG constant to be added to the DWARF standard back in March.

The feedback was that since we'd missed the version 5 submission deadline to use a vendor extension
until it could be added to a following version of the standard.

Since that was a while ago however we'll chase that up.

Thanks for taking a look.

We applied for the RenderScript DW_LANG constant to be added to the DWARF standard back in March.

The feedback was that since we'd missed the version 5 submission deadline to use a vendor extension
until it could be added to a following version of the standard.

Since that was a while ago however we'll chase that up.

Yes please, I'm not seeing it in the DWARF issues list.

Search fail then as I must have missed the mail. Did you put a proposal in
on dwarfstd.org? Either way, following up would be great.

-eric

The request was indeed put through dwarfstd.org, but apparently there was a problem with the notifications.
Up now though, please see http://www.dwarfstd.org/ShowIssue.php?issue=150331.1

echristo accepted this revision.Jan 29 2016, 3:25 PM
echristo edited edge metadata.

LGTM.

And yes, I saw the mail finally come across the dwarf list with the website problems mentioned.

Thanks!

-eric

This revision is now accepted and ready to land.Jan 29 2016, 3:25 PM
This revision was automatically updated to reflect the committed changes.