Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People EwanCrawford

EwanCrawford (Ewan Crawford)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2014, 10:20 AM (458 w, 4 d)

Recent Activity
View All

Oct 7 2019

EwanCrawford closed D17719: Track expression language from one place in ClangExpressionParser.
Oct 7 2019, 7:09 AM · Restricted Project

Sep 23 2019

EwanCrawford removed a watcher for debug-info: EwanCrawford.
Sep 23 2019, 1:17 AM

Oct 8 2018

EwanCrawford committed rL343956: [InstCombine] Fix incongruous GEP type addrspace.
[InstCombine] Fix incongruous GEP type addrspace
Oct 8 2018, 1:42 AM
EwanCrawford closed D52294: [InstCombine] Fix incongruous GEP type addrspace .
Oct 8 2018, 1:42 AM

Oct 5 2018

EwanCrawford updated the diff for D52294: [InstCombine] Fix incongruous GEP type addrspace .

done, thanks again

Oct 5 2018, 6:00 AM

Oct 4 2018

EwanCrawford updated the diff for D52294: [InstCombine] Fix incongruous GEP type addrspace .

Thanks for the feedback @spatel.
I've modified the test according to your suggestions and added a check to the verifier which fires without the instcombine change.

Oct 4 2018, 3:24 AM

Sep 28 2018

EwanCrawford added a comment to D52294: [InstCombine] Fix incongruous GEP type addrspace .

ping

Sep 28 2018, 2:22 AM

Sep 21 2018

EwanCrawford added inline comments to D52294: [InstCombine] Fix incongruous GEP type addrspace .
Sep 21 2018, 2:31 AM

Sep 20 2018

EwanCrawford created D52294: [InstCombine] Fix incongruous GEP type addrspace .
Sep 20 2018, 3:07 AM

Jul 31 2018

EwanCrawford committed rL338395: Fix InstCombine address space assert.
Fix InstCombine address space assert
Jul 31 2018, 8:53 AM
EwanCrawford closed D50058: Fix InstCombine address space assert.
Jul 31 2018, 8:53 AM
EwanCrawford updated the diff for D50058: Fix InstCombine address space assert.

Thanks for taking a look @spatel, updated the test using generate script.

Jul 31 2018, 8:25 AM
EwanCrawford created D50058: Fix InstCombine address space assert.
Jul 31 2018, 6:09 AM

Feb 4 2018

EwanCrawford added a watcher for debug-info: EwanCrawford.
Feb 4 2018, 7:51 AM

Dec 4 2017

EwanCrawford added inline comments to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].
Dec 4 2017, 4:33 AM · debug-info
EwanCrawford added inline comments to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].
Dec 4 2017, 4:27 AM · debug-info

Aug 3 2017

EwanCrawford committed rL309928: [Cloning] Move distinct GlobalVariable debug info metadata in CloneModule.
[Cloning] Move distinct GlobalVariable debug info metadata in CloneModule
Aug 3 2017, 2:23 AM
EwanCrawford closed D36082: [Cloning] Move distinct GlobalVariable debug info metadata in CloneModule by committing rL309928: [Cloning] Move distinct GlobalVariable debug info metadata in CloneModule.
Aug 3 2017, 2:23 AM · Restricted Project

Aug 2 2017

EwanCrawford updated the diff for D36082: [Cloning] Move distinct GlobalVariable debug info metadata in CloneModule .

Thanks for taking a look Adrian, I think the DIGlobalVariables being accessible via two routes is indeed the reason for this.

Aug 2 2017, 2:19 AM · Restricted Project

Jul 31 2017

EwanCrawford created D36082: [Cloning] Move distinct GlobalVariable debug info metadata in CloneModule .
Jul 31 2017, 4:04 AM · Restricted Project

Nov 29 2016

EwanCrawford abandoned D17957: Expression evaluation for overloaded C functions.

Abandoning this patch since it's out of date, and @ldrumm has an alternative fix he's about to post

Nov 29 2016, 10:13 AM

Jul 12 2016

EwanCrawford abandoned D15116: Fix for evaluating a function with an ambiguous symbol .

Thanks for getting around to looking at this Sean, i'd forgotten about it.
Unfortunately the patch seems to have gone stale as the test case no longer passes.
So i'm just going to close the review for now.

Jul 12 2016, 4:49 AM

Mar 21 2016

EwanCrawford updated the diff for D17957: Expression evaluation for overloaded C functions.

Rebased on tip

Mar 21 2016, 9:51 AM

Mar 15 2016

EwanCrawford committed rL263547: Add regression test for expressions calling functions taking anonymous struct….
Add regression test for expressions calling functions taking anonymous struct…
Mar 15 2016, 6:07 AM
EwanCrawford closed D17777: Add regression test for expressions calling functions taking anonymous struct typedef arguments by committing rL263547: Add regression test for expressions calling functions taking anonymous struct….
Mar 15 2016, 6:07 AM
EwanCrawford committed rL263544: Fix expression evaluation for resolving anonymous aggregrate types with a….
Fix expression evaluation for resolving anonymous aggregrate types with a…
Mar 15 2016, 2:55 AM
EwanCrawford closed D18099: Fix expression evaluation for resolving anonymous aggregrate types with a typedefed name by committing rL263544: Fix expression evaluation for resolving anonymous aggregrate types with a….
Mar 15 2016, 2:55 AM

Mar 14 2016

EwanCrawford added inline comments to D17957: Expression evaluation for overloaded C functions.
Mar 14 2016, 10:10 AM
EwanCrawford updated the diff for D17957: Expression evaluation for overloaded C functions.

Thanks for taking a look Sean.

Mar 14 2016, 8:22 AM

Mar 11 2016

EwanCrawford added a comment to D17957: Expression evaluation for overloaded C functions.

friendly ping

Mar 11 2016, 2:12 AM

Mar 10 2016

EwanCrawford committed rL263107: Revert "Track expression language from one place in ClangExpressionParser".
Revert "Track expression language from one place in ClangExpressionParser"
Mar 10 2016, 4:43 AM
EwanCrawford committed rL263099: Track expression language from one place in ClangExpressionParser.
Track expression language from one place in ClangExpressionParser
Mar 10 2016, 2:36 AM
EwanCrawford closed D17719: Track expression language from one place in ClangExpressionParser by committing rL263099: Track expression language from one place in ClangExpressionParser.
Mar 10 2016, 2:36 AM · Restricted Project

Mar 8 2016

EwanCrawford retitled D17957: Expression evaluation for overloaded C functions from to Expression evaluation for overloaded C functions.
Mar 8 2016, 4:03 AM
EwanCrawford committed rL262920: Use c_str() instead of GetCString() to fix build .
Use c_str() instead of GetCString() to fix build
Mar 8 2016, 2:08 AM

Feb 19 2016

EwanCrawford committed rL261345: refactor/cleanup ClangExpressionParser::Parse.
refactor/cleanup ClangExpressionParser::Parse
Feb 19 2016, 9:59 AM
EwanCrawford closed D17273: refactor/cleanup ClangExpressionParser::Parse by committing rL261345: refactor/cleanup ClangExpressionParser::Parse.
Feb 19 2016, 9:59 AM
EwanCrawford committed rL261328: Delete unused function in ClangExpressionParser.
Delete unused function in ClangExpressionParser
Feb 19 2016, 6:36 AM
EwanCrawford closed D17266: delete unused function in ClangExpressionParser` by committing rL261328: Delete unused function in ClangExpressionParser.
Feb 19 2016, 6:36 AM

Feb 18 2016

EwanCrawford committed rL261227: Fix OSX cmake build.
Fix OSX cmake build
Feb 18 2016, 9:06 AM
EwanCrawford closed D17384: Fix OSX cmake build by committing rL261227: Fix OSX cmake build.
Feb 18 2016, 9:06 AM
EwanCrawford retitled D17384: Fix OSX cmake build from to Fix OSX cmake build.
Feb 18 2016, 8:36 AM

Feb 16 2016

EwanCrawford added a comment to D16853: Use BKPT instead of UDF for arm/thumb breakpoints.

Hi Tamas,

Feb 16 2016, 2:39 AM

Feb 10 2016

EwanCrawford committed rL260372: [RenderScript] Refactor allocation expressions .
[RenderScript] Refactor allocation expressions
Feb 10 2016, 3:27 AM

Feb 4 2016

EwanCrawford committed rL259773: [RenderScript] Add command for recalculating allocation details.
[RenderScript] Add command for recalculating allocation details
Feb 4 2016, 1:48 AM

Feb 3 2016

EwanCrawford committed rL259634: [RenderScript] Use LLVM DWARF language enum.
[RenderScript] Use LLVM DWARF language enum
Feb 3 2016, 1:21 AM
EwanCrawford closed D16766: [RenderScript] Use LLVM DWARF language enum by committing rL259634: [RenderScript] Use LLVM DWARF language enum.
Feb 3 2016, 1:21 AM

Feb 2 2016

EwanCrawford updated the diff for D16766: [RenderScript] Use LLVM DWARF language enum.

Thanks for taking a look, yes I want to use ClangASTContext.
Although RenderScript is mostly just C99 checking for it in a function called LanguageIsC does seem off.

Feb 2 2016, 8:28 AM

Feb 1 2016

EwanCrawford retitled D16766: [RenderScript] Use LLVM DWARF language enum from to [RenderScript] Use LLVM DWARF language enum.
Feb 1 2016, 3:50 AM
EwanCrawford committed rL259348: DWARF RenderScript vendor extension.
DWARF RenderScript vendor extension
Feb 1 2016, 2:43 AM
EwanCrawford closed D16409: DWARF RenderScript vendor extension by committing rL259348: DWARF RenderScript vendor extension.
Feb 1 2016, 2:43 AM

Jan 29 2016

EwanCrawford added a comment to D16409: DWARF RenderScript vendor extension .

The request was indeed put through dwarfstd.org, but apparently there was a problem with the notifications.
Up now though, please see http://www.dwarfstd.org/ShowIssue.php?issue=150331.1

Jan 29 2016, 3:08 AM
EwanCrawford committed rL259181: [RenderScript] Remove unused RS command.
[RenderScript] Remove unused RS command
Jan 29 2016, 2:15 AM

Jan 26 2016

EwanCrawford committed rL258800: [RenderScript] Provide option to specify a single allocation to print.
[RenderScript] Provide option to specify a single allocation to print
Jan 26 2016, 2:45 AM

Jan 22 2016

EwanCrawford updated the diff for D16409: DWARF RenderScript vendor extension .

Thanks for taking a look.

Jan 22 2016, 2:48 AM

Jan 21 2016

EwanCrawford retitled D16409: DWARF RenderScript vendor extension from to DWARF RenderScript vendor extension .
Jan 21 2016, 8:19 AM

Jan 20 2016

EwanCrawford committed rL258303: [RenderScript] New command for viewing coordinate of current kernel invocation.
[RenderScript] New command for viewing coordinate of current kernel invocation
Jan 20 2016, 4:07 AM

Jan 18 2016

EwanCrawford committed rL258038: [RenderScript] Remove mips specific expressions.
[RenderScript] Remove mips specific expressions
Jan 18 2016, 1:20 AM

Jan 14 2016

EwanCrawford committed rL257759: Fix ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext.
Fix ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext
Jan 14 2016, 4:22 AM
EwanCrawford closed D16155: possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext by committing rL257759: Fix ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext.
Jan 14 2016, 4:22 AM

Jan 7 2016

EwanCrawford committed rL257061: Remove duplicate header added in r256927.
Remove duplicate header added in r256927
Jan 7 2016, 6:38 AM
EwanCrawford closed D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927 by committing rL257061: Remove duplicate header added in r256927.
Jan 7 2016, 6:38 AM
EwanCrawford accepted D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927.

Since you don't have permission i'll commit this for you

Jan 7 2016, 6:34 AM
EwanCrawford committed rL257045: [RenderScript] Improve file format for saving RS allocations.
[RenderScript] Improve file format for saving RS allocations
Jan 7 2016, 2:22 AM

Jan 6 2016

EwanCrawford committed rL256927: Add LogDump methods to lldb_private::StringList..
Add LogDump methods to lldb_private::StringList.
Jan 6 2016, 3:10 AM
EwanCrawford closed D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers by committing rL256927: Add LogDump methods to lldb_private::StringList..
Jan 6 2016, 3:10 AM

Jan 5 2016

EwanCrawford added a comment to rL256769: Use correct format identifiers to print something meaningful..

Hi Davide,

Jan 5 2016, 5:23 AM
EwanCrawford committed rL256833: Revert r256769.
Revert r256769
Jan 5 2016, 5:22 AM

Dec 17 2015

EwanCrawford committed rL255904: [RenderScript] Support all RS allocation types .
[RenderScript] Support all RS allocation types
Dec 17 2015, 8:43 AM
EwanCrawford committed rL255887: Inspect DW_AT_const_value global static const variables.
Inspect DW_AT_const_value global static const variables
Dec 17 2015, 4:03 AM
EwanCrawford closed D15576: Inspect global static const variables by committing rL255887: Inspect DW_AT_const_value global static const variables.
Dec 17 2015, 4:03 AM

Dec 16 2015

EwanCrawford retitled D15576: Inspect global static const variables from to Inspect global static const variables.
Dec 16 2015, 9:33 AM

Dec 11 2015

EwanCrawford committed rL255338: [RenderScript] Support for amd64 RS hooks.
[RenderScript] Support for amd64 RS hooks
Dec 11 2015, 5:52 AM

Dec 10 2015

EwanCrawford added a comment to D15116: Fix for evaluating a function with an ambiguous symbol .

ping

Dec 10 2015, 8:46 AM
EwanCrawford committed rL255238: [RenderScript] Refactor condition deciding when to JIT RS runtime.
[RenderScript] Refactor condition deciding when to JIT RS runtime
Dec 10 2015, 2:23 AM

Dec 9 2015

EwanCrawford committed rL255121: [RenderScript] Add hook for destroyed allocations.
[RenderScript] Add hook for destroyed allocations
Dec 9 2015, 8:05 AM

Dec 7 2015

EwanCrawford committed rL254910: [RenderScript] Mips64 allocations workaround.
[RenderScript] Mips64 allocations workaround
Dec 7 2015, 5:53 AM

Dec 1 2015

EwanCrawford retitled D15116: Fix for evaluating a function with an ambiguous symbol from to Fix for evaluating a function with an ambiguous symbol .
Dec 1 2015, 8:47 AM
EwanCrawford added a comment to D15092: Fix hang in global static initialization.

Thanks for fixing this Adrian

Dec 1 2015, 1:04 AM

Nov 30 2015

EwanCrawford committed rL254294: [RS] Support RenderScript struct allocations.
[RS] Support RenderScript struct allocations
Nov 30 2015, 2:32 AM

Oct 26 2015

EwanCrawford committed rL251293: [RenderScript] Add option to break on a specific kernel invocation.
[RenderScript] Add option to break on a specific kernel invocation
Oct 26 2015, 7:07 AM

Oct 22 2015

EwanCrawford committed rL251003: [RenderScript] Support for mips64 runtime hook.
[RenderScript] Support for mips64 runtime hook
Oct 22 2015, 2:03 AM

Oct 21 2015

EwanCrawford added a comment to D13903: [RenderScript] New commands to save/load RS allocations to file. .

Thanks for spotting, comitted a quick fix

Oct 21 2015, 3:30 AM
EwanCrawford committed rL250891: [RenderScript] Fix out of bounds warning..
[RenderScript] Fix out of bounds warning.
Oct 21 2015, 3:29 AM
EwanCrawford committed rL250886: [RenderScript] New commands to save/load RS allocations to file..
[RenderScript] New commands to save/load RS allocations to file.
Oct 21 2015, 1:52 AM
EwanCrawford closed D13903: [RenderScript] New commands to save/load RS allocations to file. by committing rL250886: [RenderScript] New commands to save/load RS allocations to file..
Oct 21 2015, 1:52 AM

Oct 20 2015

EwanCrawford retitled D13903: [RenderScript] New commands to save/load RS allocations to file. from to [RenderScript] New commands to save/load RS allocations to file. .
Oct 20 2015, 9:51 AM

Oct 16 2015

EwanCrawford committed rL250499: Resubmit: RenderScript command for printing allocation contents .
Resubmit: RenderScript command for printing allocation contents
Oct 16 2015, 1:30 AM
EwanCrawford closed D13730: Resubmit: RenderScript command for printing allocation contents by committing rL250499: Resubmit: RenderScript command for printing allocation contents .
Oct 16 2015, 1:30 AM

Oct 15 2015

EwanCrawford added a comment to D13699: RenderScript command for printing allocation contents..

Unfortunately there isn't a user-visible variable for the allocation. Information regarding the allocation as a whole is maintained by the runtime.

Oct 15 2015, 1:40 AM

Oct 14 2015

EwanCrawford retitled D13730: Resubmit: RenderScript command for printing allocation contents from to Resubmit: RenderScript command for printing allocation contents .
Oct 14 2015, 9:41 AM
EwanCrawford added a comment to D13699: RenderScript command for printing allocation contents..

No bother, thanks for reverting

Oct 14 2015, 5:56 AM
EwanCrawford added a comment to D13699: RenderScript command for printing allocation contents..

Hi Pavel,
Thanks for letting me know, I'll look into it now.

Oct 14 2015, 3:13 AM
EwanCrawford committed rL250281: RenderScript command for printing allocation contents.
RenderScript command for printing allocation contents
Oct 14 2015, 2:04 AM
EwanCrawford closed D13699: RenderScript command for printing allocation contents. by committing rL250281: RenderScript command for printing allocation contents.
Oct 14 2015, 2:04 AM

Oct 13 2015

EwanCrawford added a comment to D13699: RenderScript command for printing allocation contents..

Hi Bruce,

Oct 13 2015, 8:34 AM
EwanCrawford retitled D13699: RenderScript command for printing allocation contents. from to RenderScript command for printing allocation contents..
Oct 13 2015, 8:22 AM

Oct 6 2015

EwanCrawford committed rL249380: RenderScript command for printing allocation information .
RenderScript command for printing allocation information
Oct 6 2015, 1:44 AM
EwanCrawford closed D13247: RenderScript command for printing allocation information by committing rL249380: RenderScript command for printing allocation information .
Oct 6 2015, 1:44 AM

Sep 29 2015

EwanCrawford retitled D13247: RenderScript command for printing allocation information from to RenderScript command for printing allocation information .
Sep 29 2015, 7:36 AM