Page MenuHomePhabricator

domipheus (Colin Riley)
User

Projects

User does not belong to any projects.

User Details

User Since
May 28 2014, 2:00 AM (368 w, 6 h)

Recent Activity

Jul 23 2015

domipheus added a comment to D11323: Initialize variable to prevent garbage values (RenderScriptRuntime).

All explained there :)

Jul 23 2015, 6:28 AM
domipheus accepted D11452: [lldb-mi] Remove unwanted comment blocks..

Cheers for all this :)

Jul 23 2015, 1:47 AM

Jul 22 2015

domipheus accepted D11323: Initialize variable to prevent garbage values (RenderScriptRuntime).

LGTM, sorry for the delay.

Jul 22 2015, 5:57 AM

Jun 1 2015

domipheus committed rL238768: Additional RenderScript debug features..
Additional RenderScript debug features.
Jun 1 2015, 11:27 AM
domipheus closed D10151: Additional RenderScript debug features by committing rL238768: Additional RenderScript debug features..
Jun 1 2015, 11:27 AM

May 31 2015

domipheus retitled D10151: Additional RenderScript debug features from to Additional RenderScript debug features.
May 31 2015, 3:28 PM

May 27 2015

domipheus committed rL238314: Add a language log category..
Add a language log category.
May 27 2015, 5:52 AM
domipheus closed D9994: Add a language log category by committing rL238314: Add a language log category..
May 27 2015, 5:52 AM

May 25 2015

domipheus retitled D9994: Add a language log category from to Add a language log category.
May 25 2015, 8:42 AM

May 8 2015

domipheus committed rL236836: Fix build on windows..
Fix build on windows.
May 8 2015, 5:21 AM

May 4 2015

domipheus committed rL236443: Add language command and LanguageRuntime plugin changes to allow vending of….
Add language command and LanguageRuntime plugin changes to allow vending of…
May 4 2015, 11:43 AM
domipheus closed D9402: Add language command with ability to load plugin command objects. by committing rL236443: Add language command and LanguageRuntime plugin changes to allow vending of….
May 4 2015, 11:43 AM
domipheus updated the diff for D9402: Add language command with ability to load plugin command objects..

Sorry for the delay in reply - and thanks for the further explanation. How does this look? I've tested it by modifying the renderscript language runtime to use this new method and it works well.

May 4 2015, 9:29 AM

May 1 2015

domipheus added a comment to D9402: Add language command with ability to load plugin command objects..

I re-read the comment and there are sill areas of confusion. Can you define 'after all plug-ins have loaded' for this? The root cause of this problem is there is no defined load point for LanguageRuntimes, before they are requested for grabbing values. That was what I was trying to solve with the explicit load command.

May 1 2015, 7:37 AM

Apr 30 2015

domipheus added a comment to D9402: Add language command with ability to load plugin command objects..

Thanks for the explanation - I'll have a go at implementing it in that style and update the patch tomorrow.

Apr 30 2015, 2:32 PM
domipheus added a comment to D9402: Add language command with ability to load plugin command objects..

Maybe I'm missing something here. There isn't a CommandObjectProxy style object that can resolve on the fly. If there was no load command we'd need to re-execute the command if we wanted built in help.

Apr 30 2015, 10:59 AM
domipheus retitled D9402: Add language command with ability to load plugin command objects. from to Add language command with ability to load plugin command objects..
Apr 30 2015, 9:29 AM

Apr 22 2015

domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

That sounds great - I can create another patch for this if you'd like.

Apr 22 2015, 7:05 AM

Apr 21 2015

domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

There is a variety of things that a language runtime can expose. Scripting languages can expose versions and various other things such as jit/interpeter status and object statuses. RenderScript offers details on object allocations, device capabilities and workload flow. Breakpoints on certain actions could be accomplished, too.

Apr 21 2015, 9:56 AM
domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

There is no need for it to be always created. But at present, I can't see anywhere for the user to load a language runtime explicitly. Would adding a language load command to the plugins group be suitable?

Apr 21 2015, 3:06 AM

Apr 20 2015

domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

It goes a bit further and moves logic down into Process::ModulesDidLoad instead of doing the logic in Target::ModulesDidLoad. Let me know if my patch doesn't solve your problems. Test suite ran clean on MacOSX with this patch, and since only the Objective C runtime is affected, it shouldn't affect anyone else.

Apr 20 2015, 7:43 AM

Apr 17 2015

domipheus added a comment to rL235109: Adds lldb support for querying the register mapping from gdbserver remote….

fixed in rL235179

Apr 17 2015, 4:26 AM
domipheus committed rL235179: Fix cmake build on osx after r235109.
Fix cmake build on osx after r235109
Apr 17 2015, 4:23 AM

Apr 16 2015

domipheus added auditors to rL235109: Adds lldb support for querying the register mapping from gdbserver remote…: clayborg.
Apr 16 2015, 12:48 PM
domipheus added a comment to rL235109: Adds lldb support for querying the register mapping from gdbserver remote….

This will probably be due to the xcodeproj needing updated to reflect the added libxml dependency on the gdbremote projects. Adding the include path to it should do it.

Apr 16 2015, 12:47 PM
domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

Greg, if you're in agreement approve and I'll get this committed.

Apr 16 2015, 9:55 AM
domipheus committed rL235109: Adds lldb support for querying the register mapping from gdbserver remote….
Adds lldb support for querying the register mapping from gdbserver remote…
Apr 16 2015, 8:54 AM
domipheus closed D8999: LLDB qXfer:features:read support by committing rL235109: Adds lldb support for querying the register mapping from gdbserver remote….
Apr 16 2015, 8:54 AM
domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

Thanks for the update, Jim. Would progressing with this patch be okay in the mean time, with the end goal being that we use the knowledge gained from getting RenderScript working, and knowing how it ends up engaging with the other language plugins and the Target/Process to formalise a LanguageRuntimeManager?

Apr 16 2015, 8:05 AM

Apr 15 2015

domipheus added a comment to D9027: Add LLDB C Bindings.

With Zachary on this - I think it would be better to ensure the configuration/input files to the tool that produces these bindings is committed rather than the output itself.

I'm actually still not convinced that even that is the best solution. Hopefully Mukul can expand on why using SWIG directly to generate C# bindings doesn't work. We already have all these swig interface files built up, and the CMake is mostly set up to just work. Why not just use it and generate C# bindings directly?

Apr 15 2015, 12:31 PM
domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

So the main question here is what are you trying to accomplish by adding this call? Your LanguageRuntime plug-in will have a static CreateInstance() and that looks at the target and looks at the image list of that target to see if a shared library is around for the. See the function named "AppleObjCRuntime::GetObjCVersion()" in AppleObjCRuntime.cpp for an example. AppleObjCRuntimeV1::CreateInstance() and AppleObjCRuntimeV2::CreateInstance() call this function to check the targets image list to look for anyone that has certain things in any of the images.

Currently, you call a function in lldb_private::Process to get your language runtime:

virtual ObjCLanguageRuntime *
GetObjCLanguageRuntime (bool retry_if_null = true);

You would add one of these for RenderScript and it would to to call "LanguageRuntime *RenderScriptLanguageRuntime::CreateInstance(Process *process, lldb::LanguageType language)" in order to try and instantiate your runtime. You would then look through the shared libraries to see if your render script shared library is loaded and return a valid instance if it is there, and NULL if not.

Apr 15 2015, 12:29 PM
domipheus added a comment to D9027: Add LLDB C Bindings.

With Zachary on this - I think it would be better to ensure the configuration/input files to the tool that produces these bindings is committed rather than the output itself.

Apr 15 2015, 12:09 PM
domipheus added a comment to D9002: Add ModulesDidLoad to LanguageRuntime.

Any comments on this?

Apr 15 2015, 6:21 AM

Apr 14 2015

domipheus committed rL234871: Additions to RenderScriptRuntime in prep for detection of RenderScript modules….
Additions to RenderScriptRuntime in prep for detection of RenderScript modules…
Apr 14 2015, 12:42 AM
domipheus closed D9001: More additions to RenderScriptRuntime by committing rL234871: Additions to RenderScriptRuntime in prep for detection of RenderScript modules….
Apr 14 2015, 12:42 AM

Apr 13 2015

domipheus retitled D9002: Add ModulesDidLoad to LanguageRuntime from to Add ModulesDidLoad to LanguageRuntime.
Apr 13 2015, 7:56 AM
domipheus retitled D9001: More additions to RenderScriptRuntime from to More additions to RenderScriptRuntime.
Apr 13 2015, 6:41 AM

Apr 12 2015

domipheus committed rL234708: fixing msvc build (format string z is not supported).
fixing msvc build (format string z is not supported)
Apr 12 2015, 3:09 PM

Apr 9 2015

domipheus committed rL234503: Initial language runtime support for RenderScript. .
Initial language runtime support for RenderScript.
Apr 9 2015, 9:52 AM
domipheus closed D8896: Initial RenderScript language runtime by committing rL234503: Initial language runtime support for RenderScript. .
Apr 9 2015, 9:52 AM
domipheus added a comment to D8896: Initial RenderScript language runtime.

any other comments? Are we good to go?

Apr 9 2015, 2:10 AM

Apr 8 2015

domipheus updated the diff for D8896: Initial RenderScript language runtime.

Removed apple ifdef's around RenderScriptRuntime init/terminate.

Apr 8 2015, 1:03 PM
domipheus retitled D8896: Initial RenderScript language runtime from to Initial RenderScript language runtime.
Apr 8 2015, 7:32 AM

Apr 3 2015

domipheus committed rL234002: Adding the RenderScript language type..
Adding the RenderScript language type.
Apr 3 2015, 2:06 AM
domipheus closed D8803: RenderScript Language Type by committing rL234002: Adding the RenderScript language type..
Apr 3 2015, 2:06 AM
domipheus accepted D8803: RenderScript Language Type.

Greg has lgtm'd on list.

Apr 3 2015, 1:55 AM

Apr 2 2015

domipheus changed the visibility for D8803: RenderScript Language Type.
Apr 2 2015, 2:21 PM
domipheus updated the diff for D8803: RenderScript Language Type.

Lowercase name.

Apr 2 2015, 12:00 PM
domipheus retitled D8803: RenderScript Language Type from to RenderScript Language Type.
Apr 2 2015, 9:43 AM

Sep 29 2014

domipheus added a comment to D5503: Very minimal non-8-bit byte support for diverse kalimba architectures.
In D5503#6, @mg11 wrote:

@Jim
Regarding architectures with bytes whose size aren't a multiple of 8-bits, I believe these must be rare beasts indeed nowadays. Apart a colleague mentioning a TI processor (TMS320C5517) and CCL/CSRs XAP processor, both of which are 16-bit, I know only of the Kalimba, as a current-day processor, with non-8-bit-bytes. Well, should any even more exotic creatures show up, then at least I'll have started to pace the way for them...

Sep 29 2014, 1:45 AM

May 28 2014

domipheus added a comment to D3914: [lldb] Fix warnings in the Windows build..

confirmed lldb building fine on visual studio 13

May 28 2014, 2:02 AM