Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159479

[ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement comparation
ClosedPublic
Actions

Authored by jcsxky on Thu, Sep 7, 3:40 AM.

Details

Reviewers
balazske
steakhal
aaron.ballman
NoQ
donat.nagy
Commits
rGb0ea2790c41d: [ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement…
Summary

In the comparation of return statement, return value(if it is CXXBoolLiteralExpr) should be handled explicitly, otherwise an incorrect result would be returned.

Diff Detail

Event Timeline

jcsxky created this revision.Thu, Sep 7, 3:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Sep 7, 3:40 AM
Herald added a subscriber: martong. · View Herald Transcript
jcsxky requested review of this revision.Thu, Sep 7, 3:40 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptThu, Sep 7, 3:40 AM
jcsxky added reviewers: balazske, steakhal, aaron.ballman, NoQ, donat.nagy.Thu, Sep 7, 4:08 AM
donat.nagy accepted this revision.Thu, Sep 7, 4:18 AM

Today we learned that truth is different from falsehood...

LGTM, nice catch!

This revision is now accepted and ready to land.Thu, Sep 7, 4:18 AM
steakhal added a comment.EditedThu, Sep 7, 4:39 AM

Make sure the commit message complies with the guidelines.

Harbormaster completed remote builds in B256780: Diff 556124.Thu, Sep 7, 5:59 AM
jcsxky retitled this revision from [ASTImport]enhance statement comparing to [ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement comparation.Thu, Sep 7, 6:00 AM
jcsxky edited the summary of this revision. (Show Details)
In D159479#4640607, @steakhal wrote:

Make sure the commit message complies with the guidelines.

Fix title and summary.

jcsxky added a comment.Thu, Sep 7, 6:03 AM
In D159479#4640590, @donat.nagy wrote:

Today we learned that truth is different from falsehood...

LGTM, nice catch!

Thanks for your quick review.

steakhal accepted this revision.Thu, Sep 7, 7:08 AM
This revision was landed with ongoing or failed builds.Thu, Sep 7, 11:57 PM
Closed by commit rGb0ea2790c41d: [ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement… (authored by jcsxky, committed by wangpc). · Explain Why
This revision was automatically updated to reflect the committed changes.
wangpc added a commit: rGb0ea2790c41d: [ASTImport]CXXBoolLiteralExpr should be handled explicitly in statement….

Revision Contents
Changeset List

PathSize
clang/
lib/
AST/
4 lines
unittests/
AST/
19 lines

Diff 556232

View Options

clang/lib/AST/ASTStructuralEquivalence.cpp

Loading...
View Options

clang/unittests/AST/StructuralEquivalenceTest.cpp

Loading...