This is an archive of the discontinued LLVM Phabricator instance.

[InlineAsm] Add constraint A to getMemConstraintName
AbandonedPublic

Authored by wangpc on Sep 4 2023, 5:53 AM.

Details

Summary

We will get an assertion of 'Unknown memory constraint' when we dump
MachineOperand with constraint A.

Diff Detail

Event Timeline

wangpc created this revision.Sep 4 2023, 5:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2023, 5:53 AM
wangpc requested review of this revision.Sep 4 2023, 5:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2023, 5:53 AM
wangpc added a reviewer: Jim.Sep 4 2023, 5:54 AM

Oops, we should have fixed it in D124431. Sorry @Jim, I didn't know it.

Jim added inline comments.Sep 4 2023, 7:25 PM
llvm/include/llvm/IR/InlineAsm.h
446

The order look like is low case with alphabetical, capital with alphabetical, ..

wangpc abandoned this revision.EditedSep 4 2023, 9:22 PM

Closed as I want to use this patch to be familiar with Github workflow(https://github.com/llvm/llvm-project/pull/65292).
Thanks all!

wangpc marked an inline comment as done.Sep 4 2023, 10:03 PM