Details
Details
- Reviewers
Petar.Avramovic mbrkusanin arsenm foad
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
2321–2323 | This comment is really old and doesn't make much sense anymore. The existence of nearbyint and rint as an artifact of before there was a direction on how to handle strictfp. We have 3 intrinsics that all mean exactly the same thing, and then constrained versions of all the rounding intrinsics. Really we should just get rid of rint and nearbyint in favor of only having roundeven. Would be better to just make this a generic lower that swaps to one or the other that doesn't need to consider the types |
This comment is really old and doesn't make much sense anymore. The existence of nearbyint and rint as an artifact of before there was a direction on how to handle strictfp.
We have 3 intrinsics that all mean exactly the same thing, and then constrained versions of all the rounding intrinsics. Really we should just get rid of rint and nearbyint in favor of only having roundeven. Would be better to just make this a generic lower that swaps to one or the other that doesn't need to consider the types