This is an archive of the discontinued LLVM Phabricator instance.

Bug fix for D154102, where multi-line labels would get incorrect header splitter line in CFG dot
ClosedPublic

Authored by mark-sed on Aug 30 2023, 7:48 AM.

Details

Summary

Currently when control flow dot graph is generated for a function with basic block name longer than 80 lines, then the header separator will be placed after the line break for the label name instead of after the whole label name. The fix is simple by just moving the insert of | character before the line splitting happens.

A test for this was also added.

Diff Detail

Event Timeline

mark-sed created this revision.Aug 30 2023, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 7:48 AM
mark-sed requested review of this revision.Aug 30 2023, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 7:48 AM
mark-sed updated this revision to Diff 554942.Aug 31 2023, 2:11 AM

Fixed dot-scops-npm.ll test.

apilipenko accepted this revision.Sep 1 2023, 5:04 PM
apilipenko added inline comments.
llvm/test/Other/cfg-multiline-header.ll
16

Nit. Please, add a new line.

This revision is now accepted and ready to land.Sep 1 2023, 5:04 PM
mark-sed updated this revision to Diff 555911.Sep 5 2023, 11:56 AM

Added new line at the end of the test file

This revision was landed with ongoing or failed builds.Sep 5 2023, 10:02 PM
This revision was automatically updated to reflect the committed changes.