Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

mark-sed (Marek Sedláček)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2023, 5:10 AM (26 w, 6 d)

Recent Activity

Wed, Nov 15

mark-sed added a comment to D154096: Tooltips for control flow dot graphs.

@dblaikie Hi, sorry for the late response I want to get back to this and add the test, but got sidetracked by other stuff, I'll add it later. Thanks.

Wed, Nov 15, 8:36 AM · Restricted Project, Restricted Project

Sep 11 2023

mark-sed added a reviewer for D153014: Deduplication of cyclic PHI nodes: anna.
Sep 11 2023, 11:22 AM · Restricted Project, Restricted Project

Sep 5 2023

mark-sed updated the diff for D159207: Bug fix for D154102, where multi-line labels would get incorrect header splitter line in CFG dot.

Added new line at the end of the test file

Sep 5 2023, 11:56 AM · Restricted Project, Restricted Project

Aug 31 2023

mark-sed updated the diff for D159207: Bug fix for D154102, where multi-line labels would get incorrect header splitter line in CFG dot.

Fixed dot-scops-npm.ll test.

Aug 31 2023, 2:11 AM · Restricted Project, Restricted Project

Aug 30 2023

mark-sed requested review of D159207: Bug fix for D154102, where multi-line labels would get incorrect header splitter line in CFG dot.
Aug 30 2023, 7:48 AM · Restricted Project, Restricted Project

Aug 17 2023

mark-sed updated the diff for D154102: Headers for basic blocks in control flow dot graphs.

Fixed tests that were failing. The new implementation does not leave extra whitespace.

Aug 17 2023, 6:28 AM · Restricted Project, Restricted Project

Aug 16 2023

mark-sed added a comment to D153014: Deduplication of cyclic PHI nodes.

Ping @nikic

Aug 16 2023, 9:57 AM · Restricted Project, Restricted Project

Aug 9 2023

mark-sed updated the diff for D154102: Headers for basic blocks in control flow dot graphs.

Added changes requested by apilipenko, where the HandleBasicBlock now prepends the BB name and then appends instructions instead of using << operator on the whole BB.

Aug 9 2023, 6:19 AM · Restricted Project, Restricted Project

Jul 18 2023

mark-sed added inline comments to D154102: Headers for basic blocks in control flow dot graphs.
Jul 18 2023, 1:32 AM · Restricted Project, Restricted Project
mark-sed updated the diff for D154102: Headers for basic blocks in control flow dot graphs.

Fixed typo in a comment.

Jul 18 2023, 1:31 AM · Restricted Project, Restricted Project
mark-sed added inline comments to D154102: Headers for basic blocks in control flow dot graphs.
Jul 18 2023, 1:29 AM · Restricted Project, Restricted Project

Jul 13 2023

mark-sed added a comment to D154096: Tooltips for control flow dot graphs.

I don't have commit rights, could I get someone to commit this for me please?

Jul 13 2023, 2:31 AM · Restricted Project, Restricted Project
mark-sed added a comment to D154092: Monospace font for control flow dot graphs.

I don't have commit rights, could I get someone to commit this for me please?

Jul 13 2023, 2:30 AM · Restricted Project, Restricted Project

Jul 12 2023

mark-sed added a comment to D153014: Deduplication of cyclic PHI nodes.

Ping @nikic

Jul 12 2023, 1:33 AM · Restricted Project, Restricted Project

Jun 30 2023

mark-sed updated the diff for D154102: Headers for basic blocks in control flow dot graphs.

Fixed polly test to contain the new header.

Jun 30 2023, 2:19 AM · Restricted Project, Restricted Project

Jun 29 2023

mark-sed updated the summary of D154092: Monospace font for control flow dot graphs.
Jun 29 2023, 8:44 AM · Restricted Project, Restricted Project
mark-sed updated the summary of D154096: Tooltips for control flow dot graphs.
Jun 29 2023, 8:43 AM · Restricted Project, Restricted Project
mark-sed updated the summary of D154102: Headers for basic blocks in control flow dot graphs.
Jun 29 2023, 8:43 AM · Restricted Project, Restricted Project
mark-sed requested review of D154102: Headers for basic blocks in control flow dot graphs.
Jun 29 2023, 8:41 AM · Restricted Project, Restricted Project
mark-sed requested review of D154096: Tooltips for control flow dot graphs.
Jun 29 2023, 8:36 AM · Restricted Project, Restricted Project
mark-sed requested review of D154092: Monospace font for control flow dot graphs.
Jun 29 2023, 8:33 AM · Restricted Project, Restricted Project

Jun 23 2023

mark-sed updated the diff for D153014: Deduplication of cyclic PHI nodes.

Fix for hash to not break the DenseSet contract and small optimizations

Jun 23 2023, 2:50 PM · Restricted Project, Restricted Project

Jun 19 2023

mark-sed added a comment to D153014: Deduplication of cyclic PHI nodes.

@nikic

The implementation approach is also quite inefficient: We're performing pairwise, recursive comparisons of all phis.

Recursion is of course not ideal, but the comparison has an upper limit. Would you suggest trying to make this into an iterative approach?

Jun 19 2023, 7:09 AM · Restricted Project, Restricted Project

Jun 16 2023

mark-sed updated the diff for D153014: Deduplication of cyclic PHI nodes.

Squashed 2 commits into one to have a correct diff.

Jun 16 2023, 9:22 AM · Restricted Project, Restricted Project
mark-sed updated the diff for D153014: Deduplication of cyclic PHI nodes.

Fixed formatting errors to match clang-format.

Jun 16 2023, 8:37 AM · Restricted Project, Restricted Project

Jun 15 2023

mark-sed requested review of D153014: Deduplication of cyclic PHI nodes.
Jun 15 2023, 4:58 AM · Restricted Project, Restricted Project