[BOLT][test] Enable exceptions_split tests for AArch64

[Elvina]

Summary

Since the issue with trap value was fixed in D158191, tests now should pass on both platforms

[maksfb]

bolt/test/runtime/pie-exceptions-split.test

19

Since you are enabling the test case for *all* platforms, how can you be sure to match all possible variants of the call instruction, i.e. beyond callq and bl? Perhaps, we can match just "printf" without the instruction? Alternatively, you can enable the test for a subset of currently supported architectures.

Otherwise, LGTM.

[Elvina]

updated the diff to check for printf only

bolt/test/runtime/Inputs/exceptions_split.cpp

 // Test that we can have a statement that throws in hot cold
 // and a landing pad in cold code.
 //
 // Record performance data with no args. Run test with 2 args.
 
-#include <stdio.h>
 #include <stdint.h>
+#include <stdio.h>
 
-int foo()
-{
-  return 0;
-}
+int foo() { return 0; }
 
 void bar(int a) {
   if (a > 2 && a % 2)
     throw new int();
 }
 
-void filter_only(){
-  foo();
-}
+void filter_only() { foo(); }
 
-int main(int argc, char **argv)
-{
+int main(int argc, char **argv) {
   unsigned r = 0;
 
   uint64_t limit = (argc >= 2 ? 10 : 5000);
   for (uint64_t i = 0; i < limit; ++i) {
     i += foo();
-    try  {
+    try {
       bar(argc);
       try {
         if (argc >= 2)
           throw new int();
       } catch (...) {
         printf("catch 2\n");
         throw new int();
       }
     } catch (...) {
       printf("catch 1\n");
     }
   }
 
   return 0;
 }

bolt/test/runtime/pie-exceptions-split.test

 
 RUN: llvm-bolt %t -o %t.bolt --data %t.fdata --reorder-blocks=ext-tsp \
 RUN:   --split-functions --split-eh --print-after-lowering \
 RUN:   --print-only=main 2>&1 | FileCheck %s
 
 ## All calls to printf() should be from exception handling code that was
 ## recorded as cold during the profile collection run. Check that the calls
 ## are placed after the split point.
-CHECK-NOT: callq printf
+CHECK-NOT: printf
 CHECK: HOT-COLD SPLIT POINT
-CHECK:     callq printf
+CHECK:     printf
 
 ## Verify the output still executes correctly when the exception path is being
 ## taken.
 RUN: %t.bolt arg1 arg2 arg3 2>&1 | FileCheck --check-prefix=CHECK-BOLTED %s
 
 CHECK-BOLTED:      catch 2
 CHECK-BOLTED-NEXT: catch 1