This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Do not ignore qualifier in heuristic resolution of dependent MemberExpr

Authored by nridge on Aug 25 2023, 11:57 AM.

Diff Detail

Event Timeline

nridge created this revision.Aug 25 2023, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 11:57 AM
nridge requested review of this revision.Aug 25 2023, 11:57 AM
sammccall accepted this revision.Aug 25 2023, 1:12 PM

Oh, this is surprising!


I think the pattern from the testcase clarifies enough to be worth an extra line

void foo() { this->Base::foo(); } shouldn't resolve to foo() itself!

This revision is now accepted and ready to land.Aug 25 2023, 1:12 PM
nridge updated this revision to Diff 553607.Aug 25 2023, 1:53 PM

Address review comment

nridge marked an inline comment as done.Aug 25 2023, 1:53 PM
nridge edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Aug 25 2023, 1:54 PM
This revision was automatically updated to reflect the committed changes.