This is an archive of the discontinued LLVM Phabricator instance.

[StatepointLowering] Fix possible nullptr access in debug output
ClosedPublic

Authored by danilaml on Aug 25 2023, 10:52 AM.

Details

Summary

SI.StatepointInstr would be nullptr if we came from LowerCallSiteWithDeoptBundleImpl.

Diff Detail

Event Timeline

danilaml created this revision.Aug 25 2023, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 10:52 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
danilaml requested review of this revision.Aug 25 2023, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 10:52 AM
danilaml edited the summary of this revision. (Show Details)Aug 25 2023, 10:55 AM
danilaml added reviewers: skatkov, dantrushin, anna.
anna accepted this revision.Aug 25 2023, 12:15 PM
anna added inline comments.
llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
1160

Need this?

This revision is now accepted and ready to land.Aug 25 2023, 12:15 PM
danilaml added inline comments.Aug 25 2023, 1:06 PM
llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
1160

This is intentional, since the "fixed" debug print won't execute for this code path, so this helps trace optimization steps.