PowerPC on linux currently don't have support for lowering long double for
frexp(). Removing the tests until implementation is provided.
Details
Details
- Reviewers
nemanjai amyk daltenty Mordante - Group Reviewers
Restricted Project - Commits
- rG5adac8bebcf2: [PowerPC] Exclude frexp(long double) on linux
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/test/libcxx/numerics/c.math/constexpr-cxx23-clang.pass.cpp | ||
---|---|---|
61 | I prefer an #if ! defined(__LONG_DOUBLE_IBM128__) here instead of moving this line. That keeps the order as expected. |
Comment Actions
Thanks, LGTM from libc++'s perspective!
I don't know whether the used definition __LONG_DOUBLE_IBM128__ is correct, can one of the PowerPC experts validate that? Please wait for an approval of one of the PowerPC experts before landing.
Comment Actions
I think this LGTM. __LONG_DOUBLE_IBM128__ is what we define (on Linux) when we're dealing with the ppcf128 type.
I prefer an #if ! defined(__LONG_DOUBLE_IBM128__) here instead of moving this line. That keeps the order as expected.