This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Presburger] Remove slow applyDomainAndRange test
ClosedPublic

Authored by Groverkss on Aug 21 2023, 4:03 AM.

Download Raw Diff

Details

Reviewers

arjunp
ftynse
bondhugula

Commits

rG189f4aca6893: [mlir][Presburger] Remove slow applyDomainAndRange test

Summary

The test creates two maps, which explode in output size when subtracting,
causing the test to take +11 seconds on a debug build. Removing the slow
test until more simplifications in subtraction are added.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Groverkss created this revision.Aug 21 2023, 4:03 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 4:03 AM

Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript

Groverkss requested review of this revision.Aug 21 2023, 4:03 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 4:03 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Remove the slow test, keep the other test

Herald added a subscriber: jsetoain. · View Herald TranscriptAug 21 2023, 4:08 AM

Groverkss retitled this revision from [mlir][Presburger] Disable applyDomainAndRange test to [mlir][Presburger] Remove slow applyDomainAndRange test.Aug 21 2023, 4:09 AM

Groverkss edited the summary of this revision. (Show Details)

Thanks!

This revision is now accepted and ready to land.Aug 21 2023, 4:12 AM

Harbormaster completed remote builds in B253812: Diff 551973.Aug 21 2023, 4:30 AM

Closed by commit rG189f4aca6893: [mlir][Presburger] Remove slow applyDomainAndRange test (authored by Groverkss). · Explain WhyAug 21 2023, 4:40 AM

This revision was automatically updated to reflect the committed changes.

Groverkss added a commit: rG189f4aca6893: [mlir][Presburger] Remove slow applyDomainAndRange test.

Revision Contents

Path

Size

mlir/

unittests/

Analysis/

Presburger/

PresburgerRelationTest.cpp

40 lines

Diff 551982

mlir/unittests/Analysis/Presburger/PresburgerRelationTest.cpp

Show First 20 Lines • Show All 96 Lines • ▼ Show 20 Lines	PresburgerRelation rel = parsePresburgerRelationFromPresburgerSet(
PresburgerRelation computedRel = rel.intersectRange(set);		PresburgerRelation computedRel = rel.intersectRange(set);
EXPECT_TRUE(computedRel.isEqual(expectedRel));		EXPECT_TRUE(computedRel.isEqual(expectedRel));
}		}
}		}

TEST(PresburgerRelationTest, applyDomainAndRange) {		TEST(PresburgerRelationTest, applyDomainAndRange) {
{		{
PresburgerRelation map1 = parsePresburgerRelationFromPresburgerSet(		PresburgerRelation map1 = parsePresburgerRelationFromPresburgerSet(
{// (x, y) -> (x + N, y - N)
"(x, y, a, b)[N] : (x - a + N == 0, y - b - N == 0)",
// (x, y) -> (y, x)
"(x, y, a, b)[N] : (a - y == 0, b - x == 0)",
// (x, y) -> (x + y, x - y)
"(x, y, a, b)[N] : (a - x - y == 0, b - x + y == 0)"},
2);
PresburgerRelation map2 = parsePresburgerRelationFromPresburgerSet(
{// (x, y) -> (x + y)
"(x, y, r)[N] : (r - x - y == 0)",
// (x, y) -> (N)
"(x, y, r)[N] : (r - N == 0)",
// (x, y) -> (y - x)
"(x, y, r)[N] : (r + x - y == 0)"},
2);

map1.applyRange(map2);

PresburgerRelation map3 = parsePresburgerRelationFromPresburgerSet(
{
// (x, y) -> (x + y)
"(x, y, r)[N] : (r - x - y == 0)",
// (x, y) -> (N)
"(x, y, r)[N] : (r - N == 0)",
// (x, y) -> (y - x - 2N)
"(x, y, r)[N] : (r - y + x + 2 * N == 0)",
// (x, y) -> (x - y)
"(x, y, r)[N] : (r - x + y == 0)",
// (x, y) -> (2x)
"(x, y, r)[N] : (r - 2 * x == 0)",
// (x, y) -> (-2y)
"(x, y, r)[N] : (r + 2 * y == 0)",
},
2);

EXPECT_TRUE(map1.isEqual(map3));
}

{
PresburgerRelation map1 = parsePresburgerRelationFromPresburgerSet(
{// (x, y) -> (y, x)		{// (x, y) -> (y, x)
"(x, y, a, b)[N] : (y - a == 0, x - b == 0)",		"(x, y, a, b)[N] : (y - a == 0, x - b == 0)",
// (x, y) -> (x + N, y - N)		// (x, y) -> (x + N, y - N)
"(x, y, a, b)[N] : (x - a + N == 0, y - b - N == 0)"},		"(x, y, a, b)[N] : (x - a + N == 0, y - b - N == 0)"},
2);		2);
PresburgerRelation map2 = parsePresburgerRelationFromPresburgerSet(		PresburgerRelation map2 = parsePresburgerRelationFromPresburgerSet(
{// (x, y) -> (x - y)		{// (x, y) -> (x - y)
"(x, y, r)[N] : (x - y - r == 0)",		"(x, y, r)[N] : (x - y - r == 0)",
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines